)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"01bc154e8f2c9562876677ad4f74c19a582085f8","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"                          \u0027instance is aleady mapped to cell %s. Ignoring \u0027"},{"line_number":1281,"context_line":"                          \u0027bury in cell0 attempt.\u0027,"},{"line_number":1282,"context_line":"                          inst_mapping.cell_mapping.identity,"},{"line_number":1283,"context_line":"                          instance\u003dinstance)"},{"line_number":1284,"context_line":"                continue"},{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"            with obj_target_cell(instance, cell0) as cctxt:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_79acef33","line":1283,"updated":"2019-09-20 21:14:03.000000000","message":"So in the non-cell0 case, we should do the same sanity check, but not bail so that we map to the real cell. But, log a warning for the forensic value so we can tell this is happening.","commit_id":"8e4f3d9b407ee8742fdde0cf4d824446f127a3ac"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0c47c6c7c0f957ab01f1b81c296492adc8148aeb","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"                          \u0027instance is aleady mapped to cell %s. Ignoring \u0027"},{"line_number":1281,"context_line":"                          \u0027bury in cell0 attempt.\u0027,"},{"line_number":1282,"context_line":"                          inst_mapping.cell_mapping.identity,"},{"line_number":1283,"context_line":"                          instance\u003dinstance)"},{"line_number":1284,"context_line":"                continue"},{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"            with obj_target_cell(instance, cell0) as cctxt:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_992a0b8e","line":1283,"in_reply_to":"3fa7e38b_59501333","updated":"2019-09-20 21:22:15.000000000","message":"Yeah, if this is really what is happening then we could move on to nuking the cell0 clone. However, unless I missed something, we\u0027re still not sure this is really what is going on. In that case I\u0027d tend to say we should wait until we see this forensic evidence in the logs of someone able to repro the issue before we move on to clonicide. You\u0027d really not want to introduce a situation where we blow up both copies.","commit_id":"8e4f3d9b407ee8742fdde0cf4d824446f127a3ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d7308a0e2ddaae632aaa4854cbadd947ba7c2bb","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"                          \u0027instance is aleady mapped to cell %s. Ignoring \u0027"},{"line_number":1281,"context_line":"                          \u0027bury in cell0 attempt.\u0027,"},{"line_number":1282,"context_line":"                          inst_mapping.cell_mapping.identity,"},{"line_number":1283,"context_line":"                          instance\u003dinstance)"},{"line_number":1284,"context_line":"                continue"},{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"            with obj_target_cell(instance, cell0) as cctxt:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_59501333","line":1283,"in_reply_to":"3fa7e38b_79acef33","updated":"2019-09-20 21:18:33.000000000","message":"Is logging enough in that case? Below I mean. Because if we went through here at t0 and created the instance in cell0, then later created the instance in cell1 and updated the mapping, the mapping points at cell1 but we have 2 copies of the instance so when listing instances you might list the wrong one (since it doesn\u0027t care about the mapping to determine which is the \"current\" one). Would we want to delete the instance from cell0 in that case if we hit it? Or mark it hidden (though that hidden field is only new as of Train).","commit_id":"8e4f3d9b407ee8742fdde0cf4d824446f127a3ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"520508a505c106e9ce4af2d5b796ad75df2e9f63","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"                          \u0027instance is aleady mapped to cell %s. Ignoring \u0027"},{"line_number":1281,"context_line":"                          \u0027bury in cell0 attempt.\u0027,"},{"line_number":1282,"context_line":"                          inst_mapping.cell_mapping.identity,"},{"line_number":1283,"context_line":"                          instance\u003dinstance)"},{"line_number":1284,"context_line":"                continue"},{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"            with obj_target_cell(instance, cell0) as cctxt:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_098eb82d","line":1283,"in_reply_to":"3fa7e38b_992a0b8e","updated":"2019-09-23 15:04:55.000000000","message":"Done","commit_id":"8e4f3d9b407ee8742fdde0cf4d824446f127a3ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a6df1e15b04ff311fcb3f12742d76f06878b11d8","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            # Update mapping for instance. Normally this check is guarded by"},{"line_number":1480,"context_line":"            # a try/except but if we\u0027re here we know that a newer nova-api"},{"line_number":1481,"context_line":"            # handled the build process and would have created the mapping"},{"line_number":1482,"context_line":"            inst_mapping \u003d objects.InstanceMapping.get_by_instance_uuid("},{"line_number":1483,"context_line":"                context, instance.uuid)"},{"line_number":1484,"context_line":"            inst_mapping.cell_mapping \u003d cell"},{"line_number":1485,"context_line":"            inst_mapping.save()"},{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"            if not self._delete_build_request("},{"line_number":1488,"context_line":"                    context, build_request, instance, cell, instance_bdms,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_997c4bb6","line":1485,"range":{"start_line":1482,"start_character":12,"end_line":1485,"end_character":31},"updated":"2019-09-20 21:16:39.000000000","message":"You mean here right?","commit_id":"8e4f3d9b407ee8742fdde0cf4d824446f127a3ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"520508a505c106e9ce4af2d5b796ad75df2e9f63","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            # Update mapping for instance. Normally this check is guarded by"},{"line_number":1480,"context_line":"            # a try/except but if we\u0027re here we know that a newer nova-api"},{"line_number":1481,"context_line":"            # handled the build process and would have created the mapping"},{"line_number":1482,"context_line":"            inst_mapping \u003d objects.InstanceMapping.get_by_instance_uuid("},{"line_number":1483,"context_line":"                context, instance.uuid)"},{"line_number":1484,"context_line":"            inst_mapping.cell_mapping \u003d cell"},{"line_number":1485,"context_line":"            inst_mapping.save()"},{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"            if not self._delete_build_request("},{"line_number":1488,"context_line":"                    context, build_request, instance, cell, instance_bdms,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e98a3c19","line":1485,"range":{"start_line":1482,"start_character":12,"end_line":1485,"end_character":31},"in_reply_to":"3fa7e38b_591ed370","updated":"2019-09-23 15:04:55.000000000","message":"Done","commit_id":"8e4f3d9b407ee8742fdde0cf4d824446f127a3ac"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0297f6d697438dbc3bd4eb524c7639f961c86d7b","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            # Update mapping for instance. Normally this check is guarded by"},{"line_number":1480,"context_line":"            # a try/except but if we\u0027re here we know that a newer nova-api"},{"line_number":1481,"context_line":"            # handled the build process and would have created the mapping"},{"line_number":1482,"context_line":"            inst_mapping \u003d objects.InstanceMapping.get_by_instance_uuid("},{"line_number":1483,"context_line":"                context, instance.uuid)"},{"line_number":1484,"context_line":"            inst_mapping.cell_mapping \u003d cell"},{"line_number":1485,"context_line":"            inst_mapping.save()"},{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"            if not self._delete_build_request("},{"line_number":1488,"context_line":"                    context, build_request, instance, cell, instance_bdms,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_591ed370","line":1485,"range":{"start_line":1482,"start_character":12,"end_line":1485,"end_character":31},"in_reply_to":"3fa7e38b_997c4bb6","updated":"2019-09-20 21:22:31.000000000","message":"Jes.","commit_id":"8e4f3d9b407ee8742fdde0cf4d824446f127a3ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2756c4cc642158b4e1c21e3c1b2bdaa2dc8cae62","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"                inst_mapping \u003d \\"},{"line_number":1265,"context_line":"                    objects.InstanceMapping.get_by_instance_uuid("},{"line_number":1266,"context_line":"                        context, instance.uuid)"},{"line_number":1267,"context_line":"            except exception.InstanceMappingNotFound:"},{"line_number":1268,"context_line":"                # The API created the instance mapping record so it should"},{"line_number":1269,"context_line":"                # definitely be here. Log an error but continue to create the"},{"line_number":1270,"context_line":"                # instance in the cell0 database."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1f226601","line":1267,"updated":"2019-09-23 15:07:06.000000000","message":"If we got rid of this we could re-use _map_instance_to_cell here. I don\u0027t think this InstanceMappingNotFound is even relevant anymore, it was just around for newton/ocata upgrade compat.","commit_id":"5b552518e1abdc63fb33c633661e30e4b2fe775e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fb85b634a13bf2fba6750c8bdbd0a6c89d93888a","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"                inst_mapping \u003d \\"},{"line_number":1265,"context_line":"                    objects.InstanceMapping.get_by_instance_uuid("},{"line_number":1266,"context_line":"                        context, instance.uuid)"},{"line_number":1267,"context_line":"            except exception.InstanceMappingNotFound:"},{"line_number":1268,"context_line":"                # The API created the instance mapping record so it should"},{"line_number":1269,"context_line":"                # definitely be here. Log an error but continue to create the"},{"line_number":1270,"context_line":"                # instance in the cell0 database."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_22fe2937","line":1267,"in_reply_to":"3fa7e38b_1f226601","updated":"2019-09-23 15:59:19.000000000","message":"Actually I guess not because _map_instance_to_cell will overwrite and here we definitely don\u0027t want to overwrite or create the instance in cell0. We want the non-cell0 mapping to \"win\".","commit_id":"5b552518e1abdc63fb33c633661e30e4b2fe775e"}]}