)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8a4f74c530c2c83fb29fb8a769de4d932305e8e","unresolved":false,"context_lines":[{"line_number":6874,"context_line":"            non_qos_normal_port, qos_normal_port)"},{"line_number":6875,"context_line":""},{"line_number":6876,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027migrate\u0027: None})"},{"line_number":6877,"context_line":"        # There are ports with resource request but the finish_resize is"},{"line_number":6878,"context_line":"        # called without request_spec (as that is only added in 5.2 an we are"},{"line_number":6879,"context_line":"        # pinned to 5.1) and therefore the request group - resource provider"},{"line_number":6880,"context_line":"        # mapping cannot be calculated for these ports so the server goes to"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c2a2b54b","line":6877,"updated":"2019-09-23 16:07:18.000000000","message":"nit: typically this would be prefixed with FIXME(gibi):.","commit_id":"a3024b5cead9ad8668fcef57bf101ddaf6efea89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8a4f74c530c2c83fb29fb8a769de4d932305e8e","unresolved":false,"context_lines":[{"line_number":6875,"context_line":""},{"line_number":6876,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027migrate\u0027: None})"},{"line_number":6877,"context_line":"        # There are ports with resource request but the finish_resize is"},{"line_number":6878,"context_line":"        # called without request_spec (as that is only added in 5.2 an we are"},{"line_number":6879,"context_line":"        # pinned to 5.1) and therefore the request group - resource provider"},{"line_number":6880,"context_line":"        # mapping cannot be calculated for these ports so the server goes to"},{"line_number":6881,"context_line":"        # ERROR on the target host. This is bug 1844993."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a29f7901","line":6878,"range":{"start_line":6878,"start_character":68,"end_line":6878,"end_character":70},"updated":"2019-09-23 16:07:18.000000000","message":"and","commit_id":"a3024b5cead9ad8668fcef57bf101ddaf6efea89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8a4f74c530c2c83fb29fb8a769de4d932305e8e","unresolved":false,"context_lines":[{"line_number":6889,"context_line":"        self._wait_for_migration_status(server, [\u0027error\u0027])"},{"line_number":6890,"context_line":""},{"line_number":6891,"context_line":"        self.assertIn("},{"line_number":6892,"context_line":"            \u0027Provider mappings are not available to the compute service but \u0027"},{"line_number":6893,"context_line":"            \u0027are required for ports with a resource request. If compute RPC \u0027"},{"line_number":6894,"context_line":"            \u0027API versions are pinned for a rolling upgrade, you will need to \u0027"},{"line_number":6895,"context_line":"            \u0027retry this operation once the RPC version is unpinned and the \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c2bb956f","line":6892,"updated":"2019-09-23 16:07:18.000000000","message":"Yup this comes from here:\n\nhttps://github.com/openstack/nova/blob/5a1c2d4ffa0815e874f373a87eb38b1833d03b24/nova/network/neutronv2/api.py#L3370\n\nwhich is called originally from finish_resize here:\n\nhttps://github.com/openstack/nova/blob/5a1c2d4ffa0815e874f373a87eb38b1833d03b24/nova/compute/manager.py#L4891","commit_id":"a3024b5cead9ad8668fcef57bf101ddaf6efea89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8a4f74c530c2c83fb29fb8a769de4d932305e8e","unresolved":false,"context_lines":[{"line_number":6896,"context_line":"            \u0027nova-compute services are all upgraded\u0027,"},{"line_number":6897,"context_line":"            self.stdlog.logger.output)"},{"line_number":6898,"context_line":""},{"line_number":6899,"context_line":"        self.assertIn("},{"line_number":6900,"context_line":"            \u0027Provider mappings are not available to the compute service but \u0027"},{"line_number":6901,"context_line":"            \u0027are required for ports with a resource request.\u0027,"},{"line_number":6902,"context_line":"            server[\u0027fault\u0027][\u0027message\u0027])"},{"line_number":6903,"context_line":""},{"line_number":6904,"context_line":"        self._wait_for_action_fail_completion("},{"line_number":6905,"context_line":"            server, instance_actions.MIGRATE, \u0027compute_finish_resize\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_42a7a550","line":6902,"range":{"start_line":6899,"start_character":8,"end_line":6902,"end_character":39},"updated":"2019-09-23 16:07:18.000000000","message":"Hmm, unrelated to your change but this error message contains things that the end user probably shouldn\u0027t see...\n\nMaybe \"Provider mappings are not available to the compute service but are required for ports with a resource request.\" would have been enough for the PortUpdateFailed message and the rest about RPC versions should have been logged.","commit_id":"a3024b5cead9ad8668fcef57bf101ddaf6efea89"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"aa5dbc49308680c24636235d92c769017e85f678","unresolved":false,"context_lines":[{"line_number":6914,"context_line":""},{"line_number":6915,"context_line":"        migration_uuid \u003d self.get_migration_uuid_for_instance(server[\u0027id\u0027])"},{"line_number":6916,"context_line":""},{"line_number":6917,"context_line":"        # The migration is failed the migration allocation on the source host"},{"line_number":6918,"context_line":"        # is deleted"},{"line_number":6919,"context_line":"        migration_allocations \u003d self.placement_api.get("},{"line_number":6920,"context_line":"            \u0027/allocations/%s\u0027 % migration_uuid).body[\u0027allocations\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f40be8d2","line":6917,"range":{"start_line":6917,"start_character":27,"end_line":6917,"end_character":37},"updated":"2019-09-23 20:37:40.000000000","message":"missing conjunction here?","commit_id":"a3024b5cead9ad8668fcef57bf101ddaf6efea89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8a4f74c530c2c83fb29fb8a769de4d932305e8e","unresolved":false,"context_lines":[{"line_number":6920,"context_line":"            \u0027/allocations/%s\u0027 % migration_uuid).body[\u0027allocations\u0027]"},{"line_number":6921,"context_line":"        self.assertEqual({}, migration_allocations)"},{"line_number":6922,"context_line":""},{"line_number":6923,"context_line":"        # Note(gibi): inlined _check_allocation() as the current state of the"},{"line_number":6924,"context_line":"        # port binding is complicated that cannot be handled with"},{"line_number":6925,"context_line":"        # _check_allocation"},{"line_number":6926,"context_line":"        updated_non_qos_port \u003d self.neutron.show_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_627741d6","line":6923,"range":{"start_line":6923,"start_character":10,"end_line":6923,"end_character":14},"updated":"2019-09-23 16:07:18.000000000","message":"NOTE; I could have sworn we used to have a hacking check for this (NOTE, TODO, FIXME).","commit_id":"a3024b5cead9ad8668fcef57bf101ddaf6efea89"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"aa5dbc49308680c24636235d92c769017e85f678","unresolved":false,"context_lines":[{"line_number":6921,"context_line":"        self.assertEqual({}, migration_allocations)"},{"line_number":6922,"context_line":""},{"line_number":6923,"context_line":"        # Note(gibi): inlined _check_allocation() as the current state of the"},{"line_number":6924,"context_line":"        # port binding is complicated that cannot be handled with"},{"line_number":6925,"context_line":"        # _check_allocation"},{"line_number":6926,"context_line":"        updated_non_qos_port \u003d self.neutron.show_port("},{"line_number":6927,"context_line":"            non_qos_normal_port[\u0027id\u0027])[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f4344895","line":6924,"range":{"start_line":6924,"start_character":38,"end_line":6924,"end_character":42},"updated":"2019-09-23 20:37:40.000000000","message":"and","commit_id":"a3024b5cead9ad8668fcef57bf101ddaf6efea89"}]}