)]}'
{"nova/context.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8dff1a4c9ec1439f54390f58814a7b8ffde4ab50","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        except exception.CellTimeout:"},{"line_number":446,"context_line":"            # NOTE(melwitt): We\u0027ll fill in did_not_respond_sentinels at the"},{"line_number":447,"context_line":"            # same time we kill/wait for the green threads."},{"line_number":448,"context_line":"            LOG.warning(\u0027Timed out waiting for response from cell %s\u0027,"},{"line_number":449,"context_line":"                        cell_uuid, exc_info\u003dTrue)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # Kill the green threads still pending and wait on those we know are done."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5abcb7ba","line":448,"range":{"start_line":448,"start_character":16,"end_line":448,"end_character":23},"updated":"2019-10-03 19:25:04.000000000","message":"So this wouldn\u0027t normally produce a traceback...","commit_id":"0436a95f37df086ddc99017376cb9a312e40517a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8dff1a4c9ec1439f54390f58814a7b8ffde4ab50","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            # NOTE(melwitt): We\u0027ll fill in did_not_respond_sentinels at the"},{"line_number":447,"context_line":"            # same time we kill/wait for the green threads."},{"line_number":448,"context_line":"            LOG.warning(\u0027Timed out waiting for response from cell %s\u0027,"},{"line_number":449,"context_line":"                        cell_uuid, exc_info\u003dTrue)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # Kill the green threads still pending and wait on those we know are done."},{"line_number":452,"context_line":"    for cell_uuid, greenthread in greenthreads:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3adc5b17","line":449,"range":{"start_line":449,"start_character":35,"end_line":449,"end_character":48},"updated":"2019-10-03 19:25:04.000000000","message":"...but this makes it do so.\n\nAnd we would do this rather than LOG.exception because... we don\u0027t want the message and traceback to show up if we\u0027re filtering out WARNs?","commit_id":"0436a95f37df086ddc99017376cb9a312e40517a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b77b8cab1e8371206aaacf33710216356fb8eda","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            # NOTE(melwitt): We\u0027ll fill in did_not_respond_sentinels at the"},{"line_number":447,"context_line":"            # same time we kill/wait for the green threads."},{"line_number":448,"context_line":"            LOG.warning(\u0027Timed out waiting for response from cell %s\u0027,"},{"line_number":449,"context_line":"                        cell_uuid, exc_info\u003dTrue)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # Kill the green threads still pending and wait on those we know are done."},{"line_number":452,"context_line":"    for cell_uuid, greenthread in greenthreads:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_595eda76","line":449,"range":{"start_line":449,"start_character":24,"end_line":449,"end_character":33},"updated":"2019-10-07 18:01:06.000000000","message":"Oops, UnboundLocalError:\n\nhttps://review.opendev.org/#/c/686996/","commit_id":"0436a95f37df086ddc99017376cb9a312e40517a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e588aaa5f92d29f16c378e585b722af8d21956bd","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            # NOTE(melwitt): We\u0027ll fill in did_not_respond_sentinels at the"},{"line_number":447,"context_line":"            # same time we kill/wait for the green threads."},{"line_number":448,"context_line":"            LOG.warning(\u0027Timed out waiting for response from cell %s\u0027,"},{"line_number":449,"context_line":"                        cell_uuid, exc_info\u003dTrue)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # Kill the green threads still pending and wait on those we know are done."},{"line_number":452,"context_line":"    for cell_uuid, greenthread in greenthreads:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a6682921","line":449,"range":{"start_line":449,"start_character":35,"end_line":449,"end_character":48},"in_reply_to":"3fa7e38b_3adc5b17","updated":"2019-10-04 15:28:46.000000000","message":"Yeah, well, and it\u0027s moving the warning to another place (an exception context) where we can log the traceback. Changing to LOG.exception makes it an ERROR and I didn\u0027t want to make that change here.","commit_id":"0436a95f37df086ddc99017376cb9a312e40517a"}]}
