)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a055a485a9eb40c53d1211f77478246ac487c953","unresolved":false,"context_lines":[{"line_number":10,"context_line":"validating a pre-created volume, we just raise InvalidBDMVolume"},{"line_number":11,"context_line":"which might have a misleading error message for why validation"},{"line_number":12,"context_line":"failed, e.g. it looks like we couldn\u0027t GET the volume but actually"},{"line_number":13,"context_line":"it could be something in later validation that fails."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This simply logs the error at INFO level for later debugging. We"},{"line_number":16,"context_line":"don\u0027t log at WARNING or ERROR because it could be due to some user"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_97a8768c","line":13,"updated":"2019-09-23 21:51:59.000000000","message":"For example, in the patch on top of this we get a KeyError handled in this generic try/except Exception block without this:\n\nhttps://review.opendev.org/#/c/684141/2/nova/tests/fixtures.py@1768\n\nBut it was showing up in the logs as an InvalidBDMVolume.","commit_id":"dc0911d30cdbd0df4905de199edb78f0f188ef8c"}],"nova/compute/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c43d0454b90975e85fdff877bf4d6bd2a5df8f2e","unresolved":false,"context_lines":[{"line_number":1600,"context_line":"                    raise exception.InvalidVolume(reason\u003dexc.format_message())"},{"line_number":1601,"context_line":"                except Exception as e:"},{"line_number":1602,"context_line":"                    LOG.info(\u0027Failed validating volume %s. Error: %s\u0027,"},{"line_number":1603,"context_line":"                             volume_id, e)"},{"line_number":1604,"context_line":"                    raise exception.InvalidBDMVolume(id\u003dvolume_id)"},{"line_number":1605,"context_line":"            elif snapshot_id is not None:"},{"line_number":1606,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1581b7fb","line":1603,"updated":"2019-09-25 15:21:41.000000000","message":"Just stringifying the exception might be frustratingly too little detail to be useful. Better than nothing, but do we have some idea of what could happen here to know that str(e) is enough?","commit_id":"dc0911d30cdbd0df4905de199edb78f0f188ef8c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22f280fc9a1485dc065aa23493838e8e85e9211b","unresolved":false,"context_lines":[{"line_number":1600,"context_line":"                    raise exception.InvalidVolume(reason\u003dexc.format_message())"},{"line_number":1601,"context_line":"                except Exception as e:"},{"line_number":1602,"context_line":"                    LOG.info(\u0027Failed validating volume %s. Error: %s\u0027,"},{"line_number":1603,"context_line":"                             volume_id, e)"},{"line_number":1604,"context_line":"                    raise exception.InvalidBDMVolume(id\u003dvolume_id)"},{"line_number":1605,"context_line":"            elif snapshot_id is not None:"},{"line_number":1606,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d5047f4c","line":1603,"in_reply_to":"3fa7e38b_1581b7fb","updated":"2019-09-25 15:35:59.000000000","message":"I was hitting this in testing with a KeyError, but if Cinder is down we could get CinderConnectionFailed as one non-dev example.","commit_id":"dc0911d30cdbd0df4905de199edb78f0f188ef8c"}]}