)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"faf68c63c568e2885593a2ccb970fa847b73b2f2","unresolved":false,"context_lines":[{"line_number":3319,"context_line":""},{"line_number":3320,"context_line":"    def _connect_all_volumes(self, instance, network_info,"},{"line_number":3321,"context_line":"                             block_device_info\u003dNone):"},{"line_number":3322,"context_line":"        \"\"\"(ab)use _get_guest_storage_config to ensure all volumes are"},{"line_number":3323,"context_line":"        connected (and filesystems are mounted)."},{"line_number":3324,"context_line":"        \"\"\""},{"line_number":3325,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6979012d","line":3322,"updated":"2019-11-01 22:22:35.000000000","message":"Please could we try not to abuse this? We could just pull the code out which does this and call it. It\u0027s problematic code anyway, tbh, as it isn\u0027t at all obvious that _get_guest_storage_config does this, and it\u0027s caught out unwary maintainers a couple of times already.","commit_id":"8be60b8027ac6b76147649d6136a6a8e3a4c4164"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"faf68c63c568e2885593a2ccb970fa847b73b2f2","unresolved":false,"context_lines":[{"line_number":4477,"context_line":"                    self._get_disk_config_image_type())"},{"line_number":4478,"context_line":"                devices.append(diskconfig)"},{"line_number":4479,"context_line":""},{"line_number":4480,"context_line":"        for vol in block_device.get_bdms_to_connect(block_device_mapping,"},{"line_number":4481,"context_line":"                                                   mount_rootfs):"},{"line_number":4482,"context_line":"            connection_info \u003d vol[\u0027connection_info\u0027]"},{"line_number":4483,"context_line":"            vol_dev \u003d block_device.prepend_dev(vol[\u0027mount_device\u0027])"},{"line_number":4484,"context_line":"            info \u003d disk_mapping[vol_dev]"},{"line_number":4485,"context_line":"            self._connect_volume(context, connection_info, instance)"},{"line_number":4486,"context_line":"            if scsi_controller and scsi_controller.model \u003d\u003d \u0027virtio-scsi\u0027:"},{"line_number":4487,"context_line":"                # Check if this is the bootable volume when in a"},{"line_number":4488,"context_line":"                # boot-from-volume instance, and if so, ensure the unit"},{"line_number":4489,"context_line":"                # attribute is 0."},{"line_number":4490,"context_line":"                if vol.get(\u0027boot_index\u0027) \u003d\u003d 0:"},{"line_number":4491,"context_line":"                    info[\u0027unit\u0027] \u003d 0"},{"line_number":4492,"context_line":"                else:"},{"line_number":4493,"context_line":"                    info[\u0027unit\u0027] \u003d disk_mapping[\u0027unit\u0027]"},{"line_number":4494,"context_line":"                    disk_mapping[\u0027unit\u0027] +\u003d 1"},{"line_number":4495,"context_line":"            cfg \u003d self._get_volume_config(connection_info, info)"},{"line_number":4496,"context_line":"            devices.append(cfg)"},{"line_number":4497,"context_line":"            vol[\u0027connection_info\u0027] \u003d connection_info"},{"line_number":4498,"context_line":"            vol.save()"},{"line_number":4499,"context_line":""},{"line_number":4500,"context_line":"        for d in devices:"},{"line_number":4501,"context_line":"            self._set_cache_mode(d)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_89955d34","line":4498,"range":{"start_line":4480,"start_character":1,"end_line":4498,"end_character":22},"updated":"2019-11-01 22:22:35.000000000","message":"It\u0027s here.\n\nI don\u0027t think we need to do the connection_info stuff, either.","commit_id":"8be60b8027ac6b76147649d6136a6a8e3a4c4164"}]}