)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f826c736b83f9905f35dbffae6eb69c922aab56b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova-net: Use nova-net explicitly in \u0027_IntegratedTestBase\u0027 subclasses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Rather than set it on the base class and override where we need to, set"},{"line_number":10,"context_line":"the value on the remaining test cases instead. This should make it"},{"line_number":11,"context_line":"easier to identify the functional tests that need updating."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_c4f10103","line":9,"updated":"2019-09-27 17:59:25.000000000","message":"Yeah I\u0027ve been meaning to do this for a long time.","commit_id":"886a46d3adbd3f13c8da2d47c767e22fbb2d97c7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c82a75944d3009aba24daed50e911620e5d64046","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the value on the individual test cases instead. This should make it"},{"line_number":11,"context_line":"easier to identify the functional tests that need updating."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Existing \u0027USE_NEUTRON \u003d True\u0027 statements are removed as they are now"},{"line_number":14,"context_line":"unnecessary In addition, any tests that work without the explicit"},{"line_number":15,"context_line":"\u0027USE_NEUTRON\u0027 do not have one added."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1b6e340775379964ff149227355a049ecfa73f0e"},{"line_number":18,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_2420e79b","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":36},"updated":"2019-10-01 19:18:27.000000000","message":"This isn\u0027t true anymore.\n\n...though it would make sense to me if you squashed the subsequent patch into this one and made it true.","commit_id":"fc006197c199fc07f415cd145a2aba8bcc46e2bd"}],"nova/tests/functional/api_sample_tests/test_availability_zone.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36a0cd45c5c19089fd02a3f2a5a8d6900965b355","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class AvailabilityZoneJsonTest(test_servers.ServersSampleBase):"},{"line_number":19,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":20,"context_line":"    ADMIN_API \u003d True"},{"line_number":21,"context_line":"    sample_dir \u003d \"os-availability-zone\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_54f7add5","line":19,"updated":"2019-10-03 18:08:20.000000000","message":"This is because the response has a network service in it.","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"}],"nova/tests/functional/api_sample_tests/test_hosts.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36a0cd45c5c19089fd02a3f2a5a8d6900965b355","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class HostsSampleJsonTest(api_sample_base.ApiSampleTestBaseV21):"},{"line_number":20,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":21,"context_line":"    ADMIN_API \u003d True"},{"line_number":22,"context_line":"    sample_dir \u003d \"os-hosts\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d4039dbd","line":20,"updated":"2019-10-03 18:08:20.000000000","message":"OK and this is because the response has a \u0027network\u0027 service in it.","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"}],"nova/tests/functional/api_sample_tests/test_hypervisors.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36a0cd45c5c19089fd02a3f2a5a8d6900965b355","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class HypervisorsSampleJson233Tests(api_sample_base.ApiSampleTestBaseV21):"},{"line_number":104,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":105,"context_line":"    ADMIN_API \u003d True"},{"line_number":106,"context_line":"    sample_dir \u003d \"os-hypervisors\""},{"line_number":107,"context_line":"    microversion \u003d \u00272.33\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_3469d18a","line":104,"updated":"2019-10-03 18:08:20.000000000","message":"I\u0027m not sure why this matters for this test, maybe the host_ip in the sample?","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a22e28fd270b430fe7b8c18a66f5e95ece78e112","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class HypervisorsSampleJson233Tests(api_sample_base.ApiSampleTestBaseV21):"},{"line_number":104,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":105,"context_line":"    ADMIN_API \u003d True"},{"line_number":106,"context_line":"    sample_dir \u003d \"os-hypervisors\""},{"line_number":107,"context_line":"    microversion \u003d \u00272.33\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_94b445f4","line":104,"in_reply_to":"3fa7e38b_3469d18a","updated":"2019-10-03 18:12:51.000000000","message":"We\u0027ve got one less service so the API response changes. Fixed in [1]\n\n[1] https://review.opendev.org/#/c/684340/9/nova/tests/functional/api_sample_tests/test_hypervisors.py","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"}],"nova/tests/functional/api_sample_tests/test_security_group_default_rules.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36a0cd45c5c19089fd02a3f2a5a8d6900965b355","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class SecurityGroupDefaultRulesSampleJsonTest("},{"line_number":19,"context_line":"        api_sample_base.ApiSampleTestBaseV21):"},{"line_number":20,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":21,"context_line":"    ADMIN_API \u003d True"},{"line_number":22,"context_line":"    sample_dir \u003d \u0027os-security-group-default-rules\u0027"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f46339b0","line":20,"updated":"2019-10-03 18:08:20.000000000","message":"This makes sense since the neutron fixture doesn\u0027t do anything about security groups.","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"}],"nova/tests/functional/api_sample_tests/test_server_tags.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36a0cd45c5c19089fd02a3f2a5a8d6900965b355","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ServerTagsJsonTest(test_servers.ServersSampleBase):"},{"line_number":23,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":24,"context_line":"    sample_dir \u003d \u0027os-server-tags\u0027"},{"line_number":25,"context_line":"    microversion \u003d \u00272.26\u0027"},{"line_number":26,"context_line":"    scenarios \u003d [(\u0027v2_26\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d45e3de8","line":23,"updated":"2019-10-03 18:08:20.000000000","message":"I guess this is because of the sample associated with test_server_tags_show_with_details_information?","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a22e28fd270b430fe7b8c18a66f5e95ece78e112","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ServerTagsJsonTest(test_servers.ServersSampleBase):"},{"line_number":23,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":24,"context_line":"    sample_dir \u003d \u0027os-server-tags\u0027"},{"line_number":25,"context_line":"    microversion \u003d \u00272.26\u0027"},{"line_number":26,"context_line":"    scenarios \u003d [(\u0027v2_26\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d4babddf","line":23,"in_reply_to":"3fa7e38b_d45e3de8","updated":"2019-10-03 18:12:51.000000000","message":"It\u0027s because we don\u0027t mock security groups here. Soon as I fix that in [1], we can remove this (done in [2])\n\n[1] https://review.opendev.org/#/c/685927/2\n[2] https://review.opendev.org/#/c/684335/7","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"}],"nova/tests/functional/api_sample_tests/test_simple_tenant_usage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36a0cd45c5c19089fd02a3f2a5a8d6900965b355","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class SimpleTenantUsageV240Test(test_servers.ServersSampleBase):"},{"line_number":74,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":75,"context_line":"    sample_dir \u003d \u0027os-simple-tenant-usage\u0027"},{"line_number":76,"context_line":"    microversion \u003d \u00272.40\u0027"},{"line_number":77,"context_line":"    scenarios \u003d [(\u0027v2_40\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_3450f1d4","line":74,"updated":"2019-10-03 18:08:20.000000000","message":"I\u0027m not sure why this would matter for this test? Maybe the sample associated?","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a22e28fd270b430fe7b8c18a66f5e95ece78e112","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class SimpleTenantUsageV240Test(test_servers.ServersSampleBase):"},{"line_number":74,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":75,"context_line":"    sample_dir \u003d \u0027os-simple-tenant-usage\u0027"},{"line_number":76,"context_line":"    microversion \u003d \u00272.40\u0027"},{"line_number":77,"context_line":"    scenarios \u003d [(\u0027v2_40\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_54e56d09","line":74,"in_reply_to":"3fa7e38b_3450f1d4","updated":"2019-10-03 18:12:51.000000000","message":"The sample, yeah. The instance ID changes for some reason [1]\n\n[1] https://review.opendev.org/#/c/684342/9/nova/tests/functional/api_sample_tests/api_samples/os-simple-tenant-usage/v2.40/simple-tenant-usage-get-all.json.tpl","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"}],"nova/tests/functional/regressions/test_bug_1404867.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6978093f15d4b77f0295a17c77eb4ca552817fe9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":34,"context_line":"    microversion \u003d \u0027latest\u0027"},{"line_number":35,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _setup_compute_service(self):"},{"line_number":38,"context_line":"        # Override `_setup_compute_service` to make sure that we do not start"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_043ab997","line":35,"updated":"2019-09-27 18:02:02.000000000","message":"You remove this in the next patch in the series:\n\nhttps://review.opendev.org/#/c/684327/1/nova/tests/functional/regressions/test_bug_1404867.py","commit_id":"886a46d3adbd3f13c8da2d47c767e22fbb2d97c7"}],"nova/tests/functional/regressions/test_bug_1732947.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6978093f15d4b77f0295a17c77eb4ca552817fe9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":32,"context_line":"    microversion \u003d \u0027latest\u0027"},{"line_number":33,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(RebuildVolumeBackedSameImage, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e442fd0e","line":33,"updated":"2019-09-27 18:02:02.000000000","message":"same:\n\nhttps://review.opendev.org/#/c/684327/1/nova/tests/functional/regressions/test_bug_1732947.py","commit_id":"886a46d3adbd3f13c8da2d47c767e22fbb2d97c7"}],"nova/tests/functional/test_aggregates.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6978093f15d4b77f0295a17c77eb4ca552817fe9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class AggregatesTest(integrated_helpers._IntegratedTestBase):"},{"line_number":33,"context_line":"    api_major_version \u003d \u0027v2\u0027"},{"line_number":34,"context_line":"    ADMIN_API \u003d True"},{"line_number":35,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _add_hosts_to_aggregate(self):"},{"line_number":38,"context_line":"        \"\"\"List all compute services and add them all to an aggregate.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_844d493f","line":35,"updated":"2019-09-27 18:02:02.000000000","message":"same https://review.opendev.org/#/c/684327/1/nova/tests/functional/test_aggregates.py","commit_id":"886a46d3adbd3f13c8da2d47c767e22fbb2d97c7"}],"nova/tests/functional/test_login.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6978093f15d4b77f0295a17c77eb4ca552817fe9","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class LoginTest(integrated_helpers._IntegratedTestBase):"},{"line_number":25,"context_line":"    api_major_version \u003d \u0027v2\u0027"},{"line_number":26,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_login(self):"},{"line_number":29,"context_line":"        # Simple check - we list flavors - so we know we\u0027re logged in."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4453d1e2","line":26,"updated":"2019-09-27 18:02:02.000000000","message":"same https://review.opendev.org/#/c/684327/1/nova/tests/functional/test_login.py","commit_id":"886a46d3adbd3f13c8da2d47c767e22fbb2d97c7"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6978093f15d4b77f0295a17c77eb4ca552817fe9","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"    # We have to cap the microversion at 2.38 because that\u0027s the max we"},{"line_number":1398,"context_line":"    # can use to update image metadata via our compute images proxy API."},{"line_number":1399,"context_line":"    microversion \u003d \u00272.38\u0027"},{"line_number":1400,"context_line":"    USE_NEUTRON \u003d False"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"    def _disable_compute_for(self, server):"},{"line_number":1403,"context_line":"        # Refresh to get its host"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_046399b3","line":1400,"updated":"2019-09-27 18:02:02.000000000","message":"same","commit_id":"886a46d3adbd3f13c8da2d47c767e22fbb2d97c7"}],"nova/tests/functional/wsgi/test_interfaces.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36a0cd45c5c19089fd02a3f2a5a8d6900965b355","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    Functional Test Scope:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    This test uses Neutron."},{"line_number":107,"context_line":"    os-interface API specifies a port ID created by Neutron."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    \"\"\""},{"line_number":110,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_943f6586","line":107,"range":{"start_line":107,"start_character":4,"end_line":107,"end_character":60},"updated":"2019-10-03 18:08:20.000000000","message":"Really?","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36a0cd45c5c19089fd02a3f2a5a8d6900965b355","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        post \u003d {"},{"line_number":124,"context_line":"            \u0027interfaceAttachment\u0027: {"},{"line_number":125,"context_line":"                \u0027net_id\u0027: \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\""},{"line_number":126,"context_line":"            }"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        self.api.attach_interface(created_server_id, post)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_5449ed2f","line":125,"updated":"2019-10-03 18:08:20.000000000","message":"Because that\u0027s not a port_id.","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a22e28fd270b430fe7b8c18a66f5e95ece78e112","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        post \u003d {"},{"line_number":124,"context_line":"            \u0027interfaceAttachment\u0027: {"},{"line_number":125,"context_line":"                \u0027net_id\u0027: \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\""},{"line_number":126,"context_line":"            }"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        self.api.attach_interface(created_server_id, post)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f4d6d927","line":125,"in_reply_to":"3fa7e38b_5449ed2f","updated":"2019-10-03 18:12:51.000000000","message":"I didn\u0027t do it \u003cholds hands up\u003e","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"98ce951da547e9b038fd9c1b715277b14143967d","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        post \u003d {"},{"line_number":124,"context_line":"            \u0027interfaceAttachment\u0027: {"},{"line_number":125,"context_line":"                \u0027net_id\u0027: \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\""},{"line_number":126,"context_line":"            }"},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        self.api.attach_interface(created_server_id, post)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d49f1d63","line":125,"in_reply_to":"3fa7e38b_f4d6d927","updated":"2019-10-03 18:14:40.000000000","message":"Yeah I know, I was just trying to figure out why these were different tests based on networking service.","commit_id":"300b677a3d608671a9fdbd1efe8d2450b5a17846"}]}