)]}'
{"nova/tests/functional/api_sample_tests/api_sample_base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8eab60ac31d8ffaf025a3b01d4cb85267eb5d515","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        super(ApiSampleTestBaseV21, self)._setup_services()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not self.USE_NEUTRON:"},{"line_number":121,"context_line":"            # self.network is only setup if USE_NEUTRON\u003dFalse"},{"line_number":122,"context_line":"            self.useFixture(test.SampleNetworks(host\u003dself.network.host))"},{"line_number":123,"context_line":"        fake_network.stub_compute_with_ips(self)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_3455511e","line":120,"updated":"2019-10-03 18:50:25.000000000","message":"Could have done that down here...","commit_id":"d8ecce5714951802e7f380ca96eb426d57861795"}],"nova/tests/functional/api_sample_tests/api_samples/os-quota-sets/quotas-show-detail-get-resp.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"baf1ee003e8649f88d213baa1e90c7dfd14f4ca6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"reserved\": 0"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"networks\": {"},{"line_number":75,"context_line":"            \"in_use\": 0,"},{"line_number":76,"context_line":"            \"limit\": 3,"},{"line_number":77,"context_line":"            \"reserved\": 0"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3fa7e38b_157f3aab","line":75,"range":{"start_line":75,"start_character":10,"end_line":75,"end_character":24},"updated":"2019-09-29 14:58:24.000000000","message":"or we can use %(int)s but it is hard coded in all places in this sample template so i am ok with this change,","commit_id":"91e684144d2be024b6362322146398908f233b8f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9b00d6e86c22c47cc6a35eb5a6faf5147d3932e8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"reserved\": 0"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"networks\": {"},{"line_number":75,"context_line":"            \"in_use\": 0,"},{"line_number":76,"context_line":"            \"limit\": 3,"},{"line_number":77,"context_line":"            \"reserved\": 0"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_8223b2be","line":75,"updated":"2019-10-03 10:03:38.000000000","message":"From where this 0 is coming? I see one quota related mock in NeutronFixture but that returns -1\n\nhttps://github.com/openstack/nova/blob/caffac7bb06cf7606f7447d0f2ee37ba50dd0b48/nova/tests/fixtures.py#L1629","commit_id":"c135ea1d83fd602b68ef8b769c92d353ffc5b71f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee0d8f8308ac94a53c8410fbd24b71b82295f128","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"reserved\": 0"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"networks\": {"},{"line_number":75,"context_line":"            \"in_use\": 0,"},{"line_number":76,"context_line":"            \"limit\": 3,"},{"line_number":77,"context_line":"            \"reserved\": 0"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_d4db9d1e","line":75,"in_reply_to":"3fa7e38b_0ff28a9b","updated":"2019-10-03 18:24:35.000000000","message":"We shouldn\u0027t even have this in here if we\u0027re using neutron. This is only in the API response if enable_network_quota\u003dTrue in config, and that\u0027s False by default. It\u0027s in here because we\u0027re unconditionally setting it in the base class:\n\nhttps://github.com/openstack/nova/blob/52af043940672fd0fae2f3d82d8f6a237f6c2396/nova/tests/functional/api_sample_tests/api_sample_base.py#L102\n\nSo we should also remove that in this change or make it conditional on USE_NEUTRON.","commit_id":"c135ea1d83fd602b68ef8b769c92d353ffc5b71f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"da38cd024f16fef9401fdee4967ecd0407fac38d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"reserved\": 0"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"networks\": {"},{"line_number":75,"context_line":"            \"in_use\": 0,"},{"line_number":76,"context_line":"            \"limit\": 3,"},{"line_number":77,"context_line":"            \"reserved\": 0"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_0ff28a9b","line":75,"in_reply_to":"3fa7e38b_4fcf2257","updated":"2019-10-03 12:06:01.000000000","message":"Thanks for the explanation.","commit_id":"c135ea1d83fd602b68ef8b769c92d353ffc5b71f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"edc88f8656cef1b1f570f86ed1dff7a3746f4d9f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"reserved\": 0"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"networks\": {"},{"line_number":75,"context_line":"            \"in_use\": 0,"},{"line_number":76,"context_line":"            \"limit\": 3,"},{"line_number":77,"context_line":"            \"reserved\": 0"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_9d9313a4","line":75,"in_reply_to":"3fa7e38b_8223b2be","updated":"2019-10-03 11:54:07.000000000","message":"This took me a while to figure out. The registering of the network quotas seems to come from here:\n\nhttps://github.com/openstack/nova/blob/caffac7bb06cf7606f7447d0f2ee37ba50dd0b48/nova/api/openstack/compute/tenant_networks.py#L182-L194\n\nYou\u0027ll note that that calls directly to the nova-network API manager (nova.network.api.API()). Since we\u0027ve removed \u0027USE_NEUTRON \u003d False\u0027 here, we\u0027re not longer using the \u0027SampleNetworks\u0027 fixture which means the nova-network API manager won\u0027t return anything when we call to \u0027get_all()\u0027.\n\nI wonder if we could make that more explicit and straight up return 0 if neutron is in use? Then again, that whole thing will be going away soon enough so...","commit_id":"c135ea1d83fd602b68ef8b769c92d353ffc5b71f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3aba0e7010e32877a694fcec2521c502662672c9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"reserved\": 0"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"networks\": {"},{"line_number":75,"context_line":"            \"in_use\": 0,"},{"line_number":76,"context_line":"            \"limit\": 3,"},{"line_number":77,"context_line":"            \"reserved\": 0"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_d44abd81","line":75,"in_reply_to":"3fa7e38b_9481a5c6","updated":"2019-10-03 18:46:49.000000000","message":"Just squashed it in here. If I need to rebase because of this, I\u0027ll need to rebase because of other stuff too","commit_id":"c135ea1d83fd602b68ef8b769c92d353ffc5b71f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1f662a111cc6fbbf3cd0c0929e95e84cafb89d7d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"reserved\": 0"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"networks\": {"},{"line_number":75,"context_line":"            \"in_use\": 0,"},{"line_number":76,"context_line":"            \"limit\": 3,"},{"line_number":77,"context_line":"            \"reserved\": 0"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_4fcf2257","line":75,"in_reply_to":"3fa7e38b_9d9313a4","updated":"2019-10-03 12:04:24.000000000","message":"Yeah, that\u0027s not worth doing. Whether it\u0027s present on not hinges on the value of the nova-network-only \u0027enable_network_quota\u0027 config value, which we\u0027re going to be removing soon enough, so better to just remove these then.","commit_id":"c135ea1d83fd602b68ef8b769c92d353ffc5b71f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7bc24074ca32084d4748b6b02aa20760373f8fd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \"reserved\": 0"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"networks\": {"},{"line_number":75,"context_line":"            \"in_use\": 0,"},{"line_number":76,"context_line":"            \"limit\": 3,"},{"line_number":77,"context_line":"            \"reserved\": 0"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3fa7e38b_9481a5c6","line":75,"in_reply_to":"3fa7e38b_d4db9d1e","updated":"2019-10-03 18:37:02.000000000","message":"Clean this up in a FUP tacked on top of this one and I\u0027ll approve.","commit_id":"c135ea1d83fd602b68ef8b769c92d353ffc5b71f"}]}