)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"46fbdbd3447e57a44165ff45a858831db4e0a1aa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova-net: Migrate \u0027test_server_tags\u0027 functional tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This one happens because the \u0027security_groups\u0027 field isn\u0027t present if"},{"line_number":10,"context_line":"you\u0027re using neutron."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia9456055bc4defaefa98cfa82484b9ce5c8792e0"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_7586aebb","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":21},"updated":"2019-09-29 14:15:34.000000000","message":"I was little scared by reading this statement that GET server API behave like this.\n\nBut \u0027security_groups\u0027 is always present for neutron as well as nova-net case. I do not think we need any modification in sample tests.\n - https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L599","commit_id":"9d430a91fede7b9cf923a7e6ebb2017bb9c842bd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1353836169dad1e35afa61ed2e3a4d72285d6d5f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova-net: Migrate \u0027test_server_tags\u0027 functional tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This one happens because the \u0027security_groups\u0027 field isn\u0027t present if"},{"line_number":10,"context_line":"you\u0027re using neutron."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia9456055bc4defaefa98cfa82484b9ce5c8792e0"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_ac161ca7","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"3fa7e38b_7586aebb","updated":"2019-09-30 13:42:33.000000000","message":"There\u0027s still an issue here in that we should always include the field, even if it\u0027s set to [] or null, but yeah, done","commit_id":"9d430a91fede7b9cf923a7e6ebb2017bb9c842bd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31c1101d4c44966237c53c394f2e98b57c5c00bc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"nova-net: Migrate \u0027test_server_tags\u0027 functional tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since we already worked on the NeutronFixture to return security groups"},{"line_number":10,"context_line":"in change Ia9456055bc4defaefa98cfa82484b9ce5c8792e0, this now just"},{"line_number":11,"context_line":"works."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia9456055bc4defaefa98cfa82484b9ce5c8792e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fa7e38b_404cc875","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":51},"updated":"2019-10-03 21:06:24.000000000","message":"This is the wrong change ID, it\u0027s the one for this change, but you want Ibbee7fd11c1aa254e399d302adbae69126e98262.","commit_id":"323997bff00d1a7ef27c31d4f13c505a0a4279a1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a3b1ec2bfff166e0b11f3bcd32b100e3723cc0e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"nova-net: Migrate \u0027test_server_tags\u0027 functional tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since we already worked on the NeutronFixture to return security groups"},{"line_number":10,"context_line":"in change Ia9456055bc4defaefa98cfa82484b9ce5c8792e0, this now just"},{"line_number":11,"context_line":"works."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia9456055bc4defaefa98cfa82484b9ce5c8792e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fa7e38b_ec5da315","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":51},"in_reply_to":"3fa7e38b_404cc875","updated":"2019-10-04 15:40:46.000000000","message":"Ooops, done","commit_id":"323997bff00d1a7ef27c31d4f13c505a0a4279a1"}],"doc/api_samples/servers/v2.69/servers-details-resp.json":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c9004d928a90ea12b4f526db30af0494c1e7d336","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"id\": \"b6b0410f-b65f-4473-855e-5d82a71759e0\","},{"line_number":6,"context_line":"            \"status\": \"UNKNOWN\","},{"line_number":7,"context_line":"            \"tenant_id\": \"6f70656e737461636b20342065766572\","},{"line_number":8,"context_line":"            \"security_groups\": ["},{"line_number":9,"context_line":"                {"},{"line_number":10,"context_line":"                    \"name\": \"default\""},{"line_number":11,"context_line":"                }"},{"line_number":12,"context_line":"            ],"},{"line_number":13,"context_line":"            \"links\": ["},{"line_number":14,"context_line":"                {"},{"line_number":15,"context_line":"                    \"href\": \"http://openstack.example.com/v2.1/6f70656e737461636b20342065766572/servers/b6b0410f-b65f-4473-855e-5d82a71759e0\","}],"source_content_type":"application/json","patch_set":5,"id":"3fa7e38b_810762ca","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":14},"updated":"2019-09-30 17:09:39.000000000","message":"2.69 is for cell-down microversion to return the partial response which does not include security_groups.\n\nit should pass as it is.","commit_id":"745a8dea6b289836a1f02d882ca17dd3e4fc6b0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6aedbae3e1bb5c9a570676710747293925d05024","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"id\": \"b6b0410f-b65f-4473-855e-5d82a71759e0\","},{"line_number":6,"context_line":"            \"status\": \"UNKNOWN\","},{"line_number":7,"context_line":"            \"tenant_id\": \"6f70656e737461636b20342065766572\","},{"line_number":8,"context_line":"            \"security_groups\": ["},{"line_number":9,"context_line":"                {"},{"line_number":10,"context_line":"                    \"name\": \"default\""},{"line_number":11,"context_line":"                }"},{"line_number":12,"context_line":"            ],"},{"line_number":13,"context_line":"            \"links\": ["},{"line_number":14,"context_line":"                {"},{"line_number":15,"context_line":"                    \"href\": \"http://openstack.example.com/v2.1/6f70656e737461636b20342065766572/servers/b6b0410f-b65f-4473-855e-5d82a71759e0\","}],"source_content_type":"application/json","patch_set":5,"id":"3fa7e38b_e422da01","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_0127f2cb","updated":"2019-10-01 10:10:26.000000000","message":"If I remove this, the following test fails:\n\n  nova.tests.functional.api_sample_tests.test_servers.ServersSampleJson269Test.test_servers_details_from_down_cells(v2_69)\n\nIf I keep it, the following fail:\n\n  nova.tests.functional.test_servers.ServerTestV269.test_get_servers_detail_with_down_cells\n  nova.tests.functional.test_servers.ServerTestV269.test_get_servers_detail_all_tenants_with_down_cells\n\nSo I\u0027m not sure what to do. Different samples?","commit_id":"745a8dea6b289836a1f02d882ca17dd3e4fc6b0a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"efc5849bb72ae2088cf5b461ad1c1c37aa5eeede","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"id\": \"b6b0410f-b65f-4473-855e-5d82a71759e0\","},{"line_number":6,"context_line":"            \"status\": \"UNKNOWN\","},{"line_number":7,"context_line":"            \"tenant_id\": \"6f70656e737461636b20342065766572\","},{"line_number":8,"context_line":"            \"security_groups\": ["},{"line_number":9,"context_line":"                {"},{"line_number":10,"context_line":"                    \"name\": \"default\""},{"line_number":11,"context_line":"                }"},{"line_number":12,"context_line":"            ],"},{"line_number":13,"context_line":"            \"links\": ["},{"line_number":14,"context_line":"                {"},{"line_number":15,"context_line":"                    \"href\": \"http://openstack.example.com/v2.1/6f70656e737461636b20342065766572/servers/b6b0410f-b65f-4473-855e-5d82a71759e0\","}],"source_content_type":"application/json","patch_set":5,"id":"3fa7e38b_e1d3b6ff","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_810762ca","updated":"2019-09-30 17:18:34.000000000","message":"server tag tests are passing without this change. you can remove this in this patch.","commit_id":"745a8dea6b289836a1f02d882ca17dd3e4fc6b0a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"53241485926a2a39026d5e8cbafeac827494a51a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"id\": \"b6b0410f-b65f-4473-855e-5d82a71759e0\","},{"line_number":6,"context_line":"            \"status\": \"UNKNOWN\","},{"line_number":7,"context_line":"            \"tenant_id\": \"6f70656e737461636b20342065766572\","},{"line_number":8,"context_line":"            \"security_groups\": ["},{"line_number":9,"context_line":"                {"},{"line_number":10,"context_line":"                    \"name\": \"default\""},{"line_number":11,"context_line":"                }"},{"line_number":12,"context_line":"            ],"},{"line_number":13,"context_line":"            \"links\": ["},{"line_number":14,"context_line":"                {"},{"line_number":15,"context_line":"                    \"href\": \"http://openstack.example.com/v2.1/6f70656e737461636b20342065766572/servers/b6b0410f-b65f-4473-855e-5d82a71759e0\","}],"source_content_type":"application/json","patch_set":5,"id":"3fa7e38b_0127f2cb","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_a1c37eec","updated":"2019-09-30 17:45:23.000000000","message":"and it was not failing for nova-net case because there were no sec grps in DB and so not included in API response also\n\n- https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L608","commit_id":"745a8dea6b289836a1f02d882ca17dd3e4fc6b0a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3c3ec309f1b7a1d9b75c7b14ea78d18f66c516e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"id\": \"b6b0410f-b65f-4473-855e-5d82a71759e0\","},{"line_number":6,"context_line":"            \"status\": \"UNKNOWN\","},{"line_number":7,"context_line":"            \"tenant_id\": \"6f70656e737461636b20342065766572\","},{"line_number":8,"context_line":"            \"security_groups\": ["},{"line_number":9,"context_line":"                {"},{"line_number":10,"context_line":"                    \"name\": \"default\""},{"line_number":11,"context_line":"                }"},{"line_number":12,"context_line":"            ],"},{"line_number":13,"context_line":"            \"links\": ["},{"line_number":14,"context_line":"                {"},{"line_number":15,"context_line":"                    \"href\": \"http://openstack.example.com/v2.1/6f70656e737461636b20342065766572/servers/b6b0410f-b65f-4473-855e-5d82a71759e0\","}],"source_content_type":"application/json","patch_set":5,"id":"3fa7e38b_2133f964","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_a471420f","updated":"2019-10-01 18:45:26.000000000","message":"yeah, I discussed this on IRC with matt[1] about if we missed something in code during 2.69 microversion or its just tests are not properly stubbed. \n\nGET /servers/detail cannot get the instances that are in down cell[2] so there is no issue on code side and we are good. \n\nIt is the test, which need more mock and do not return the down-cell\u0027s instance in functional tests. I will check where to add that in tests (probably in DowncellFixture).\n\n[1]  http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-09-30.log.html#t2019-09-30T17:41:51\n\n[2] https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/compute/multi_cell_list.py#L414","commit_id":"745a8dea6b289836a1f02d882ca17dd3e4fc6b0a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b00bcc54d3a8177fe09a4bb440ea5b67dffeb8e7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"id\": \"b6b0410f-b65f-4473-855e-5d82a71759e0\","},{"line_number":6,"context_line":"            \"status\": \"UNKNOWN\","},{"line_number":7,"context_line":"            \"tenant_id\": \"6f70656e737461636b20342065766572\","},{"line_number":8,"context_line":"            \"security_groups\": ["},{"line_number":9,"context_line":"                {"},{"line_number":10,"context_line":"                    \"name\": \"default\""},{"line_number":11,"context_line":"                }"},{"line_number":12,"context_line":"            ],"},{"line_number":13,"context_line":"            \"links\": ["},{"line_number":14,"context_line":"                {"},{"line_number":15,"context_line":"                    \"href\": \"http://openstack.example.com/v2.1/6f70656e737461636b20342065766572/servers/b6b0410f-b65f-4473-855e-5d82a71759e0\","}],"source_content_type":"application/json","patch_set":5,"id":"3fa7e38b_a1c37eec","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_e1d3b6ff","updated":"2019-09-30 17:38:53.000000000","message":"seems like sec groups are added for down cell response also for detail GET API case which seems not correct. Show API never include the sec grp for down call case.\nThis could have been missed in 2.69 microversion as _add_security_grps function is called explicitly for detail GET case.\n\n\n- https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L410","commit_id":"745a8dea6b289836a1f02d882ca17dd3e4fc6b0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8e1400fd71a381dd1be09660a54e7cac77daf06e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"id\": \"b6b0410f-b65f-4473-855e-5d82a71759e0\","},{"line_number":6,"context_line":"            \"status\": \"UNKNOWN\","},{"line_number":7,"context_line":"            \"tenant_id\": \"6f70656e737461636b20342065766572\","},{"line_number":8,"context_line":"            \"security_groups\": ["},{"line_number":9,"context_line":"                {"},{"line_number":10,"context_line":"                    \"name\": \"default\""},{"line_number":11,"context_line":"                }"},{"line_number":12,"context_line":"            ],"},{"line_number":13,"context_line":"            \"links\": ["},{"line_number":14,"context_line":"                {"},{"line_number":15,"context_line":"                    \"href\": \"http://openstack.example.com/v2.1/6f70656e737461636b20342065766572/servers/b6b0410f-b65f-4473-855e-5d82a71759e0\","}],"source_content_type":"application/json","patch_set":5,"id":"3fa7e38b_a471420f","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_e422da01","updated":"2019-10-01 10:11:13.000000000","message":"Here\u0027s the failure: http://paste.openstack.org/show/780547/","commit_id":"745a8dea6b289836a1f02d882ca17dd3e4fc6b0a"}]}