)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6541953a15f4727ca84aa88da7de78cdc3152f9c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova-net: Migrate \u0027test_servers\u0027 functional tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most of these are simply resolved by removing \u0027security_groups\u0027 from the"},{"line_number":10,"context_line":"response (isn\u0027t that a config-driven API change?), but three tests"},{"line_number":11,"context_line":"require modification to specifically request an API that our"},{"line_number":12,"context_line":"NeutronFixture provides. Still, nothing complicated here."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I423b7ab5c98ea9d559caefec0b49271e28a140fa"},{"line_number":15,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_358cb6d5","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":57},"updated":"2019-09-29 14:36:05.000000000","message":"\u0027security_groups\u0027 are always present in response and it is not config driven.[1]\n\nTest fail because we do not stub get_instances_security_groups_bindings() (which is used by API to fetch the sec grps in case of neutron) function with real value in NeutronFixture. Once we fix the NeutronFixture all tests should pass.\n- https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/tests/fixtures.py#L1505\n\n[1] https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/views/servers.py#L599","commit_id":"7cf1fe7037984597aafc3575801c0015b9ed0d3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08f921c65d37f042c9c4bbb4fba117295bceac16","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova-net: Migrate \u0027test_servers\u0027 functional tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Three tests require modification to specifically request an API that our"},{"line_number":10,"context_line":"NeutronFixture provides. The rest just work (TM)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I423b7ab5c98ea9d559caefec0b49271e28a140fa"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fa7e38b_321f9071","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":24},"updated":"2019-10-04 17:40:13.000000000","message":"This isn\u0027t actually true now and can be reworded by whoever approves, if necessary.","commit_id":"aabf8cc2d0d6eed5249629eed68f94e42021a60b"}],"doc/api_samples/servers/v2.32/server-create-req.json":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2db683487c0df2c31078cfccc36196ff06d8ade5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\" : \"device-tagging-server\","},{"line_number":4,"context_line":"        \"flavorRef\" : \"http://openstack.example.com/flavors/1\","},{"line_number":5,"context_line":"        \"networks\" : [{"},{"line_number":6,"context_line":"            \"uuid\" : \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\","},{"line_number":7,"context_line":"            \"tag\": \"nic1\""},{"line_number":8,"context_line":"        }],"},{"line_number":9,"context_line":"        \"block_device_mapping_v2\": [{"}],"source_content_type":"application/json","patch_set":10,"id":"3fa7e38b_d52dc6a8","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":58},"updated":"2019-10-04 18:03:14.000000000","message":"ack, hard-coded to neutron fixture network_1","commit_id":"aabf8cc2d0d6eed5249629eed68f94e42021a60b"}],"nova/tests/functional/api_sample_tests/api_samples/servers/v2.32/server-create-req.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"418cb58a2c495c9dc057352d96085e5b1afaa5d0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\" : \"device-tagging-server\","},{"line_number":4,"context_line":"        \"flavorRef\" : \"%(host)s/flavors/1\","},{"line_number":5,"context_line":"        \"networks\" : [{"},{"line_number":6,"context_line":"            \"uuid\" : \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\","},{"line_number":7,"context_line":"            \"tag\": \"nic1\""},{"line_number":8,"context_line":"        }],"},{"line_number":9,"context_line":"        \"block_device_mapping_v2\": [{"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_a1d7fe4a","line":6,"range":{"start_line":6,"start_character":21,"end_line":6,"end_character":58},"updated":"2019-09-30 17:06:56.000000000","message":"we can use \"%(uuid)s\" here to avoid changing the uuid value everytime.","commit_id":"8a741cfeb4d22a3c8e9394fd38ab844d404c0ef4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a988f87a66c4b32356d485e35e35bd6019fdd2c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\" : \"device-tagging-server\","},{"line_number":4,"context_line":"        \"flavorRef\" : \"%(host)s/flavors/1\","},{"line_number":5,"context_line":"        \"networks\" : [{"},{"line_number":6,"context_line":"            \"uuid\" : \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\","},{"line_number":7,"context_line":"            \"tag\": \"nic1\""},{"line_number":8,"context_line":"        }],"},{"line_number":9,"context_line":"        \"block_device_mapping_v2\": [{"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_1d0dd936","line":6,"range":{"start_line":6,"start_character":21,"end_line":6,"end_character":58},"in_reply_to":"3fa7e38b_0ddb994f","updated":"2019-10-03 19:46:30.000000000","message":"oh, you need to add the subs[\u0027uuid\u0027] \u003d \u003cnet-uuid\u003e with actual value as this is in req body. \n\nI am ok with changing the value in this patch and later we make it generic.","commit_id":"8a741cfeb4d22a3c8e9394fd38ab844d404c0ef4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c9eb28d8af3d0baa77f0bffa44daf90b982a50f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\" : \"device-tagging-server\","},{"line_number":4,"context_line":"        \"flavorRef\" : \"%(host)s/flavors/1\","},{"line_number":5,"context_line":"        \"networks\" : [{"},{"line_number":6,"context_line":"            \"uuid\" : \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\","},{"line_number":7,"context_line":"            \"tag\": \"nic1\""},{"line_number":8,"context_line":"        }],"},{"line_number":9,"context_line":"        \"block_device_mapping_v2\": [{"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_0ddb994f","line":6,"range":{"start_line":6,"start_character":21,"end_line":6,"end_character":58},"in_reply_to":"3fa7e38b_a1d7fe4a","updated":"2019-10-01 12:42:06.000000000","message":"This doesn\u0027t work:\n\n  Traceback (most recent call last):\n    File \"nova/tests/functional/api_sample_tests/test_servers.py\", line 210, in test_servers_post\n      self._post_server(use_common_server_api_samples\u003dFalse)\n    File \"nova/tests/functional/api_sample_tests/test_servers.py\", line 97, in _post_server\n      response, 202)\n    File \"nova/tests/functional/api_samples_test_base.py\", line 366, in _verify_response\n      self.assertEqual(exp_code, response.status_code, message)\n    File \"/home/zuul/src/opendev.org/openstack/nova/.tox/functional/local/lib/python2.7/site-packages/testtools/testcase.py\", line 411, in assertEqual\n      self.assertThat(observed, matcher, message)\n    File \"/home/zuul/src/opendev.org/openstack/nova/.tox/functional/local/lib/python2.7/site-packages/testtools/testcase.py\", line 498, in assertThat\n      raise mismatch_error\n  testtools.matchers._impl.MismatchError: 202 !\u003d 400: {\"badRequest\": {\"code\": 400, \"message\": \"Bad networks format: network uuid is not in proper format ([0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})\"}","commit_id":"8a741cfeb4d22a3c8e9394fd38ab844d404c0ef4"}],"nova/tests/functional/api_sample_tests/api_samples/servers/v2.42/server-create-req.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"418cb58a2c495c9dc057352d96085e5b1afaa5d0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\" : \"device-tagging-server\","},{"line_number":4,"context_line":"        \"flavorRef\" : \"%(host)s/flavors/1\","},{"line_number":5,"context_line":"        \"networks\" : [{"},{"line_number":6,"context_line":"            \"uuid\" : \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\","},{"line_number":7,"context_line":"            \"tag\": \"nic1\""},{"line_number":8,"context_line":"        }],"},{"line_number":9,"context_line":"        \"block_device_mapping_v2\": [{"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_61cd86b5","line":6,"range":{"start_line":6,"start_character":21,"end_line":6,"end_character":59},"updated":"2019-09-30 17:06:56.000000000","message":"ditto","commit_id":"8a741cfeb4d22a3c8e9394fd38ab844d404c0ef4"}],"nova/tests/functional/api_sample_tests/api_samples/servers/v2.67/server-create-req.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"418cb58a2c495c9dc057352d96085e5b1afaa5d0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\" : \"bfv-server-with-volume-type\","},{"line_number":4,"context_line":"        \"flavorRef\" : \"%(host)s/flavors/1\","},{"line_number":5,"context_line":"        \"networks\" : [{"},{"line_number":6,"context_line":"            \"uuid\" : \"3cb9bc59-5699-4588-a4b1-b87f96708bc6\","},{"line_number":7,"context_line":"            \"tag\": \"nic1\""},{"line_number":8,"context_line":"        }],"},{"line_number":9,"context_line":"        \"block_device_mapping_v2\": [{"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa7e38b_21c30e8b","line":6,"range":{"start_line":6,"start_character":21,"end_line":6,"end_character":60},"updated":"2019-09-30 17:06:56.000000000","message":"ditto","commit_id":"8a741cfeb4d22a3c8e9394fd38ab844d404c0ef4"}]}
