)]}'
{"nova/tests/functional/api_sample_tests/test_attach_interfaces.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c496b4b2fbde6c26765c5386661394ff296c6d49","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _stub_show_for_instance(self, instance_uuid, port_id):"},{"line_number":102,"context_line":"        show_port \u003d self.neutron.show_port(port_id)"},{"line_number":103,"context_line":"        show_port[\u0027port\u0027][\u0027device_id\u0027] \u003d instance_uuid"},{"line_number":104,"context_line":"        self.stub_out(\u0027nova.network.neutronv2.api.API.show_port\u0027,"},{"line_number":105,"context_line":"                      lambda *a, **k: show_port)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_60a45209","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":54},"updated":"2019-10-04 18:12:39.000000000","message":"I want to say at some point I had worked on the NeutronFixture actually tracking attachments via the device_id but can\u0027t find that now, which is unfortunate because it would mean we can avoid the stubs in here and just let the fixture track the state (like CinderFixture does to an extent).","commit_id":"8098633ad4b705247e11f44e14349930ce145d89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c496b4b2fbde6c26765c5386661394ff296c6d49","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_show_interfaces(self):"},{"line_number":108,"context_line":"        instance_uuid \u003d self._post_server()"},{"line_number":109,"context_line":"        # NOTE(stephenfin): This ID is taken from the NeutronFixture"},{"line_number":110,"context_line":"        port_id \u003d \u0027ce531f90-199f-48c0-816c-13e38010b442\u0027"},{"line_number":111,"context_line":"        self._stub_show_for_instance(instance_uuid, port_id)"},{"line_number":112,"context_line":"        response \u003d self._do_get(\u0027servers/%s/os-interface/%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_e06282d8","line":109,"updated":"2019-10-04 18:12:39.000000000","message":"Why not access the variable in the NeutronFixture directly? I guess it\u0027s also hard-coded in the samples/templates, but anyway, would be nice to just reference the variables in the fixture than copy hard-coded IDs around.","commit_id":"8098633ad4b705247e11f44e14349930ce145d89"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"066b611fb3754bcbc879d714d49e9ef29d783fe7","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_show_interfaces(self):"},{"line_number":108,"context_line":"        instance_uuid \u003d self._post_server()"},{"line_number":109,"context_line":"        # NOTE(stephenfin): This ID is taken from the NeutronFixture"},{"line_number":110,"context_line":"        port_id \u003d \u0027ce531f90-199f-48c0-816c-13e38010b442\u0027"},{"line_number":111,"context_line":"        self._stub_show_for_instance(instance_uuid, port_id)"},{"line_number":112,"context_line":"        response \u003d self._do_get(\u0027servers/%s/os-interface/%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_c0918648","line":109,"in_reply_to":"3fa7e38b_e06282d8","updated":"2019-10-04 18:30:20.000000000","message":"yeah same in POST server req template also. - https://review.opendev.org/#/c/684336/5/nova/tests/functional/api_sample_tests/api_samples/servers/v2.32/server-create-req.json.tpl@6","commit_id":"8098633ad4b705247e11f44e14349930ce145d89"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c496b4b2fbde6c26765c5386661394ff296c6d49","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_delete_interfaces(self):"},{"line_number":142,"context_line":"        instance_uuid \u003d self._post_server()"},{"line_number":143,"context_line":"        # NOTE(stephenfin): This ID is taken from the NeutronFixture"},{"line_number":144,"context_line":"        port_id \u003d \u0027ce531f90-199f-48c0-816c-13e38010b442\u0027"},{"line_number":145,"context_line":"        response \u003d self._do_delete(\u0027servers/%s/os-interface/%s\u0027 %"},{"line_number":146,"context_line":"                                (instance_uuid, port_id))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_20ae5ae7","line":143,"updated":"2019-10-04 18:12:39.000000000","message":"same","commit_id":"8098633ad4b705247e11f44e14349930ce145d89"}]}
