)]}'
{"nova/tests/functional/api_sample_tests/test_floating_ips.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"124ca8d629e06da9b66cd379d9b680c7a1b91362","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO(stephenfin): Merge this back into the main class. We have to be careful"},{"line_number":25,"context_line":"# with how we do this since if we register two networks we\u0027ll have ambiguous"},{"line_number":26,"context_line":"# networks breaking auto-allocation"},{"line_number":27,"context_line":"class NeutronFixture(fixtures.NeutronFixture):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    network_1 \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_a973ae4d","line":26,"updated":"2019-10-11 14:57:34.000000000","message":"I saw the same problem in or bandwidth tests. I circumvented it by creating the second network for those tests specifically.","commit_id":"52cc4bfa0a174b45bee9d9b084cbbe809113fb59"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"124ca8d629e06da9b66cd379d9b680c7a1b91362","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        if floatingip not in self._floatingips:"},{"line_number":156,"context_line":"            raise Exception(\u0027This floating IP has not been added yet\u0027)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return {\u0027floatingip\u0027: self._floatingips[floatingip]}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def list_floatingips(self, retrieve_all\u003dTrue, **_params):"},{"line_number":161,"context_line":"        return {\u0027floatingips\u0027: copy.deepcopy(list(self._floatingips.values()))}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_898fd228","line":158,"range":{"start_line":158,"start_character":31,"end_line":158,"end_character":59},"updated":"2019-10-11 14:57:34.000000000","message":"I would add a deepcopy here. If the client gets the floatingip then modify the dict locally, then re-query the same ip it will not get back the original one any more.","commit_id":"52cc4bfa0a174b45bee9d9b084cbbe809113fb59"}]}