)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e711966542d7dbc2d59aef5d81a78db790e7d707","unresolved":false,"context_lines":[{"line_number":2447,"context_line":"                                  uuid\u003dnetwork[\u0027id\u0027])"},{"line_number":2448,"context_line":"        return net_obj"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"    def create(self, context, **kwargs):"},{"line_number":2451,"context_line":"        \"\"\"Create a network.\"\"\""},{"line_number":2452,"context_line":"        raise NotImplementedError()"},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"    def delete(self, context, network_uuid):"},{"line_number":2455,"context_line":"        \"\"\"Delete a network for client.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_35283695","line":2452,"range":{"start_line":2450,"start_character":0,"end_line":2452,"end_character":35},"updated":"2019-09-29 15:25:59.000000000","message":"this is not needed as base class raise the NotImplementedError[1].\n\nI saw we are not catching NotImplementedError in POST network API[2] but that API is going to be removed with nova-net removal so it should be fine not to fix that.\n\n[1] https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/network/base_api.py#L107\n\n[2]https://github.com/openstack/nova/blob/961c2945491ebcea3cf1cb175a06d057155aa5a5/nova/api/openstack/compute/networks.py#L142","commit_id":"2364e8721d951681eb3b76325f1bc3fae791cc44"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2daf523839c6e429222caa4040a43cf0c3bd48b0","unresolved":false,"context_lines":[{"line_number":2447,"context_line":"                                  uuid\u003dnetwork[\u0027id\u0027])"},{"line_number":2448,"context_line":"        return net_obj"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"    def create(self, context, **kwargs):"},{"line_number":2451,"context_line":"        \"\"\"Create a network.\"\"\""},{"line_number":2452,"context_line":"        raise NotImplementedError()"},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"    def delete(self, context, network_uuid):"},{"line_number":2455,"context_line":"        \"\"\"Delete a network for client.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f2270ac6","line":2452,"range":{"start_line":2450,"start_character":0,"end_line":2452,"end_character":35},"in_reply_to":"3fa7e38b_35283695","updated":"2019-09-30 14:04:44.000000000","message":"Aye, neither are any of the below. However, since those are here it seemed sensible to add this too. As you say, we\u0027ll be removing it all soon","commit_id":"2364e8721d951681eb3b76325f1bc3fae791cc44"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b20f5092c6e6913e1a791be0e67a0858541b9674","unresolved":false,"context_lines":[{"line_number":2447,"context_line":"                                  uuid\u003dnetwork[\u0027id\u0027])"},{"line_number":2448,"context_line":"        return net_obj"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"    def create(self, context, **kwargs):"},{"line_number":2451,"context_line":"        \"\"\"Create a network.\"\"\""},{"line_number":2452,"context_line":"        raise NotImplementedError()"},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"    def delete(self, context, network_uuid):"},{"line_number":2455,"context_line":"        \"\"\"Delete a network for client.\"\"\""},{"line_number":2456,"context_line":"        raise NotImplementedError()"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"    def disassociate(self, context, network_uuid):"},{"line_number":2459,"context_line":"        \"\"\"Disassociate a network for client.\"\"\""},{"line_number":2460,"context_line":"        raise NotImplementedError()"},{"line_number":2461,"context_line":""},{"line_number":2462,"context_line":"    def associate(self, context, network_uuid, host\u003dbase_api.SENTINEL,"},{"line_number":2463,"context_line":"                  project\u003dbase_api.SENTINEL):"},{"line_number":2464,"context_line":"        \"\"\"Associate a network for client.\"\"\""},{"line_number":2465,"context_line":"        raise NotImplementedError()"},{"line_number":2466,"context_line":""},{"line_number":2467,"context_line":"    def get_fixed_ip(self, context, id):"},{"line_number":2468,"context_line":"        \"\"\"Get a fixed IP from the id.\"\"\""},{"line_number":2469,"context_line":"        raise NotImplementedError()"},{"line_number":2470,"context_line":""},{"line_number":2471,"context_line":"    def get_fixed_ip_by_address(self, context, address):"},{"line_number":2472,"context_line":"        \"\"\"Return instance uuids given an address.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_ff21439f","line":2469,"range":{"start_line":2450,"start_character":0,"end_line":2469,"end_character":35},"updated":"2019-10-30 17:12:33.000000000","message":"I\u0027m a bit confused as to why these need to exist here.\n\nWithout this part of the delta, all you\u0027ve done is add comments, which is an easy A.","commit_id":"4c59086949e2bda272c8aa170373e037cb1e1fb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aff645004d47db46caa67bb58087ff6519f2db17","unresolved":false,"context_lines":[{"line_number":2447,"context_line":"                                  uuid\u003dnetwork[\u0027id\u0027])"},{"line_number":2448,"context_line":"        return net_obj"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"    def create(self, context, **kwargs):"},{"line_number":2451,"context_line":"        \"\"\"Create a network.\"\"\""},{"line_number":2452,"context_line":"        raise NotImplementedError()"},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"    def delete(self, context, network_uuid):"},{"line_number":2455,"context_line":"        \"\"\"Delete a network for client.\"\"\""},{"line_number":2456,"context_line":"        raise NotImplementedError()"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"    def disassociate(self, context, network_uuid):"},{"line_number":2459,"context_line":"        \"\"\"Disassociate a network for client.\"\"\""},{"line_number":2460,"context_line":"        raise NotImplementedError()"},{"line_number":2461,"context_line":""},{"line_number":2462,"context_line":"    def associate(self, context, network_uuid, host\u003dbase_api.SENTINEL,"},{"line_number":2463,"context_line":"                  project\u003dbase_api.SENTINEL):"},{"line_number":2464,"context_line":"        \"\"\"Associate a network for client.\"\"\""},{"line_number":2465,"context_line":"        raise NotImplementedError()"},{"line_number":2466,"context_line":""},{"line_number":2467,"context_line":"    def get_fixed_ip(self, context, id):"},{"line_number":2468,"context_line":"        \"\"\"Get a fixed IP from the id.\"\"\""},{"line_number":2469,"context_line":"        raise NotImplementedError()"},{"line_number":2470,"context_line":""},{"line_number":2471,"context_line":"    def get_fixed_ip_by_address(self, context, address):"},{"line_number":2472,"context_line":"        \"\"\"Return instance uuids given an address.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_cfa3dc42","line":2469,"range":{"start_line":2450,"start_character":0,"end_line":2469,"end_character":35},"in_reply_to":"3fa7e38b_7de3c6d9","updated":"2019-11-13 17:53:02.000000000","message":"Done","commit_id":"4c59086949e2bda272c8aa170373e037cb1e1fb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"680f62d09d19e3167adf58b7c61ab8ba1c6c3a51","unresolved":false,"context_lines":[{"line_number":2447,"context_line":"                                  uuid\u003dnetwork[\u0027id\u0027])"},{"line_number":2448,"context_line":"        return net_obj"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"    def create(self, context, **kwargs):"},{"line_number":2451,"context_line":"        \"\"\"Create a network.\"\"\""},{"line_number":2452,"context_line":"        raise NotImplementedError()"},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"    def delete(self, context, network_uuid):"},{"line_number":2455,"context_line":"        \"\"\"Delete a network for client.\"\"\""},{"line_number":2456,"context_line":"        raise NotImplementedError()"},{"line_number":2457,"context_line":""},{"line_number":2458,"context_line":"    def disassociate(self, context, network_uuid):"},{"line_number":2459,"context_line":"        \"\"\"Disassociate a network for client.\"\"\""},{"line_number":2460,"context_line":"        raise NotImplementedError()"},{"line_number":2461,"context_line":""},{"line_number":2462,"context_line":"    def associate(self, context, network_uuid, host\u003dbase_api.SENTINEL,"},{"line_number":2463,"context_line":"                  project\u003dbase_api.SENTINEL):"},{"line_number":2464,"context_line":"        \"\"\"Associate a network for client.\"\"\""},{"line_number":2465,"context_line":"        raise NotImplementedError()"},{"line_number":2466,"context_line":""},{"line_number":2467,"context_line":"    def get_fixed_ip(self, context, id):"},{"line_number":2468,"context_line":"        \"\"\"Get a fixed IP from the id.\"\"\""},{"line_number":2469,"context_line":"        raise NotImplementedError()"},{"line_number":2470,"context_line":""},{"line_number":2471,"context_line":"    def get_fixed_ip_by_address(self, context, address):"},{"line_number":2472,"context_line":"        \"\"\"Return instance uuids given an address.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_7de3c6d9","line":2469,"range":{"start_line":2450,"start_character":0,"end_line":2469,"end_character":35},"in_reply_to":"3fa7e38b_ff21439f","updated":"2019-11-07 03:22:05.000000000","message":"They don\u0027t. I think I just added the one because it made grepping easier as I reworked stuff later in the series. We\u0027ll remove base_api at some point too so this will have to be done then. I can remove but I\u0027m tempted to wait until patches higher up the stack have had some eyes on them first","commit_id":"4c59086949e2bda272c8aa170373e037cb1e1fb2"}],"nova/tests/functional/api_sample_tests/test_networks_associate.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bcb33122b2465d44f8010ab850b1fd66241c9846","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# TODO(stephenfin): Remove this API since it\u0027s nova-network only"},{"line_number":20,"context_line":"class NetworksAssociateJsonTests(api_sample_base.ApiSampleTestBaseV21):"},{"line_number":21,"context_line":"    USE_NEUTRON \u003d False  # nova-net only"},{"line_number":22,"context_line":"    ADMIN_API \u003d True"},{"line_number":23,"context_line":"    sample_dir \u003d \"os-networks-associate\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3fa7e38b_856480b4","line":21,"updated":"2019-11-21 09:40:23.000000000","message":"this comment is not really needed since the above TODO but meh.","commit_id":"1dac0542eac1b4ef9f21798fc5bd0ae9b89ed493"}],"nova/tests/functional/api_sample_tests/test_security_group_default_rules.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bcb33122b2465d44f8010ab850b1fd66241c9846","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# TODO(stephenfin): Remove this API since it\u0027s nova-network only"},{"line_number":19,"context_line":"class SecurityGroupDefaultRulesSampleJsonTest("},{"line_number":20,"context_line":"        api_sample_base.ApiSampleTestBaseV21):"},{"line_number":21,"context_line":"    USE_NEUTRON \u003d False  # nova-net only"},{"line_number":22,"context_line":"    ADMIN_API \u003d True"},{"line_number":23,"context_line":"    sample_dir \u003d \u0027os-security-group-default-rules\u0027"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3fa7e38b_e50a14cf","line":21,"updated":"2019-11-21 09:40:23.000000000","message":"ditto","commit_id":"1dac0542eac1b4ef9f21798fc5bd0ae9b89ed493"}]}