)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"698effb03b88f3a18a5da55e03f0616256ca4534","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2019-09-24 16:59:18 +0100"},{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003cstephenfin@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-02 16:07:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use compression by default for \u0027SshDriver\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Given we use these to copy images about the place, this should be some"},{"line_number":10,"context_line":"bit faster for uncompressed images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_372b6beb","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":42},"updated":"2020-06-02 16:23:01.000000000","message":"nit well its not just a case of usign it by default.\nyou are added compression support as previously the paramater was ignored and you would have to enable compression using your .ssh client config by adding something like this\n\nHost *\n  ForwardX11 yes\n  ForwardAgent yes\n  Protocol 2\n  Compression yes\n  TCPKeepAlive yes","commit_id":"550e3885e72e4456b19f1931c6f7c6255c37c709"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d25c4a766c586d0eae686d126d861e2575977d3d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2019-09-24 16:59:18 +0100"},{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003cstephenfin@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-02 16:07:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use compression by default for \u0027SshDriver\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Given we use these to copy images about the place, this should be some"},{"line_number":10,"context_line":"bit faster for uncompressed images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_07cadd44","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":42},"in_reply_to":"bf51134e_c7858509","updated":"2020-07-22 10:37:50.000000000","message":"Well, it\u0027s dependent on the host, so I prefer to just ask for compression directly with scp.","commit_id":"550e3885e72e4456b19f1931c6f7c6255c37c709"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0be23b2833aa200f4298ebca651fadf0f1d96ee5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2019-09-24 16:59:18 +0100"},{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003cstephenfin@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-02 16:07:33 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use compression by default for \u0027SshDriver\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Given we use these to copy images about the place, this should be some"},{"line_number":10,"context_line":"bit faster for uncompressed images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_c7858509","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":42},"in_reply_to":"ff570b3c_372b6beb","updated":"2020-07-22 10:33:28.000000000","message":"That\u0027s a good point. Will reword this if I respin","commit_id":"550e3885e72e4456b19f1931c6f7c6255c37c709"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"698effb03b88f3a18a5da55e03f0616256ca4534","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use compression by default for \u0027SshDriver\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Given we use these to copy images about the place, this should be some"},{"line_number":10,"context_line":"bit faster for uncompressed images."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2860db55ff580282cd6905f5310f01fca17e132d"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_3706cb87","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":35},"updated":"2020-06-02 16:23:01.000000000","message":"the trade off is more memory and cpu overhead\nbut on balance i think this likely makes sense.","commit_id":"550e3885e72e4456b19f1931c6f7c6255c37c709"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0be23b2833aa200f4298ebca651fadf0f1d96ee5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use compression by default for \u0027SshDriver\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Given we use these to copy images about the place, this should be some"},{"line_number":10,"context_line":"bit faster for uncompressed images."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2860db55ff580282cd6905f5310f01fca17e132d"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_277c411f","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":35},"in_reply_to":"ff570b3c_3706cb87","updated":"2020-07-22 10:33:28.000000000","message":"Will also add this","commit_id":"550e3885e72e4456b19f1931c6f7c6255c37c709"}],"nova/virt/libvirt/volume/remotefs.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d25c4a766c586d0eae686d126d861e2575977d3d","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        utils.ssh_execute(host, \u0027rm\u0027, \u0027-rf\u0027, dst,"},{"line_number":190,"context_line":"                          on_execute\u003don_execute, on_completion\u003don_completion)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def copy_file(self, src, dst, on_execute, on_completion, compression):"},{"line_number":193,"context_line":"        # As far as ploop disks are in fact directories we add \u0027-r\u0027 argument"},{"line_number":194,"context_line":"        args \u003d [\u0027scp\u0027, \u0027-r\u0027, src, dst]"},{"line_number":195,"context_line":"        if compression:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_67c47941","line":192,"range":{"start_line":192,"start_character":61,"end_line":192,"end_character":72},"updated":"2020-07-22 10:37:50.000000000","message":"fun that we haven\u0027t used this argument yet.","commit_id":"550e3885e72e4456b19f1931c6f7c6255c37c709"}]}
