)]}'
{"id":"openstack%2Fnova~684407","triplet_id":"openstack%2Fnova~stable%2Fstein~I188b7aa9cb220f93e69a68f0c3592b28d41ba5b6","project":"openstack/nova","branch":"stable/stein","topic":"bug/1843090","hashtags":[],"change_id":"I188b7aa9cb220f93e69a68f0c3592b28d41ba5b6","subject":"Handle legacy request spec dict in ComputeTaskManager._cold_migrate","status":"MERGED","created":"2019-09-24 17:20:25.000000000","updated":"2019-10-01 23:39:58.000000000","submitted":"2019-10-01 23:36:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"684407-1569972976366-e03b07bf","meta_rev_id":"a305bbeada35951e9387462c78da7ccd4ec44382","_number":684407,"virtual_id_number":684407,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-01 23:36:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2019-09-26 15:29:50.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"date":"2019-09-26 22:32:04.000000000","_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"date":"2019-09-26 16:44:20.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2019-09-26 17:18:55.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-09-26 19:03:23.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-09-26 15:58:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-01 18:52:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-01 18:52:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-26 15:29:50.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2019-09-26 15:58:59.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-09-26 16:44:20.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-26 17:18:55.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-09-26 19:03:23.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-26 22:32:04.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-01 18:52:24.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-10-01 23:36:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e9049ab2f2759ad9e7846aefa25b07c85c13685e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-24 17:20:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"da561907b2b5391df0cce3652b2c23582e79836f","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-09-24 18:24:35.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/07/684407/1/check/pmem-tempest-plugin-filtered/83409ea/ : TIMED_OUT in 1h 01m 32s","accounts_in_message":[],"_revision_number":1},{"id":"a9aba8aee20edde7d5fa443db8630f1f92320bc2","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-24 18:32:24.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"348cac7e0bb5b9cff404786555e968dd6a3b290e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 23:55:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d112cd3da6d9424b8ab989eaf66c892f : SUCCESS in 59m 03s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/9c7670dbf925412aa10c58fb016b7ca8 : SUCCESS in 1h 12m 42s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c48638d6dd494feaa3e72e91d148de1a : FAILURE in 12m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0bb38cf41f64449f8a0bd55323740491 : FAILURE in 16m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b8965ea761134e3a9b38aa6427ea1047 : SUCCESS in 12m 25s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1869710159ef4c2f970147f7c26a4920 : FAILURE in 11m 42s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/8f681a9c15ec473fbc6e0e9e603db4b2 : FAILURE in 14m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/860fc252c2fd406fa92f39e6f9424281 : FAILURE in 10m 27s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/abeeab8963004856b13908e3c3c49f99 : FAILURE in 13m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4517515cf9b742e780bb9e98b90cd13e : SUCCESS in 7m 16s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/9cd5454de6914bba8462f00ebca67b8a : SUCCESS in 51m 34s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/92beeaaee7f04b6787efe793bd701269 : SUCCESS in 1h 11m 27s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/c575848992244477ba4cf53687d3d5bb : SUCCESS in 1h 15m 37s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/958e3e627dcb481fbfccb85a11ec6422 : SUCCESS in 1h 13m 36s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f34fcd781b3f48098cbcb985d3ce123c : SUCCESS in 56m 53s\n- nova-next https://zuul.opendev.org/t/openstack/build/5c3b38add3fe4ef8809b0273596dcb0f : SUCCESS in 1h 10m 50s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b4e55d7ad0f1415dafa6749f1b7ff26d : SUCCESS in 22m 31s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/8694554eaf7443c5820e420c5a9ffbdc : SUCCESS in 23m 02s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/a9d4360455ed41078ac8d79cef2ee150 : SUCCESS in 1h 48m 32s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/8dc4edbee2b84aa892733f6f72b7a741 : SUCCESS in 2h 33m 24s","accounts_in_message":[],"_revision_number":1},{"id":"ace391d5f446357fac5ebac76fee63f2d3c66eed","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-09-25 00:18:43.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/684407/1 : SUCCESS in 2h 14m 42s","accounts_in_message":[],"_revision_number":1},{"id":"33e10a3689c2fb84d34bc6912bfe84e4f5be1123","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-09-25 02:34:00.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/1/check/tempest-dsvm-full-xenial/627f696/ : SUCCESS in 2h 20m 14s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/1/check/tempest-dsvm-full-xenial-py3/583b5f6/ : SUCCESS in 1h 57m 49s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/1/check/grenade-dsvm-xenial/64b7f31/ : SUCCESS in 1h 48m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"67f1ce4eac3f3926c7d03f72ba16fb4b55705d23","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-25 15:25:34.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"1316197141e447fac8ee5b760c32d3a17655eaa8","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-09-25 16:04:32.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/07/684407/2/check/pmem-tempest-plugin-filtered/5a94279/ : FAILURE in 37m 22s","accounts_in_message":[],"_revision_number":2},{"id":"85806c11afba0e2aefc244fbfaaeba7edd028186","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-09-25 17:16:54.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/2/check/tempest-dsvm-full-xenial/665f726/ : SUCCESS in 1h 32m 54s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/2/check/tempest-dsvm-full-xenial-py3/4d8444c/ : SUCCESS in 1h 29m 39s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/2/check/grenade-dsvm-xenial/649753a/ : FAILURE in 1h 27m 32s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7bf99afc460f4b71c95df9f2d9cd831f8ec857e2","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-09-25 18:49:47.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/684407/2 : SUCCESS in 2h 19m 44s","accounts_in_message":[],"_revision_number":2},{"id":"99dec379ea6872c212ba0bfe3374d07075a4134d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 20:10:58.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/fadf4d08cdf94b5b87b92b44dbbd6c17 : SUCCESS in 1h 10m 25s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e31ff653adeb42cbbf3ad4c4911ca17d : SUCCESS in 1h 31m 09s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8536ee1406d7414091308ebcc3bfb917 : FAILURE in 17m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c96648a7e63847a7b7fc6d3a55defa25 : FAILURE in 13m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/258e4d033b4d4a4b83719c679eba805f : SUCCESS in 9m 30s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d2b2f851f154435c8967844c5ff91cfd : FAILURE in 13m 20s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c7d4f8c951af4cf89a11be8db008a1c9 : FAILURE in 14m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8fda718df83b47aeb0d8139e035f86f8 : FAILURE in 10m 00s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/13916c3de50d46a4bd713728bf1031dd : FAILURE in 15m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c8676100fd148169b15d32c30aa2433 : SUCCESS in 8m 41s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/26507296329548c8be78b6d7c464533c : SUCCESS in 1h 05m 01s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/7d444b7dd11f4da99f6767b0f26b3ba2 : SUCCESS in 1h 14m 25s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/22cb717f82754e0e83972ee3d30f54ea : SUCCESS in 1h 21m 13s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/a74904d6805f499ea3ecdcaedf859241 : SUCCESS in 1h 22m 50s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/8d0981feab954a71b34e510cb25129b0 : SUCCESS in 51m 14s\n- nova-next https://zuul.opendev.org/t/openstack/build/94afc5a9badd4c0daf19e379da7a47f1 : SUCCESS in 1h 17m 53s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/fe99aeffb7f54f538f284d3ecfb2d418 : SUCCESS in 20m 42s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/f2515820cb80409384d6a0c88e579a91 : SUCCESS in 17m 19s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/84a872fb42e745c68b99a0b4cc687531 : SUCCESS in 1h 38m 56s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/20f4fd10befd440d97379e5753a4af9a : SUCCESS in 2h 10m 34s","accounts_in_message":[],"_revision_number":2},{"id":"76c9539fbd619fd0ca5ee8d0ebac142309db234e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-26 15:00:56.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"193a5e2c11c3dfc8a0907243341510d1e69a396a","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-09-26 15:29:50.000000000","message":"Patch Set 3:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/07/684407/3/check/pmem-tempest-plugin-filtered/96f161b/ : FAILURE in 27m 21s","accounts_in_message":[],"_revision_number":3},{"id":"98cb8cdc681716c79eec77b8874b0e0a68c6cdde","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-09-26 15:58:59.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"103614edc1cf980a8a810d9add362701036043da","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-09-26 16:44:20.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/3/check/tempest-dsvm-full-xenial/5ecd550/ : SUCCESS in 1h 24m 15s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/3/check/tempest-dsvm-full-xenial-py3/0a4b6f6/ : SUCCESS in 1h 34m 00s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/07/684407/3/check/grenade-dsvm-xenial/61da5bb/ : SUCCESS in 1h 40m 13s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"777bd80fd5ec1b79bacbdac3a62d701ac9127c3a","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-09-26 17:18:55.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/684407/3 : SUCCESS in 2h 16m 27s","accounts_in_message":[],"_revision_number":3},{"id":"7aa0b04f6011fdd1c83ac45489cc629fb68601ac","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-26 18:46:02.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/c3042bfb882041248d72e880f2c30afc : SUCCESS in 1h 14m 30s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3cd3258429a54301830962945c1c4bdc : SUCCESS in 1h 21m 24s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/719a52ae84fb43a49a421316d4ea67a7 : SUCCESS in 22m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2f316792268742869a50d7336a61845b : SUCCESS in 12m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/684be287100848a2bab19a549d1efef4 : SUCCESS in 10m 32s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/9fe958e751ea46f4b8af47b2bc6f23b1 : SUCCESS in 11m 48s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/7423ff07f3ca4804803c40b398e15e45 : SUCCESS in 15m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f50b4b0248ae4dec841ae96037412eb0 : SUCCESS in 10m 56s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6853bdd177f14f8990a864a717d209ee : SUCCESS in 12m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3bc377061f7e445db6941aab1c3377d1 : SUCCESS in 6m 31s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/49b8756c0f374ea9be531a0354aa5e16 : SUCCESS in 47m 20s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/1302270cfb714d2c89f8b5e6428af235 : SUCCESS in 1h 02m 35s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/2ad350afc3f14969b1b30fbab3c1305e : SUCCESS in 1h 05m 00s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/c0ed779ac434451c9ae39cb6a33f340e : SUCCESS in 1h 09m 21s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/754c33ff90134824a5e6d016652a99d4 : SUCCESS in 1h 00m 59s\n- nova-next https://zuul.opendev.org/t/openstack/build/789e404160d246deaa24365008545d8a : SUCCESS in 1h 13m 51s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b6a6dc80a8334728adae6df450fed650 : SUCCESS in 17m 43s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/eb3695f5ea294e88aaf3fe371e9198be : SUCCESS in 19m 22s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/7ca81d0ddddf4496a188089cb62fabd5 : SUCCESS in 1h 41m 16s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/5664c5ddbee448ac90133e6aea6d5df8 : SUCCESS in 2h 26m 30s","accounts_in_message":[],"_revision_number":3},{"id":"0fbbd17364c85c35506c5cccabe6d68850c7615f","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-09-26 19:03:23.000000000","message":"Patch Set 3:\n\nTesting succeeded on ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenail-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/684407/3/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/3f41232 : SUCCESS in 2h 12m 35s","accounts_in_message":[],"_revision_number":3},{"id":"3859f42d6dd1c9d5c9664cd6d0cc598ddc8b43b6","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2019-09-26 22:32:04.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- Nova-ML2-Sriov http://13.74.249.42/07/684407/3/check-nova/Nova-ML2-Sriov/ad073c6 : FAILURE in 1h 21m 10s (non-voting)\n- Nova-MACVTAP-ML2-Sriov http://13.74.249.42/07/684407/3/check-nova/Nova-MACVTAP-ML2-Sriov/0f8226e : FAILURE in 1h 36m 00s (non-voting)\n\nTo re-run the job post \u0027recheck nova-mlnx\u0027 comment. For more information visit https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI","accounts_in_message":[],"_revision_number":3},{"id":"9d7fa7bb4ae7ed3f59142a576b12b34376ce52a8","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-10-01 18:52:24.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nLGTM, conflict is explained in the commit message","accounts_in_message":[],"_revision_number":3},{"id":"71ce097a094af8335ecc2f080f78d9d1806530b6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 18:52:56.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"c0b4e74bf1691be65996a9b01bebd4c810621b53","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 20:41:31.000000000","message":"Patch Set 3:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"6d584e18da2f3ac45cd6f52c0b6de61624b9d654","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 23:36:15.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/fea9ec6b1cf24f308c58423dfb412d09 : SUCCESS in 1h 03m 38s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/fecb9ab2e9254610a089756f9eedf532 : SUCCESS in 1h 24m 20s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c3daa0da708943f7a5f7f55d5d7ae43a : SUCCESS in 12m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ca82a943895149fba8cab360b19ab5d7 : SUCCESS in 11m 52s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4abf1f2dba3e41b98cd7e2b7cc4d3623 : SUCCESS in 14m 38s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/2209af12e9984b869f1297d50b43fc43 : SUCCESS in 17m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/466c4378d75c48c787e8a97016921ae5 : SUCCESS in 17m 40s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d25986d179c7497f87cd0ddf434c545d : SUCCESS in 14m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a1cc96f549164c3c8b134b2dd20394b1 : SUCCESS in 9m 22s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/9431a1618aa8444a87318aed903ae612 : SUCCESS in 1h 39m 25s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/e4bc176d93ab48d2a41a5e115e2006f4 : SUCCESS in 1h 18m 31s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/ad743e0833544405a39daa2ed5ce3732 : SUCCESS in 21m 23s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/50b40197a6a84b18829bed151e8d20c4 : SUCCESS in 20m 59s\n- nova-next https://zuul.opendev.org/t/openstack/build/fddf81efe6f1431d887ef3a36ab446b8 : SUCCESS in 1h 14m 03s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/0f63d7d3b758496186d593b1a981d5db : SUCCESS in 2h 37m 38s","accounts_in_message":[],"_revision_number":3},{"id":"5b360f214c4cb5bfb852749669d5b89d52b1aee6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 23:36:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"8a70f807f8bf6cbb93a3f40a3545b79376babf4e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 23:39:58.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6fa3f85267f245eab877750f542efe47 : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"66bf82864deaabf1c3eff7237bcde6dc961dea09","revisions":{"a4eb5b627e53d171cf7cffb4d5905412506133b6":{"kind":"REWORK","_number":1,"created":"2019-09-24 17:20:25.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/07/684407/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/684407/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/684407/1"}}},"commit":{"parents":[{"commit":"fd491c7415b0bbe4d7bfd0796548360c5d084d70","subject":"Func test for migrate reschedule with pinned compute rpc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fd491c7415b0bbe4d7bfd0796548360c5d084d70"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-09-06 19:13:00.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-09-24 17:19:23.000000000","tz":-240},"subject":"Handle legacy request spec dict in ComputeTaskManager._cold_migrate","message":"Handle legacy request spec dict in ComputeTaskManager._cold_migrate\n\nPrior to change I4244f7dd8fe74565180f73684678027067b4506e in Stein,\nconductor would pass a legacy dict request spec to compute during\ncold migrate / resize and if compute rescheduled it would not pass\nthe request spec back to conductor, so the _cold_migrate method in\nconductor would have to create a new RequestSpec from components\nit had available.\n\nAs of that change, compute will send the request spec it got back\nto conductor and _cold_migrate avoids the RequestSpec.from_components\ncall.\n\nThere are two issues here:\n\n1. Technically if conductor RPC API is pinned to less than 1.13 the\n   ComputeTaskAPI.migrate_server method will remove the request spec\n   from the call to conductor. So conductor (server-side) can still\n   not get a RequestSpec and need to use from_components. As a result\n   the TODO in the _cold_migrate method needs to be updated since we\n   require an RPC API major version bump to make request spec required.\n\n2. Just because conductor is passing compute a RequestSpec object, if\n   compute RPC API versions are pinned to less than 5.1, conductor will\n   pass a legacy request spec dict to compute and compute will send that\n   back to conductor, so the _cold_migrate method needs to handle getting\n   a request spec that is a dict and convert it to an object. A new test\n   is added for that case.\n\nChange-Id: I188b7aa9cb220f93e69a68f0c3592b28d41ba5b6\nCloses-Bug: #1843090\n(cherry picked from commit 95331cea1fb53e0c289957be2d702435836812aa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a4eb5b627e53d171cf7cffb4d5905412506133b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a4eb5b627e53d171cf7cffb4d5905412506133b6"}]},"branch":"refs/heads/stable/stein"},"ed079455433d7246e3cf24a0a56316062e1ce591":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-09-25 15:25:34.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/07/684407/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/684407/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/684407/2"}}},"commit":{"parents":[{"commit":"fd491c7415b0bbe4d7bfd0796548360c5d084d70","subject":"Func test for migrate reschedule with pinned compute rpc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fd491c7415b0bbe4d7bfd0796548360c5d084d70"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-09-06 19:13:00.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-09-25 15:24:20.000000000","tz":-240},"subject":"Handle legacy request spec dict in ComputeTaskManager._cold_migrate","message":"Handle legacy request spec dict in ComputeTaskManager._cold_migrate\n\nPrior to change I4244f7dd8fe74565180f73684678027067b4506e in Stein,\nconductor would pass a legacy dict request spec to compute during\ncold migrate / resize and if compute rescheduled it would not pass\nthe request spec back to conductor, so the _cold_migrate method in\nconductor would have to create a new RequestSpec from components\nit had available.\n\nAs of that change, compute will send the request spec it got back\nto conductor and _cold_migrate avoids the RequestSpec.from_components\ncall.\n\nThere are two issues here:\n\n1. Technically if conductor RPC API is pinned to less than 1.13 the\n   ComputeTaskAPI.migrate_server method will remove the request spec\n   from the call to conductor. So conductor (server-side) can still\n   not get a RequestSpec and need to use from_components. As a result\n   the TODO in the _cold_migrate method needs to be updated since we\n   require an RPC API major version bump to make request spec required.\n\n2. Just because conductor is passing compute a RequestSpec object, if\n   compute RPC API versions are pinned to less than 5.1, conductor will\n   pass a legacy request spec dict to compute and compute will send that\n   back to conductor, so the _cold_migrate method needs to handle getting\n   a request spec that is a dict and convert it to an object. A new test\n   is added for that case.\n\nConflicts:\n      nova/compute/rpcapi.py\n\nNOTE(mriedem): The conflict is due to not having change\nIb4e0b9ab050a59ab5a290e6eecea01b87c3bd4c6 in Stein.\n\nChange-Id: I188b7aa9cb220f93e69a68f0c3592b28d41ba5b6\nCloses-Bug: #1843090\n(cherry picked from commit b36c44c449533edfbcfd970ccef9d794ac3b4171)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ed079455433d7246e3cf24a0a56316062e1ce591"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ed079455433d7246e3cf24a0a56316062e1ce591"}]},"branch":"refs/heads/stable/stein"},"66bf82864deaabf1c3eff7237bcde6dc961dea09":{"kind":"REWORK","_number":3,"created":"2019-09-26 15:00:56.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/07/684407/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/684407/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/684407/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/684407/3"}}},"commit":{"parents":[{"commit":"fd491c7415b0bbe4d7bfd0796548360c5d084d70","subject":"Func test for migrate reschedule with pinned compute rpc","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fd491c7415b0bbe4d7bfd0796548360c5d084d70"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-09-06 19:13:00.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-09-26 15:00:11.000000000","tz":-240},"subject":"Handle legacy request spec dict in ComputeTaskManager._cold_migrate","message":"Handle legacy request spec dict in ComputeTaskManager._cold_migrate\n\nPrior to change I4244f7dd8fe74565180f73684678027067b4506e in Stein,\nconductor would pass a legacy dict request spec to compute during\ncold migrate / resize and if compute rescheduled it would not pass\nthe request spec back to conductor, so the _cold_migrate method in\nconductor would have to create a new RequestSpec from components\nit had available.\n\nAs of that change, compute will send the request spec it got back\nto conductor and _cold_migrate avoids the RequestSpec.from_components\ncall.\n\nThere are two issues here:\n\n1. Technically if conductor RPC API is pinned to less than 1.13 the\n   ComputeTaskAPI.migrate_server method will remove the request spec\n   from the call to conductor. So conductor (server-side) can still\n   not get a RequestSpec and need to use from_components. As a result\n   the TODO in the _cold_migrate method needs to be updated since we\n   require an RPC API major version bump to make request spec required.\n\n2. Just because conductor is passing compute a RequestSpec object, if\n   compute RPC API versions are pinned to less than 5.1, conductor will\n   pass a legacy request spec dict to compute and compute will send that\n   back to conductor, so the _cold_migrate method needs to handle getting\n   a request spec that is a dict and convert it to an object. A new test\n   is added for that case.\n\nConflicts:\n      nova/compute/rpcapi.py\n\nNOTE(mriedem): The conflict is due to not having change\nIb4e0b9ab050a59ab5a290e6eecea01b87c3bd4c6 in Stein.\n\nNOTE(mriedem): The unit test in test_conductor.py had to be changed\nslightly since change If1e461da382f707be2b5ba89f74f77269f0909dd is\nnot in Stein.\n\nChange-Id: I188b7aa9cb220f93e69a68f0c3592b28d41ba5b6\nCloses-Bug: #1843090\n(cherry picked from commit b36c44c449533edfbcfd970ccef9d794ac3b4171)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/66bf82864deaabf1c3eff7237bcde6dc961dea09"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/66bf82864deaabf1c3eff7237bcde6dc961dea09"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}