)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76a1f7d3462599319415c3c0adcdcd1dce1f67d4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Functional reproduction for bug 1845291"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova does not try to re-schedule a migration if the original boot was"},{"line_number":10,"context_line":"done with --availability-zone \u003caz:host\u003e."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug #1845291"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_b2cd5c32","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":39},"updated":"2019-09-25 13:28:35.000000000","message":"or \u003caz::node\u003e...","commit_id":"fa6704245d4d5237b35f54232a6802322fae3ac4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"831c9fb2f3dc37ac1e6925d9859433e4a3453eb5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Functional reproduction for bug 1845291"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova does not try to re-schedule a migration if the original boot was"},{"line_number":10,"context_line":"done with --availability-zone \u003caz:host\u003e."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug #1845291"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_31c71999","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":39},"in_reply_to":"3fa7e38b_b2cd5c32","updated":"2019-09-26 08:17:16.000000000","message":"Done","commit_id":"fa6704245d4d5237b35f54232a6802322fae3ac4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0db0d6e7ced5dff48bf246eaa79f8af3c5bce92","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Functional reproduction for bug 1845291"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova does not try to re-schedule a migration if the original boot was"},{"line_number":10,"context_line":"done with --availability-zone \u003caz:host\u003e."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug #1845291"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_6da7090d","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":39},"in_reply_to":"3fa7e38b_b2cd5c32","updated":"2019-09-25 13:30:56.000000000","message":"You don\u0027t have to change this or add a second test for that case, I was just pointing it out.","commit_id":"fa6704245d4d5237b35f54232a6802322fae3ac4"}],"nova/tests/functional/regressions/test_bug_1845291.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4379b1f8e9e3cb1e141073b2a444d8cf09b98bf5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        flavors \u003d self.api.get_flavors()"},{"line_number":31,"context_line":"        self.flavor1 \u003d flavors[0]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_boot_with_az_and_host_the_migrate_re_schedules(self):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # NOTE(gibi): this will use az:hostname to boot the server"},{"line_number":36,"context_line":"        server \u003d self._boot_and_check_allocations("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a2109258","line":33,"range":{"start_line":33,"start_character":35,"end_line":33,"end_character":38},"updated":"2019-09-26 15:45:39.000000000","message":"then?","commit_id":"2761a6dbd7f07a408d9512722b33a72d64f9c2ba"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2cbe4d9bb89b8c6934c98e039202266aca700437","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        flavors \u003d self.api.get_flavors()"},{"line_number":31,"context_line":"        self.flavor1 \u003d flavors[0]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_boot_with_az_and_host_the_migrate_re_schedules(self):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # NOTE(gibi): this will use az:hostname to boot the server"},{"line_number":36,"context_line":"        server \u003d self._boot_and_check_allocations("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6562a4da","line":33,"range":{"start_line":33,"start_character":35,"end_line":33,"end_character":38},"in_reply_to":"3fa7e38b_a2109258","updated":"2019-09-26 15:54:51.000000000","message":"Done","commit_id":"2761a6dbd7f07a408d9512722b33a72d64f9c2ba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4379b1f8e9e3cb1e141073b2a444d8cf09b98bf5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            self.flavor1, \u0027host1\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        orig_claim \u003d nova.compute.resource_tracker.ResourceTracker.resize_claim"},{"line_number":40,"context_line":"        claim_calls \u003d []"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def fake_orig_claim("},{"line_number":43,"context_line":"                _self, context, instance, instance_type, nodename,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a53e5cbe","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":24},"updated":"2019-09-26 15:45:39.000000000","message":"mmph, there should be a way you don\u0027t need this (just use your mock\u0027s .call_count), but I guess you would have to rescope everything :(","commit_id":"2761a6dbd7f07a408d9512722b33a72d64f9c2ba"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8958985cf97a4e036ea65ef24b25f6e396bab1c5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            self.flavor1, \u0027host1\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        orig_claim \u003d nova.compute.resource_tracker.ResourceTracker.resize_claim"},{"line_number":40,"context_line":"        claim_calls \u003d []"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def fake_orig_claim("},{"line_number":43,"context_line":"                _self, context, instance, instance_type, nodename,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e5977439","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":24},"in_reply_to":"3fa7e38b_65906496","updated":"2019-09-26 16:00:55.000000000","message":"I did that recently and it was a big stink:\n\nhttps://review.opendev.org/#/c/682140/1/nova/tests/functional/test_servers.py@6817","commit_id":"2761a6dbd7f07a408d9512722b33a72d64f9c2ba"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2cbe4d9bb89b8c6934c98e039202266aca700437","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            self.flavor1, \u0027host1\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        orig_claim \u003d nova.compute.resource_tracker.ResourceTracker.resize_claim"},{"line_number":40,"context_line":"        claim_calls \u003d []"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def fake_orig_claim("},{"line_number":43,"context_line":"                _self, context, instance, instance_type, nodename,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_65906496","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":24},"in_reply_to":"3fa7e38b_a53e5cbe","updated":"2019-09-26 15:54:51.000000000","message":"for that I would need to access to the mock at L45.\nIt might be doable but ugly.","commit_id":"2761a6dbd7f07a408d9512722b33a72d64f9c2ba"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76a1f7d3462599319415c3c0adcdcd1dce1f67d4","unresolved":false,"context_lines":[{"line_number":3349,"context_line":""},{"line_number":3350,"context_line":"        self._delete_and_check_allocations(server)"},{"line_number":3351,"context_line":""},{"line_number":3352,"context_line":"    def test_boot_with_az_and_host_the_migrate_re_schedules(self):"},{"line_number":3353,"context_line":"        self._start_compute(host\u003d\"host3\")"},{"line_number":3354,"context_line":""},{"line_number":3355,"context_line":"        # NOTE(gibi): this will use az:hostname to boot the server"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_12055046","line":3352,"updated":"2019-09-25 13:28:35.000000000","message":"By putting this in ServerMovingTests it gets duplicated and ran in ServerMovingTestsWithNestedComputes and ServerMovingTestsWithNestedResourceRequests, do we need to run this in those other setups? It\u0027s not a real long test but it\u0027s at least 4 seconds, so ~16 seconds total which isn\u0027t nothing. I\u0027m also not sure if we would consider this a regression since it goes back to Newton and I\u0027m not sure what the behavior was before that, but I think we could probably say this is a regression and put it under the nova/tests/functional/regressions/ directory rather than the generic ServerMovingTests class.\n\nMaking an isolated standalone test for this in /regressions also makes backports easier on the older branches in case there are things not found in ServerMovingTests (and conflicts for that matter). I\u0027m guessing we\u0027re going to backport this to at least Queens and probably Pike in the Ericsson case.","commit_id":"fa6704245d4d5237b35f54232a6802322fae3ac4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"831c9fb2f3dc37ac1e6925d9859433e4a3453eb5","unresolved":false,"context_lines":[{"line_number":3349,"context_line":""},{"line_number":3350,"context_line":"        self._delete_and_check_allocations(server)"},{"line_number":3351,"context_line":""},{"line_number":3352,"context_line":"    def test_boot_with_az_and_host_the_migrate_re_schedules(self):"},{"line_number":3353,"context_line":"        self._start_compute(host\u003d\"host3\")"},{"line_number":3354,"context_line":""},{"line_number":3355,"context_line":"        # NOTE(gibi): this will use az:hostname to boot the server"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_51c41591","line":3352,"in_reply_to":"3fa7e38b_12055046","updated":"2019-09-26 08:17:16.000000000","message":"Good point. Moved under regressions","commit_id":"fa6704245d4d5237b35f54232a6802322fae3ac4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76a1f7d3462599319415c3c0adcdcd1dce1f67d4","unresolved":false,"context_lines":[{"line_number":3359,"context_line":"        orig_claim \u003d nova.compute.resource_tracker.ResourceTracker.resize_claim"},{"line_number":3360,"context_line":"        claim_calls \u003d []"},{"line_number":3361,"context_line":""},{"line_number":3362,"context_line":"        def fake_orig_claim("},{"line_number":3363,"context_line":"                _self, context, instance, instance_type, nodename,"},{"line_number":3364,"context_line":"                *args, **kwargs):"},{"line_number":3365,"context_line":"            if not claim_calls:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1261d005","line":3362,"updated":"2019-09-25 13:28:35.000000000","message":"At some point we should really probably just make a fixture for this since it\u0027s copied/pasted in a lot of places. I\u0027m not saying you have to do that here, just something for a random todo list.","commit_id":"fa6704245d4d5237b35f54232a6802322fae3ac4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"831c9fb2f3dc37ac1e6925d9859433e4a3453eb5","unresolved":false,"context_lines":[{"line_number":3359,"context_line":"        orig_claim \u003d nova.compute.resource_tracker.ResourceTracker.resize_claim"},{"line_number":3360,"context_line":"        claim_calls \u003d []"},{"line_number":3361,"context_line":""},{"line_number":3362,"context_line":"        def fake_orig_claim("},{"line_number":3363,"context_line":"                _self, context, instance, instance_type, nodename,"},{"line_number":3364,"context_line":"                *args, **kwargs):"},{"line_number":3365,"context_line":"            if not claim_calls:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1f546920","line":3362,"in_reply_to":"3fa7e38b_1261d005","updated":"2019-09-26 08:17:16.000000000","message":"Random TODO added to my list","commit_id":"fa6704245d4d5237b35f54232a6802322fae3ac4"}]}
