)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7376d34efa4b983609eaf27eb5679278c978e088","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reset forced_destination before migration at a proper time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resetting was in place but it was done after the retry filter is"},{"line_number":10,"context_line":"populated in the MigrationTask. This patch moves the reset code upper."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8290e890a36cf5a8f409ab8a50e7c72f7ae15025"},{"line_number":13,"context_line":"Closed-Bug: #1845291"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_323acccb","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":31},"updated":"2019-09-25 12:51:27.000000000","message":"I would note something about the populate_retry method specifically.","commit_id":"228ea972d43eac0e9149147c1167c925ad195c99"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7376d34efa4b983609eaf27eb5679278c978e088","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reset forced_destination before migration at a proper time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resetting was in place but it was done after the retry filter is"},{"line_number":10,"context_line":"populated in the MigrationTask. This patch moves the reset code upper."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8290e890a36cf5a8f409ab8a50e7c72f7ae15025"},{"line_number":13,"context_line":"Closed-Bug: #1845291"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f2443449","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":69},"updated":"2019-09-25 12:51:27.000000000","message":"before the call to populate_retry so as to allow retries.","commit_id":"228ea972d43eac0e9149147c1167c925ad195c99"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98b9d945d98850b237fac80426eb8d19531cfe52","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reset forced_destination before migration at a proper time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resetting was in place but it was done after the retry filter is"},{"line_number":10,"context_line":"populated in the MigrationTask. This patch moves the reset code upper."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8290e890a36cf5a8f409ab8a50e7c72f7ae15025"},{"line_number":13,"context_line":"Closed-Bug: #1845291"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f2d434eb","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":31},"in_reply_to":"3fa7e38b_323acccb","updated":"2019-09-25 13:13:50.000000000","message":"Done","commit_id":"228ea972d43eac0e9149147c1167c925ad195c99"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98b9d945d98850b237fac80426eb8d19531cfe52","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reset forced_destination before migration at a proper time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resetting was in place but it was done after the retry filter is"},{"line_number":10,"context_line":"populated in the MigrationTask. This patch moves the reset code upper."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8290e890a36cf5a8f409ab8a50e7c72f7ae15025"},{"line_number":13,"context_line":"Closed-Bug: #1845291"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_92070083","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":69},"in_reply_to":"3fa7e38b_f2443449","updated":"2019-09-25 13:13:50.000000000","message":"Done","commit_id":"228ea972d43eac0e9149147c1167c925ad195c99"}],"nova/conductor/tasks/migrate.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7376d34efa4b983609eaf27eb5679278c978e088","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        raise exception.MaxRetriesExceeded(reason\u003dreason)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _execute(self):"},{"line_number":284,"context_line":"        # NOTE(sbauza): Force_hosts/nodes needs to be reset"},{"line_number":285,"context_line":"        # if we want to make sure that the next destination"},{"line_number":286,"context_line":"        # is not forced to be the original host"},{"line_number":287,"context_line":"        self.request_spec.reset_forced_destinations()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_92006003","line":284,"updated":"2019-09-25 12:51:27.000000000","message":"I would expand on this comment saying that we need to do this before populate_retry otherwise retries will be disabled if the server was created with a forced host/node.","commit_id":"228ea972d43eac0e9149147c1167c925ad195c99"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98b9d945d98850b237fac80426eb8d19531cfe52","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        raise exception.MaxRetriesExceeded(reason\u003dreason)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _execute(self):"},{"line_number":284,"context_line":"        # NOTE(sbauza): Force_hosts/nodes needs to be reset"},{"line_number":285,"context_line":"        # if we want to make sure that the next destination"},{"line_number":286,"context_line":"        # is not forced to be the original host"},{"line_number":287,"context_line":"        self.request_spec.reset_forced_destinations()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_92de200f","line":284,"in_reply_to":"3fa7e38b_92006003","updated":"2019-09-25 13:13:50.000000000","message":"Done","commit_id":"228ea972d43eac0e9149147c1167c925ad195c99"}]}