)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33f820bc120388ea7bcaaef3ec6fd701230b425c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"tests: Nuke OS_STDOUT_CAPTURE, OS_STDERR_CAPTURE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Terminology courtesy of sdague. Turns out we can\u0027t actually use these"},{"line_number":10,"context_line":"since we rely on capturing stdout and stderr in tests. Stop pretending"},{"line_number":11,"context_line":"this is disable\u0027able."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70a93bf564379d550fddaee568de4464e795a11d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_35ce33b4","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":54},"updated":"2019-09-25 15:14:27.000000000","message":"You mean for the various self.stdlog.logger.output usage and also probably nova-manage CLI tests that trap output and assert what\u0027s in it, yeah? Actually the former is StandardLogging which is a different fixture.","commit_id":"724ecb86b358f386c04772efb58eb1eeb06f14e5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"52bd43640e93d044ef82e7958a28567213ed7e78","unresolved":false,"context_lines":[{"line_number":7,"context_line":"tests: Nuke OS_STDOUT_CAPTURE, OS_STDERR_CAPTURE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Terminology courtesy of sdague. Turns out we can\u0027t actually use these"},{"line_number":10,"context_line":"since we rely on capturing stdout and stderr in tests. Stop pretending"},{"line_number":11,"context_line":"this is disable\u0027able."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I70a93bf564379d550fddaee568de4464e795a11d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_15da174a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":54},"in_reply_to":"3fa7e38b_35ce33b4","updated":"2019-09-25 15:17:19.000000000","message":"Actually, I meant \u0027self.stdout\u0027 and looking at it now, it seems we just override that wherever we need it. We still shouldn\u0027t be doing this since it does nothing but I\u0027ll shove it to the end of the series and rework to remove the extra setting of the fixtures","commit_id":"724ecb86b358f386c04772efb58eb1eeb06f14e5"}],"tox.ini":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9e5de0cbd5d9b18375fd80b12a3a6f818dcfb1e8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  VIRTUAL_ENV\u003d{envdir}"},{"line_number":20,"context_line":"  LANGUAGE\u003den_US"},{"line_number":21,"context_line":"  LC_ALL\u003den_US.utf-8"},{"line_number":22,"context_line":"  OS_STDOUT_CAPTURE\u003d1"},{"line_number":23,"context_line":"  OS_STDERR_CAPTURE\u003d1"},{"line_number":24,"context_line":"  OS_TEST_TIMEOUT\u003d160"},{"line_number":25,"context_line":"  PYTHONDONTWRITEBYTECODE\u003d1"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_15098994","side":"PARENT","line":22,"updated":"2019-09-27 14:29:01.000000000","message":"It wasn\u0027t out of the realm of possibility that these were being picked up by something we were inheriting from.\n\nLike oslotest.base.BaseTestCase, which uses them for the same purpose and in the same way as nova (before this patch).\n\nWhich leads me to wonder whether we should cut our nova.test.TestCase over to inherit from that guy instead of directly from testtools.TestCase. Why aren\u0027t we doing that?","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"}]}