)]}'
{"tox.ini":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9a7570ce61d824a561720e2028ee5fe616b6ef93","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# TODO(stephenfin): Remove psycopg2 when minimum constraints is bumped to 2.8"},{"line_number":25,"context_line":"  PYTHONWARNINGS \u003d ignore::UserWarning:psycopg2"},{"line_number":26,"context_line":"deps \u003d"},{"line_number":27,"context_line":"  -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":28,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":29,"context_line":"passenv \u003d"},{"line_number":30,"context_line":"  OS_DEBUG GENERATE_HASHES"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_f57bbb24","line":27,"updated":"2019-09-25 15:22:15.000000000","message":"I don\u0027t love the duplication. Is there a way to use {[testenv]deps} as a partial throughout?","commit_id":"266c7a2708af2e9a141a3940544cf78cc44828b9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"df780ff2d7a04b7a3ee215e2895cdf5ecdb3ab6d","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_03c2b659","line":154,"updated":"2019-09-27 13:43:45.000000000","message":"This delta loses requirements.txt. Is that okay? What\u0027s venv used for anyway? Just running manual tools like reno etc? Anyway, probably better to leave it in for now.","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae8c2ff1dda97bbc86f357737e6d1b2ea0b03887","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_83cea657","line":154,"in_reply_to":"3fa7e38b_03c2b659","updated":"2019-09-27 13:49:25.000000000","message":"\u003e This delta loses requirements.txt. Is that okay?\n\nrequirements.txt might get applied by default, I\u0027m not sure though.\n\n \u003e What\u0027s venv used\n \u003e for anyway? Just running manual tools like reno etc? Anyway,\n \u003e probably better to leave it in for now.\n\nYes, and I use it for things like testing nova-manage command help, e.g. tox -e venv -- nova-manage cell_v2 heal_instance_mappings -?","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c40827cebeca0e4417c514327d7e8aa4df62ab59","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_98dff067","line":154,"in_reply_to":"3fa7e38b_15cae919","updated":"2019-09-27 14:59:43.000000000","message":"mriedem is right, you don\u0027t need it because we\u0027re installing nova inside the virtualenv which brings in all the requirements listed inside requirements.txt (because that\u0027s what pbr uses). Note that we also don\u0027t have \u0027requirements.txt\u0027 listed in the top-level \u0027testenv\u0027","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9df48a00f03c0a4835c211d3acc4b91d4ada861d","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_15cae919","line":154,"in_reply_to":"3fa7e38b_83cea657","updated":"2019-09-27 14:36:24.000000000","message":"\u003e requirements.txt might get applied by default, I\u0027m not sure though.\n\nUnless by default for venv as a hardcoded special case, I\u0027m 99% sure not. That\u0027s the point of having test-requirements.txt, so most of our envs can run *without* all the additional stuff required in a prod env.\n\n \u003e Yes, and I use it for things like testing nova-manage command help,\n \u003e e.g. tox -e venv -- nova-manage cell_v2 heal_instance_mappings -?\n\nAck, thanks for the confirmation.","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ca4f686cdd2fcc0239467fb1951e274185c0a63f","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_d8332861","line":154,"in_reply_to":"3fa7e38b_98dff067","updated":"2019-09-27 15:24:45.000000000","message":"\u003e mriedem is right, you don\u0027t need it because we\u0027re installing nova\n \u003e inside the virtualenv\n\nIs that happening automatically because it\u0027s called venv? I can\u0027t see anything in this env\u0027s definition.\n\n[Later] hum, no, the develop-inst thing seems to be happening regardless. Why? And thus, what\u0027s the point of having separate requirements and test-requirements??\n\n[Later later] Oh, does this come from `usedevelop \u003d True` in [testenv]? So... requiring requirements.txt is redundant everywhere (except where we\u0027re saying `usedevelop \u003d False` explicitly).\n\n[Later later later] Egads, with `usedevelop \u003d False` tox actually pulls down a release zip of nova and installs *that*.\n\nSo here I thought all my venvs were smallish, only getting test-requirements, but they\u0027re getting the world. That makes me sad.","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7dd38aaed39abdee6f995f37bca5f864bf1aca7a","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_d83fa884","line":154,"in_reply_to":"3fa7e38b_98dff067","updated":"2019-09-27 15:01:45.000000000","message":"You can test this yourself.\n\n  tox -e venv\n  source .tox/venv/bin/activate\n  pip freeze","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"59ffc22dc19ba89b8b82975fa4e4369a236af1ee","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_e9cdf8b6","line":154,"in_reply_to":"3fa7e38b_ae6706e9","updated":"2019-09-27 17:06:17.000000000","message":"It doesn\u0027t appear to work per env.\n\nI played with trying to get functional-py36 to run with just test-requirements and got failures on a bunch of expected packages.\n\nSo clearly I was misunderstanding what test-requirements was supposed to be good for. I\u0027m now thinking it\u0027s perhaps just for things we need in test that we *don\u0027t* need in the real world??","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de4ed436a6322ad5d8c3ebea722f4cc5f94b8c89","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_ae6706e9","line":154,"in_reply_to":"3fa7e38b_d8332861","updated":"2019-09-27 16:16:39.000000000","message":"skipsdist is what you want to avoid doing that. Probably worth doing for pep8, tbh, but I don\u0027t know if it can be done on a per-venv basis. In any case, when that\u0027s set we wouldn\u0027t install the package so the only thing that would get installed is the deps you\u0027ve listed","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"29c2d3a3bb977b8958d393482aec386047c4464b","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"[testenv:venv]"},{"line_number":153,"context_line":"deps \u003d"},{"line_number":154,"context_line":"  {[testenv]deps}"},{"line_number":155,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":156,"context_line":"commands \u003d"},{"line_number":157,"context_line":"  {posargs}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3fa7e38b_6967c8b8","line":154,"in_reply_to":"3fa7e38b_e9cdf8b6","updated":"2019-09-27 17:09:08.000000000","message":"\u003e So clearly I was misunderstanding what test-requirements was\n \u003e supposed to be good for. I\u0027m now thinking it\u0027s perhaps just for\n \u003e things we need in test that we *don\u0027t* need in the real world??\n\nThis seems to be borne out by the fact that the two files are completely disjoint.","commit_id":"19a0bdfec454bd921b718e7dc49fe2673fa79b10"}]}