)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"b16ecbb79f85c85c2cc5449ed5afe791beaf2069","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Log request IDs between nova and glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Log the mapping of request IDs between nova and glance. Setting"},{"line_number":10,"context_line":"send_req_id will cause glanceclient\u0027s various operations to return"},{"line_number":11,"context_line":"the request id via a new optional parmeter: return_req_id. The"},{"line_number":12,"context_line":"request ID mapping is then logged."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baada198_43f8257c","line":10,"updated":"2014-07-18 13:24:51.000000000","message":"Are we still using send_req_id in this patchset?","commit_id":"aa4eb17beb27a6374f168e9a05324671c68bb79f"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"ce2c8b3ca88c6f9da50fdaf72933bd131acac9eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Log request IDs between nova and glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Log the mapping of request IDs between nova and glance. Setting"},{"line_number":10,"context_line":"send_req_id will cause glanceclient\u0027s various operations to return"},{"line_number":11,"context_line":"the request id via a new optional parmeter: return_req_id. The"},{"line_number":12,"context_line":"request ID mapping is then logged."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baada198_98d33800","line":10,"in_reply_to":"baada198_43f8257c","updated":"2014-07-21 22:15:20.000000000","message":"Ah, I had fixed this in PS7, but updated PS8 from a different source. Fixed.","commit_id":"aa4eb17beb27a6374f168e9a05324671c68bb79f"}],"nova/image/glance.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"3189b1d1e3f9e5ae058657c54e348187a68bb7e7","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                resp \u003d getattr(client.images, method)(*args, **kwargs)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"                #NOTE(hdd) All calls except list will return req_id here"},{"line_number":217,"context_line":"                if isinstance(resp, tuple):"},{"line_number":218,"context_line":"                    req_id \u003d resp[1]"},{"line_number":219,"context_line":"                    LOG.info(\"Nova-Glance request IDs: %s -\u003e %s\","},{"line_number":220,"context_line":"                             context.request_id, req_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BAZQ%3D","line":217,"updated":"2014-01-31 02:33:06.000000000","message":"So if this merges with a requirement that the glanceclient has support for send_req_id then this isn\u0027t required as send_req_id will always be honoured even if its None??","commit_id":"c4858f1eb4abf185c3331e6c820306aa649cfd23"},{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"9c863d6df728f13257833a656efa914b8f5c760b","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                #NOTE(hdd) All calls except list will return req_id here"},{"line_number":217,"context_line":"                if isinstance(resp, tuple):"},{"line_number":218,"context_line":"                    req_id \u003d resp[1]"},{"line_number":219,"context_line":"                    LOG.info(\"Nova-Glance request IDs: %s -\u003e %s\","},{"line_number":220,"context_line":"                             context.request_id, req_id)"},{"line_number":221,"context_line":"                    return resp[0]"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99uk%3D","line":219,"updated":"2014-01-31 15:58:15.000000000","message":"I think we should put the log text/format somewhere it can be reused... There will be other places we will need to log things and that will avoid code changes in the future.","commit_id":"c4858f1eb4abf185c3331e6c820306aa649cfd23"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"8fa71866156c680669f78813a209a975aa20a366","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                #NOTE(hdd) All calls except list will return req_id here"},{"line_number":217,"context_line":"                if isinstance(resp, tuple):"},{"line_number":218,"context_line":"                    req_id \u003d resp[1]"},{"line_number":219,"context_line":"                    LOG.info(\"Nova-Glance request IDs: %s -\u003e %s\","},{"line_number":220,"context_line":"                             context.request_id, req_id)"},{"line_number":221,"context_line":"                    return resp[0]"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F99sA%3D","line":219,"in_reply_to":"AAAAUH%2F99uk%3D","updated":"2014-01-31 16:04:50.000000000","message":"This log line is temporary, pending https://review.openstack.org/#/c/69538/","commit_id":"c4858f1eb4abf185c3331e6c820306aa649cfd23"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"3189b1d1e3f9e5ae058657c54e348187a68bb7e7","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        _images \u003d []"},{"line_number":276,"context_line":"        for image in images:"},{"line_number":277,"context_line":"            if isinstance(image, tuple):"},{"line_number":278,"context_line":"                req_id \u003d image[1]"},{"line_number":279,"context_line":"                LOG.info(\"Nova-Glance request IDs: %s -\u003e %s\","},{"line_number":280,"context_line":"                         context.request_id, req_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BAZI%3D","line":277,"updated":"2014-01-31 02:33:06.000000000","message":"Same question as above","commit_id":"c4858f1eb4abf185c3331e6c820306aa649cfd23"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"984e840c76b25c48f052fd282e697d7f1e4f2cbe","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            client \u003d self.client or self._create_onetime_client(context,"},{"line_number":225,"context_line":"                                                                version)"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                #NOTE(hdd) This list is an out param to store glance\u0027s request"},{"line_number":228,"context_line":"                # id; may have been set by detail()"},{"line_number":229,"context_line":"                if \u0027return_req_id\u0027 not in kwargs:"},{"line_number":230,"context_line":"                    kwargs[\u0027return_req_id\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_3501b939","line":227,"updated":"2014-07-18 02:32:33.000000000","message":"nit: # NOTE","commit_id":"aa4eb17beb27a6374f168e9a05324671c68bb79f"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"ce2c8b3ca88c6f9da50fdaf72933bd131acac9eb","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            client \u003d self.client or self._create_onetime_client(context,"},{"line_number":225,"context_line":"                                                                version)"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                #NOTE(hdd) This list is an out param to store glance\u0027s request"},{"line_number":228,"context_line":"                # id; may have been set by detail()"},{"line_number":229,"context_line":"                if \u0027return_req_id\u0027 not in kwargs:"},{"line_number":230,"context_line":"                    kwargs[\u0027return_req_id\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_f8a8b48d","line":227,"in_reply_to":"baada198_3501b939","updated":"2014-07-21 22:15:20.000000000","message":"Done","commit_id":"aa4eb17beb27a6374f168e9a05324671c68bb79f"}],"nova/tests/glance/stubs.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"b16ecbb79f85c85c2cc5449ed5afe791beaf2069","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                    raise glanceclient.exc.HTTPForbidden"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"                for k, v in metadata.items():"},{"line_number":88,"context_line":"                    setattr(self._images[i], k, v)"},{"line_number":89,"context_line":"                return self._images[i]"},{"line_number":90,"context_line":"        raise glanceclient.exc.NotFound(image_id)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_a3d4a1e9","side":"PARENT","line":88,"updated":"2014-07-18 13:24:51.000000000","message":"Is send_req_id still implemented/used?","commit_id":"e5ea932180d29f8dd631c59ddff147376fcdf7b0"}],"nova/tests/image/fake.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"d46dfef8bfd658136cd7e6234d2c7d2b77bb5858","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            with open(dst_path, \u0027wb\u0027) as data:"},{"line_number":168,"context_line":"                data.write(self._imagedata.get(image_id, \u0027\u0027))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def show(self, context, image_id, include_locations\u003dFalse, return_req_id\u003dNone):"},{"line_number":171,"context_line":"        \"\"\"Get data about specified image."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        Returns a dict containing image data for the given opaque image id."}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_bbdd0c16","line":170,"updated":"2014-08-06 06:34:46.000000000","message":"THis line is failing pep8 because it is too long","commit_id":"530d52dc847832f4e060bd6bafdc695e53f80b36"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"e3e4c840794067122a053042a20c0f2b15f3d04e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            with open(dst_path, \u0027wb\u0027) as data:"},{"line_number":168,"context_line":"                data.write(self._imagedata.get(image_id, \u0027\u0027))"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def show(self, context, image_id, include_locations\u003dFalse, return_req_id\u003dNone):"},{"line_number":171,"context_line":"        \"\"\"Get data about specified image."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        Returns a dict containing image data for the given opaque image id."}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_7068df22","line":170,"in_reply_to":"baada198_bbdd0c16","updated":"2014-08-06 22:13:03.000000000","message":"Done","commit_id":"530d52dc847832f4e060bd6bafdc695e53f80b36"}],"requirements.txt":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"fe60d1fafe5b6d84a5ed4444d3306c70305fff70","unresolved":false,"context_lines":[{"line_number":22,"context_line":"jsonschema\u003e\u003d2.0.0,\u003c3.0.0"},{"line_number":23,"context_line":"python-cinderclient\u003e\u003d1.0.6"},{"line_number":24,"context_line":"python-neutronclient\u003e\u003d2.3.5,\u003c3"},{"line_number":25,"context_line":"python-glanceclient\u003e\u003d0.13.1"},{"line_number":26,"context_line":"python-keystoneclient\u003e\u003d0.9.0"},{"line_number":27,"context_line":"six\u003e\u003d1.7.0"},{"line_number":28,"context_line":"stevedore\u003e\u003d0.14"}],"source_content_type":"text/plain","patch_set":7,"id":"baada198_532f8c88","line":25,"updated":"2014-07-16 01:35:17.000000000","message":"Looks like Nova already has glancelient\u003e\u003d0.13.1","commit_id":"eba9bdf03139102ba311119e07fb175a8b842330"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"c56914354df66b93a76c826f03e40f19b41f185f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"jsonschema\u003e\u003d2.0.0,\u003c3.0.0"},{"line_number":23,"context_line":"python-cinderclient\u003e\u003d1.0.6"},{"line_number":24,"context_line":"python-neutronclient\u003e\u003d2.3.5,\u003c3"},{"line_number":25,"context_line":"python-glanceclient\u003e\u003d0.13.1"},{"line_number":26,"context_line":"python-keystoneclient\u003e\u003d0.9.0"},{"line_number":27,"context_line":"six\u003e\u003d1.7.0"},{"line_number":28,"context_line":"stevedore\u003e\u003d0.14"}],"source_content_type":"text/plain","patch_set":7,"id":"baada198_4cf27107","line":25,"in_reply_to":"baada198_532f8c88","updated":"2014-07-16 16:06:33.000000000","message":"Done","commit_id":"eba9bdf03139102ba311119e07fb175a8b842330"}]}