)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2a1aae675d06271afcc6069d103443d9bbe08f0","unresolved":false,"context_lines":[{"line_number":9585,"context_line":"                            {\u0027i_name\u0027: guest.name, \u0027error\u0027: e})"},{"line_number":9586,"context_line":"            except exception.DiskNotFound:"},{"line_number":9587,"context_line":"                with excutils.save_and_reraise_exception() as err_ctxt:"},{"line_number":9588,"context_line":"                    # If the instance is undergoing a task state transition,"},{"line_number":9589,"context_line":"                    # like moving to another host or is being deleted, we"},{"line_number":9590,"context_line":"                    # should ignore this instance and move on."},{"line_number":9591,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":9592,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":9593,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":9594,"context_line":"                        # state it might also can\u0027t find back disk"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0e7c1aea","side":"PARENT","line":9591,"range":{"start_line":9588,"start_character":0,"end_line":9591,"end_character":53},"updated":"2019-09-27 16:46:32.000000000","message":"Having done away with this check, aren\u0027t we going to see this warning more frequently, and in cases we explicitly don\u0027t care about?","commit_id":"36b582a55a0007af55684e8e54caf6e72744de1a"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"31bf55936dd2c006bd878af3c44493cbd3075cdf","unresolved":false,"context_lines":[{"line_number":9585,"context_line":"                            {\u0027i_name\u0027: guest.name, \u0027error\u0027: e})"},{"line_number":9586,"context_line":"            except exception.DiskNotFound:"},{"line_number":9587,"context_line":"                with excutils.save_and_reraise_exception() as err_ctxt:"},{"line_number":9588,"context_line":"                    # If the instance is undergoing a task state transition,"},{"line_number":9589,"context_line":"                    # like moving to another host or is being deleted, we"},{"line_number":9590,"context_line":"                    # should ignore this instance and move on."},{"line_number":9591,"context_line":"                    if guest.uuid in local_instances:"},{"line_number":9592,"context_line":"                        inst \u003d local_instances[guest.uuid]"},{"line_number":9593,"context_line":"                        # bug 1774249 indicated when instance is in RESIZED"},{"line_number":9594,"context_line":"                        # state it might also can\u0027t find back disk"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_548b78c1","side":"PARENT","line":9591,"range":{"start_line":9588,"start_character":0,"end_line":9591,"end_character":53},"in_reply_to":"3fa7e38b_0e7c1aea","updated":"2019-09-28 15:05:12.000000000","message":"I thought about that, but by the time we get here this data is hopelessly out of date either way. We could be either ignoring things we care about, or not ignoring things we don\u0027t care about. Also it\u0027s inconsistent because we didn\u0027t do that for the volume case, which doesn\u0027t really matter either.\n\nUltimately it shouldn\u0027t be a super common warning either way, and the text already suggests that. In fact it should probably be debug, tbh, but I\u0027d prefer to leave that discussion for another patch.","commit_id":"36b582a55a0007af55684e8e54caf6e72744de1a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2a1aae675d06271afcc6069d103443d9bbe08f0","unresolved":false,"context_lines":[{"line_number":9579,"context_line":"            except (exception.VolumeBDMPathNotFound,"},{"line_number":9580,"context_line":"                    exception.DiskNotFound) as e:"},{"line_number":9581,"context_line":"                if isinstance(e, exception.VolumeBDMPathNotFound):"},{"line_number":9582,"context_line":"                    thing \u003d \u0027backing volume block device\u0027"},{"line_number":9583,"context_line":"                elif isinstance(e, exception.DiskNotFound):"},{"line_number":9584,"context_line":"                    thing \u003d \u0027backing disk storage\u0027"},{"line_number":9585,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ce336261","line":9582,"range":{"start_line":9582,"start_character":29,"end_line":9582,"end_character":36},"updated":"2019-09-27 16:46:32.000000000","message":"nit, could fold \u0027backing\u0027 into the main message","commit_id":"2c94032d67da6406e9fbc8a27bd0cf95bfb5f083"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a2a1aae675d06271afcc6069d103443d9bbe08f0","unresolved":false,"context_lines":[{"line_number":9582,"context_line":"                    thing \u003d \u0027backing volume block device\u0027"},{"line_number":9583,"context_line":"                elif isinstance(e, exception.DiskNotFound):"},{"line_number":9584,"context_line":"                    thing \u003d \u0027backing disk storage\u0027"},{"line_number":9585,"context_line":"                else:"},{"line_number":9586,"context_line":"                    # A programming error"},{"line_number":9587,"context_line":"                    assert False, \"Missing exception class case\""},{"line_number":9588,"context_line":""},{"line_number":9589,"context_line":"                LOG.warning(\u0027Periodic task is updating the host stats, \u0027"},{"line_number":9590,"context_line":"                            \u0027it is trying to get disk info for %(i_name)s, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4ef2129c","line":9587,"range":{"start_line":9585,"start_character":16,"end_line":9587,"end_character":64},"updated":"2019-09-27 16:46:32.000000000","message":"This should be unreachable since you\u0027re explicitly only trapping the two exceptions from the prior conditions. Did you mean to just trap Exception on L9579? Or are you future-proofing against someone adding to the except list but forgetting to add a condition here?","commit_id":"2c94032d67da6406e9fbc8a27bd0cf95bfb5f083"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"b3bc775abff415897ea135760c1f21a9d2ea93fa","unresolved":false,"context_lines":[{"line_number":9582,"context_line":"                    thing \u003d \u0027backing volume block device\u0027"},{"line_number":9583,"context_line":"                elif isinstance(e, exception.DiskNotFound):"},{"line_number":9584,"context_line":"                    thing \u003d \u0027backing disk storage\u0027"},{"line_number":9585,"context_line":"                else:"},{"line_number":9586,"context_line":"                    # A programming error"},{"line_number":9587,"context_line":"                    assert False, \"Missing exception class case\""},{"line_number":9588,"context_line":""},{"line_number":9589,"context_line":"                LOG.warning(\u0027Periodic task is updating the host stats, \u0027"},{"line_number":9590,"context_line":"                            \u0027it is trying to get disk info for %(i_name)s, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_44296ef0","line":9587,"range":{"start_line":9585,"start_character":16,"end_line":9587,"end_character":64},"in_reply_to":"3fa7e38b_076f022b","updated":"2019-10-01 10:18:14.000000000","message":"The lists are duplicated because I couldn\u0027t think of a good way to do this without a duplicated list. This isn\u0027t a problem in strongly typed languages where omitting a case in the second list can normally be turned into a compilation error, but unfortunately python requires us to either trust people not to make mistakes, or implement these features ourselves.\n\nThe NameError works too, though, as long as nobody refactors this at some point in the future to define thing outside the if else block, not realising that it\u0027s a safety feature. I could add a comment, I guess, but that wouldn\u0027t be automatic and would be no shorter than the assertion it replaces. I thought the assertion was more explicit, and explicit \u003e implicit (https://www.python.org/dev/peps/pep-0020/#id3).\n\nCompared to the bug it fixes, though, this is utterly inconsequential. I\u0027ll remove it for an easy life ;)","commit_id":"2c94032d67da6406e9fbc8a27bd0cf95bfb5f083"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"31bf55936dd2c006bd878af3c44493cbd3075cdf","unresolved":false,"context_lines":[{"line_number":9582,"context_line":"                    thing \u003d \u0027backing volume block device\u0027"},{"line_number":9583,"context_line":"                elif isinstance(e, exception.DiskNotFound):"},{"line_number":9584,"context_line":"                    thing \u003d \u0027backing disk storage\u0027"},{"line_number":9585,"context_line":"                else:"},{"line_number":9586,"context_line":"                    # A programming error"},{"line_number":9587,"context_line":"                    assert False, \"Missing exception class case\""},{"line_number":9588,"context_line":""},{"line_number":9589,"context_line":"                LOG.warning(\u0027Periodic task is updating the host stats, \u0027"},{"line_number":9590,"context_line":"                            \u0027it is trying to get disk info for %(i_name)s, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_949d700b","line":9587,"range":{"start_line":9585,"start_character":16,"end_line":9587,"end_character":64},"in_reply_to":"3fa7e38b_4ef2129c","updated":"2019-09-28 15:05:12.000000000","message":"The latter, hence it\u0027s an assertion. Duplicated lists which are required to be identical make me nervous :)\n\nIncidentally, there must be something cleaner than assert False for this? Meh, this is fine.","commit_id":"2c94032d67da6406e9fbc8a27bd0cf95bfb5f083"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7c6061746872955d9e0228d9460c32b49c7925b3","unresolved":false,"context_lines":[{"line_number":9582,"context_line":"                    thing \u003d \u0027backing volume block device\u0027"},{"line_number":9583,"context_line":"                elif isinstance(e, exception.DiskNotFound):"},{"line_number":9584,"context_line":"                    thing \u003d \u0027backing disk storage\u0027"},{"line_number":9585,"context_line":"                else:"},{"line_number":9586,"context_line":"                    # A programming error"},{"line_number":9587,"context_line":"                    assert False, \"Missing exception class case\""},{"line_number":9588,"context_line":""},{"line_number":9589,"context_line":"                LOG.warning(\u0027Periodic task is updating the host stats, \u0027"},{"line_number":9590,"context_line":"                            \u0027it is trying to get disk info for %(i_name)s, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_076f022b","line":9587,"range":{"start_line":9585,"start_character":16,"end_line":9587,"end_character":64},"in_reply_to":"3fa7e38b_949d700b","updated":"2019-09-30 20:04:01.000000000","message":"\u003e Duplicated lists which are\n \u003e required to be identical make me nervous :)\n\nBut that\u0027s... basically what you\u0027ve done.\n\nI\u0027m not objecting to that per se (see below); I just think this looks weird and isn\u0027t necessary.\n\n...because all you actually have to do to enforce it is remove these three lines, and L9593 will explode with an uninitialized \u0027thing\u0027.","commit_id":"2c94032d67da6406e9fbc8a27bd0cf95bfb5f083"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"894edd1b4056b7de17a2ab342721cfb668396937","unresolved":false,"context_lines":[{"line_number":9580,"context_line":"                    exception.DiskNotFound) as e:"},{"line_number":9581,"context_line":"                if isinstance(e, exception.VolumeBDMPathNotFound):"},{"line_number":9582,"context_line":"                    thing \u003d \u0027backing volume block device\u0027"},{"line_number":9583,"context_line":"                elif isinstance(e, exception.DiskNotFound):"},{"line_number":9584,"context_line":"                    thing \u003d \u0027backing disk storage\u0027"},{"line_number":9585,"context_line":""},{"line_number":9586,"context_line":"                LOG.warning(\u0027Periodic task is updating the host stats, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a863fe18","line":9583,"range":{"start_line":9583,"start_character":15,"end_line":9583,"end_character":59},"updated":"2019-11-13 14:17:47.000000000","message":"nit:\n\n  else:  # exception.DiskNotFound\n\nbecause it took me a second to cop that we\u0027re only handling these two exception types above","commit_id":"6198f317be549e6d2bd324a48f226b379556e945"}]}