)]}'
{"nova/virt/block_device.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4fbc913bb8ecff0192c2cec4bd5a8495f78abc1c","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        connection_info \u003d volume_api.initialize_connection(context,"},{"line_number":455,"context_line":"                                                           volume_id,"},{"line_number":456,"context_line":"                                                           connector)"},{"line_number":457,"context_line":"        update_connection_info("},{"line_number":458,"context_line":"            self[\u0027connection_info\u0027], connection_info, volume_id)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        # If do_driver_attach is False, we will attach a volume to an instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c62c90ad","line":457,"range":{"start_line":457,"start_character":8,"end_line":457,"end_character":30},"updated":"2019-09-30 16:53:28.000000000","message":"this one...","commit_id":"495738b48574aa9bd82620fb49fa229c27025346"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4fbc913bb8ecff0192c2cec4bd5a8495f78abc1c","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        connection_info \u003d volume_api.attachment_update("},{"line_number":541,"context_line":"            context, attachment_id, connector,"},{"line_number":542,"context_line":"            self[\u0027mount_device\u0027])[\u0027connection_info\u0027]"},{"line_number":543,"context_line":"        update_connection_info("},{"line_number":544,"context_line":"            self[\u0027connection_info\u0027], connection_info, volume_id)"},{"line_number":545,"context_line":"        if vol_multiattach:"},{"line_number":546,"context_line":"            # This will be used by the volume driver to determine the proper"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c11a3a6d","line":543,"range":{"start_line":543,"start_character":8,"end_line":543,"end_character":30},"updated":"2019-09-30 16:53:28.000000000","message":"...and this one\n\nare now dorking with the \u0027multiattach\u0027 flag, which it appears they weren\u0027t doing before. Should the commit message mention that, and explain why it\u0027s either a no-op or okay to do?","commit_id":"495738b48574aa9bd82620fb49fa229c27025346"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"62ebb0a87d0ef94ef86f4bce6356f204d6042597","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        connection_info \u003d volume_api.attachment_update("},{"line_number":541,"context_line":"            context, attachment_id, connector,"},{"line_number":542,"context_line":"            self[\u0027mount_device\u0027])[\u0027connection_info\u0027]"},{"line_number":543,"context_line":"        update_connection_info("},{"line_number":544,"context_line":"            self[\u0027connection_info\u0027], connection_info, volume_id)"},{"line_number":545,"context_line":"        if vol_multiattach:"},{"line_number":546,"context_line":"            # This will be used by the volume driver to determine the proper"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4712da63","line":543,"range":{"start_line":543,"start_character":8,"end_line":543,"end_character":30},"in_reply_to":"3fa7e38b_8c1c7978","updated":"2019-09-30 20:17:20.000000000","message":"\u003e It could but it\u0027s harmless because these are new attachments which\n \u003e means self[\u0027connection_info\u0027] won\u0027t have the \"multiattach\" key in\n \u003e it, that\u0027s set right below and only if you\u0027re doing a new-style\n \u003e attachment (we don\u0027t support attaching a multiattach volume via\n \u003e _legacy_volume_attach).\n\nThis just seems like a lot of coupling and assumptions that will potentially bite us later.\n\nI put up https://review.opendev.org/685782 as a way of discussing.","commit_id":"495738b48574aa9bd82620fb49fa229c27025346"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9fb41978965b32c955e42edce6b137a8f01ca0b","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        connection_info \u003d volume_api.attachment_update("},{"line_number":541,"context_line":"            context, attachment_id, connector,"},{"line_number":542,"context_line":"            self[\u0027mount_device\u0027])[\u0027connection_info\u0027]"},{"line_number":543,"context_line":"        update_connection_info("},{"line_number":544,"context_line":"            self[\u0027connection_info\u0027], connection_info, volume_id)"},{"line_number":545,"context_line":"        if vol_multiattach:"},{"line_number":546,"context_line":"            # This will be used by the volume driver to determine the proper"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8c1c7978","line":543,"range":{"start_line":543,"start_character":8,"end_line":543,"end_character":30},"in_reply_to":"3fa7e38b_c11a3a6d","updated":"2019-09-30 18:55:08.000000000","message":"\u003e Should the commit message mention that, and\n \u003e explain why it\u0027s either a no-op or okay to do?\n\nIt could but it\u0027s harmless because these are new attachments which means self[\u0027connection_info\u0027] won\u0027t have the \"multiattach\" key in it, that\u0027s set right below and only if you\u0027re doing a new-style attachment (we don\u0027t support attaching a multiattach volume via _legacy_volume_attach).","commit_id":"495738b48574aa9bd82620fb49fa229c27025346"}]}