)]}'
{"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"91729fb684ac3e6ffab4c952d4c471a24a452e36","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                mock.patch.object(volumeops.VMwareVolumeOps,"},{"line_number":522,"context_line":"                                  \u0027attach_volume\u0027, autospec\u003dTrue)"},{"line_number":523,"context_line":"        ) as (mock_block_device_info_get_mapping, mock_get_res_pool_of_vm,"},{"line_number":524,"context_line":"              mock_relocate_vmdk_volume, mock_attach_volume):"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"            mock_block_device_info_get_mapping.return_value \u003d root_disk"},{"line_number":527,"context_line":"            mock_get_res_pool_of_vm.return_value \u003d \u0027fake_res_pool\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F993o%3D","line":524,"updated":"2014-01-31 15:37:13.000000000","message":"Note that when you\u0027re mocking out a bunch of calls for most of the test function, it\u0027s much cleaner to use mock.patch.object as a decorator on the test method itself. It avoids a massive amount of nesting.","commit_id":"5b49fa12a7f86a4f23adbbbb318043a35209a8d8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"91729fb684ac3e6ffab4c952d4c471a24a452e36","unresolved":false,"context_lines":[{"line_number":535,"context_line":"            mock_relocate_vmdk_volume.assert_called_once_with("},{"line_number":536,"context_line":"                mock.ANY, mock.ANY, \u0027fake_res_pool\u0027, mock.ANY)"},{"line_number":537,"context_line":"            mock_attach_volume.assert_called_once_with("},{"line_number":538,"context_line":"                mock.ANY, connection_info, self.instance, mock.ANY)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def test_spawn_attach_volume_vmdk(self):"},{"line_number":541,"context_line":"        self._spawn_attach_volume_vmdk()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F994A%3D","line":538,"updated":"2014-01-31 15:37:13.000000000","message":"This is not functionally equivalent to the mox version because this does not verify that block_device_info_get_mapping() and _get_res_pool_of_vm() were called.","commit_id":"5b49fa12a7f86a4f23adbbbb318043a35209a8d8"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2ff10ce8f54c79cf4c2f860fceb830902aaa86de","unresolved":false,"context_lines":[{"line_number":535,"context_line":"            mock_relocate_vmdk_volume.assert_called_once_with("},{"line_number":536,"context_line":"                mock.ANY, mock.ANY, \u0027fake_res_pool\u0027, mock.ANY)"},{"line_number":537,"context_line":"            mock_attach_volume.assert_called_once_with("},{"line_number":538,"context_line":"                mock.ANY, connection_info, self.instance, mock.ANY)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def test_spawn_attach_volume_vmdk(self):"},{"line_number":541,"context_line":"        self._spawn_attach_volume_vmdk()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F91nY%3D","line":538,"in_reply_to":"AAAAUH%2F994A%3D","updated":"2014-02-03 13:32:22.000000000","message":"See later test for removal of block_device_info_get_mapping(), which doesn\u0027t need to be mocked. Also, _get_res_pool_of_vm() isn\u0027t under test here. It\u0027s only stubbed here as an implementation detail. We could check it, but it would only serve to obfuscate the purpose of the test. In fact, you could say the same of relocate_vmdk_volume().","commit_id":"5b49fa12a7f86a4f23adbbbb318043a35209a8d8"}]}