)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b76917d451b3ff9cbcf6d7260542349903fb57fc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: injected_file is not supported for volume but still executed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The option injected_file is not supported for volumes but the process is"},{"line_number":10,"context_line":"still executed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Notes:"},{"line_number":13,"context_line":" - The method _create_image has been refactored to help"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2Bq2g%3D","line":10,"updated":"2014-01-23 11:15:23.000000000","message":"Bug number ?","commit_id":"2d2d75086a4e947f1a33efe7536e8e6857a5fc16"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dddb133b2055c5b14682bede2749858daee76903","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: injected_file is not supported for volume but still executed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The option injected_file is not supported for volumes but the process is"},{"line_number":10,"context_line":"still executed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Notes:"},{"line_number":13,"context_line":" - The method _create_image has been refactored to help"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BqN4%3D","line":10,"in_reply_to":"AAAAUH%2F%2Bq2g%3D","updated":"2014-01-23 13:13:53.000000000","message":"oops I forgot to attach it:\nhttps://bugs.launchpad.net/nova/+bug/1271528","commit_id":"2d2d75086a4e947f1a33efe7536e8e6857a5fc16"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b76917d451b3ff9cbcf6d7260542349903fb57fc","unresolved":false,"context_lines":[{"line_number":13,"context_line":" - The method _create_image has been refactored to help"},{"line_number":14,"context_line":"   to add missing tests."},{"line_number":15,"context_line":" - This patch is a first step of refactors of the algorithm"},{"line_number":16,"context_line":"   to inject_file in separate module."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa92f84ad3de9e84ba49bb255add043f3c8e4c8f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2Bq2w%3D","line":16,"updated":"2014-01-23 11:15:23.000000000","message":"If you\u0027re going to start refactoring this code I\u0027d expect to see a blueprint created first to describe what you\u0027re goals are and the new proposed design.\n\nAs a general every change you submit should have an associated bug or blueprint unless it is a trivial patch, which this isn\u0027t.","commit_id":"2d2d75086a4e947f1a33efe7536e8e6857a5fc16"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dddb133b2055c5b14682bede2749858daee76903","unresolved":false,"context_lines":[{"line_number":13,"context_line":" - The method _create_image has been refactored to help"},{"line_number":14,"context_line":"   to add missing tests."},{"line_number":15,"context_line":" - This patch is a first step of refactors of the algorithm"},{"line_number":16,"context_line":"   to inject_file in separate module."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaa92f84ad3de9e84ba49bb255add043f3c8e4c8f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BqNg%3D","line":16,"in_reply_to":"AAAAUH%2F%2Bq2w%3D","updated":"2014-01-23 13:13:53.000000000","message":"Sure, I will remove this line in the next patchset and push a blueprint.","commit_id":"2d2d75086a4e947f1a33efe7536e8e6857a5fc16"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7e3f6f2ae29fc6adcb80ec1ac2e221f5bf5c7629","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Refactors driver._create_image to add tests."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The method _create_image has been splitted in several small"},{"line_number":10,"context_line":"methods to help to add missing tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1271528"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUX%2F%2FaBw%3D","line":9,"updated":"2014-02-13 12:46:36.000000000","message":"splitted  \u003d\u003e split","commit_id":"65f9c0c3d19eda914866f8fc06c46b946dfdbc68"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d1b47f22d000568e920b25a06317f9ea54ec6bd3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The method _create_image has been split in several small"},{"line_number":10,"context_line":"methods to help to add missing tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Adds: _is_booted_from_volume"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1271528"},{"line_number":15,"context_line":"Change-Id: Iaa92f84ad3de9e84ba49bb255add043f3c8e4c8f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"AAAAVn%2F%2Ft5o%3D","line":12,"updated":"2014-03-04 14:22:11.000000000","message":"This isn\u0027t a particularly helpful commit message since the majority of it, including the subject line is identical to later commits of yours eg https://review.openstack.org/#/c/77593/\n\nI suggest it should just describe what it is doing ie\n\n   Add helper method for checking if VM is booting from a volume\n\n   Add a _is_booted_from_value method which determines whether\n   the disk mapping indicates that the VM is booting from a volume\n   Update the _create_image method to use this helper API.","commit_id":"595be51d2f8d4677c782d4bc0252ce3932a12561"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e642d62cb373d6cb7321906e4c48acf4fed9c6ad","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The method _create_image has been split in several small"},{"line_number":10,"context_line":"methods to help to add missing tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Adds: _is_booted_from_volume"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #1271528"},{"line_number":15,"context_line":"Change-Id: Iaa92f84ad3de9e84ba49bb255add043f3c8e4c8f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"AAAAVn%2F%2FsaI%3D","line":12,"in_reply_to":"AAAAVn%2F%2Ft5o%3D","updated":"2014-03-04 16:30:39.000000000","message":"I\u0027m completely agree. Really helpful review, thanks a lot Daniel.","commit_id":"595be51d2f8d4677c782d4bc0252ce3932a12561"}],"nova/tests/virt/libvirt/test_libvirt.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6b9023080c0f839737206bd9f28901428ce52b6d","unresolved":false,"context_lines":[{"line_number":3520,"context_line":"        conn._create_images_and_backing(self.context, self.test_instance,"},{"line_number":3521,"context_line":"                                        \"/fake/instance/dir\", None)"},{"line_number":3522,"context_line":""},{"line_number":3523,"context_line":"    def _test_create_image(self, inject_partition\u003d0, booted_from_volume\u003dFalse):"},{"line_number":3524,"context_line":"        context \u003d \u0027ctx\u0027"},{"line_number":3525,"context_line":"        instance \u003d {\u0027name\u0027: \u0027foo\u0027,"},{"line_number":3526,"context_line":"                    \u0027uuid\u0027: \u0027foo-id\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAU3%2F%2F2s8%3D","line":3523,"updated":"2014-02-24 13:51:04.000000000","message":"Why not use mock in these tests? They seem to be brand new and not depanding on old mox infrastructure, so why not take the opportunity?","commit_id":"741b3e18d8b8869b9ff9cc8796008287a489d085"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f900440ae43dce8a2ece59f8fb19d150c2c53aca","unresolved":false,"context_lines":[{"line_number":3520,"context_line":"        conn._create_images_and_backing(self.context, self.test_instance,"},{"line_number":3521,"context_line":"                                        \"/fake/instance/dir\", None)"},{"line_number":3522,"context_line":""},{"line_number":3523,"context_line":"    def _test_create_image(self, inject_partition\u003d0, booted_from_volume\u003dFalse):"},{"line_number":3524,"context_line":"        context \u003d \u0027ctx\u0027"},{"line_number":3525,"context_line":"        instance \u003d {\u0027name\u0027: \u0027foo\u0027,"},{"line_number":3526,"context_line":"                    \u0027uuid\u0027: \u0027foo-id\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAU3%2F%2F1ZM%3D","line":3523,"in_reply_to":"AAAAU3%2F%2F2s8%3D","updated":"2014-02-24 15:38:03.000000000","message":"A lot of code here are using mox, that why I have continue with it.","commit_id":"741b3e18d8b8869b9ff9cc8796008287a489d085"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"5d1318959484e4ce00ac32df3e7e05345bbbb51d","unresolved":false,"context_lines":[{"line_number":2544,"context_line":"                                  e, instance\u003dinstance)"},{"line_number":2545,"context_line":""},{"line_number":2546,"context_line":"        # File injection only if needed"},{"line_number":2547,"context_line":"        elif bool(files) and CONF.libvirt.inject_partition !\u003d -2:"},{"line_number":2548,"context_line":"            if booted_from_volume:"},{"line_number":2549,"context_line":"                LOG.warn(_(\u0027File injection into a boot from volume \u0027"},{"line_number":2550,"context_line":"                           \u0027instance is not supported\u0027), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Bptc%3D","line":2547,"updated":"2014-01-23 14:47:48.000000000","message":"This looks incorrect. You\u0027ve dropped the inject_files boolean added in change I01990de0ad2c7f1c2e499144034b7a4ac9faf024","commit_id":"27142d49cdc9e45c11586b07045d2ab87a937dc0"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7d728e29836abb8a8040230357e54085e62235a2","unresolved":false,"context_lines":[{"line_number":2544,"context_line":"                                  e, instance\u003dinstance)"},{"line_number":2545,"context_line":""},{"line_number":2546,"context_line":"        # File injection only if needed"},{"line_number":2547,"context_line":"        elif bool(files) and CONF.libvirt.inject_partition !\u003d -2:"},{"line_number":2548,"context_line":"            if booted_from_volume:"},{"line_number":2549,"context_line":"                LOG.warn(_(\u0027File injection into a boot from volume \u0027"},{"line_number":2550,"context_line":"                           \u0027instance is not supported\u0027), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BpbM%3D","line":2547,"in_reply_to":"AAAAUH%2F%2Bptc%3D","updated":"2014-01-23 15:52:19.000000000","message":"You completely right. It\u0027s my mistake during a revert. (probably i need to test it)","commit_id":"27142d49cdc9e45c11586b07045d2ab87a937dc0"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"94113795fa733635a9de328ce28ad475e6cf4fad","unresolved":false,"context_lines":[{"line_number":2412,"context_line":"                      block_device_info\u003dNone, files\u003dNone,"},{"line_number":2413,"context_line":"                      admin_pass\u003dNone, inject_files\u003dTrue):"},{"line_number":2414,"context_line":"        if not suffix:"},{"line_number":2415,"context_line":"            suffix \u003d \u0027\u0027"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"        booted_from_volume \u003d ("},{"line_number":2418,"context_line":"            (not bool(instance.get(\u0027image_ref\u0027)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bisw%3D","side":"PARENT","line":2415,"updated":"2014-01-24 15:36:38.000000000","message":"\u0027m worried about dropping the above None -\u003e \u0027\u0027 mapping","commit_id":"f5d1943992d11446e095beaebf66443ec0f01ee0"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"74a570d61ad40a9bcfe55881047b28d1b668889f","unresolved":false,"context_lines":[{"line_number":2412,"context_line":"                      block_device_info\u003dNone, files\u003dNone,"},{"line_number":2413,"context_line":"                      admin_pass\u003dNone, inject_files\u003dTrue):"},{"line_number":2414,"context_line":"        if not suffix:"},{"line_number":2415,"context_line":"            suffix \u003d \u0027\u0027"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"        booted_from_volume \u003d ("},{"line_number":2418,"context_line":"            (not bool(instance.get(\u0027image_ref\u0027)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bink%3D","side":"PARENT","line":2415,"in_reply_to":"AAAAUH%2F%2Biog%3D","updated":"2014-01-24 15:51:48.000000000","message":"Ok,  I will submit a new patchset to remove this variable.","commit_id":"f5d1943992d11446e095beaebf66443ec0f01ee0"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"05ffc3d40cab25a99a3212b45e376d4d186f8b85","unresolved":false,"context_lines":[{"line_number":2412,"context_line":"                      block_device_info\u003dNone, files\u003dNone,"},{"line_number":2413,"context_line":"                      admin_pass\u003dNone, inject_files\u003dTrue):"},{"line_number":2414,"context_line":"        if not suffix:"},{"line_number":2415,"context_line":"            suffix \u003d \u0027\u0027"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"        booted_from_volume \u003d ("},{"line_number":2418,"context_line":"            (not bool(instance.get(\u0027image_ref\u0027)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Biog%3D","side":"PARENT","line":2415,"in_reply_to":"AAAAUH%2F%2Biqg%3D","updated":"2014-01-24 15:49:11.000000000","message":"OK if you\u0027ve checked that\u0027s fine with me. thanks","commit_id":"f5d1943992d11446e095beaebf66443ec0f01ee0"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a77402692725e0310fbc6a15528b408884a663c7","unresolved":false,"context_lines":[{"line_number":2412,"context_line":"                      block_device_info\u003dNone, files\u003dNone,"},{"line_number":2413,"context_line":"                      admin_pass\u003dNone, inject_files\u003dTrue):"},{"line_number":2414,"context_line":"        if not suffix:"},{"line_number":2415,"context_line":"            suffix \u003d \u0027\u0027"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"        booted_from_volume \u003d ("},{"line_number":2418,"context_line":"            (not bool(instance.get(\u0027image_ref\u0027)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Biqg%3D","side":"PARENT","line":2415,"in_reply_to":"AAAAUH%2F%2Bisw%3D","updated":"2014-01-24 15:43:20.000000000","message":"suffix is already equal to \u0027\u0027, this method is private and I have checked every calls, no one uses this arg. In fact, i think we could remove it.\n\nwhat do you think?","commit_id":"f5d1943992d11446e095beaebf66443ec0f01ee0"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"86d46057f5be80d53b6e32992b94beab1e590d1d","unresolved":false,"context_lines":[{"line_number":2437,"context_line":"        if not suffix:"},{"line_number":2438,"context_line":"            suffix \u003d \u0027\u0027"},{"line_number":2439,"context_line":""},{"line_number":2440,"context_line":"        booted_from_volume \u003d LibvirtDriver._is_booted_from_volume("},{"line_number":2441,"context_line":"            instance, disk_mapping)"},{"line_number":2442,"context_line":""},{"line_number":2443,"context_line":"        def image(fname, image_type\u003dCONF.libvirt.images_type):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2BuFI%3D","line":2440,"updated":"2014-02-19 15:47:13.000000000","message":"This should be \u0027self._is_booted_from_volume\u0027 IMHO","commit_id":"dd32b9a3066ff2295bff01fdcfa8bc85fd8f39a7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"eb16f8a5fb0594ece5dfa06428f038687a25c239","unresolved":false,"context_lines":[{"line_number":2437,"context_line":"        if not suffix:"},{"line_number":2438,"context_line":"            suffix \u003d \u0027\u0027"},{"line_number":2439,"context_line":""},{"line_number":2440,"context_line":"        booted_from_volume \u003d LibvirtDriver._is_booted_from_volume("},{"line_number":2441,"context_line":"            instance, disk_mapping)"},{"line_number":2442,"context_line":""},{"line_number":2443,"context_line":"        def image(fname, image_type\u003dCONF.libvirt.images_type):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2BtMc%3D","line":2440,"in_reply_to":"AAAAUX%2F%2BuFI%3D","updated":"2014-02-19 17:13:27.000000000","message":"yes you probably right, it\u0027s a private method.","commit_id":"dd32b9a3066ff2295bff01fdcfa8bc85fd8f39a7"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6b9023080c0f839737206bd9f28901428ce52b6d","unresolved":false,"context_lines":[{"line_number":2579,"context_line":"        if CONF.libvirt.virt_type \u003d\u003d \u0027uml\u0027:"},{"line_number":2580,"context_line":"            libvirt_utils.chown(image(\u0027disk\u0027).path, \u0027root\u0027)"},{"line_number":2581,"context_line":""},{"line_number":2582,"context_line":"    def _image_disk_cache(self, context, instance, disk_images, suffix, image):"},{"line_number":2583,"context_line":"        root_fname \u003d imagecache.get_cache_fname(disk_images, \u0027image_id\u0027)"},{"line_number":2584,"context_line":"        size \u003d instance[\u0027root_gb\u0027] * units.Gi"},{"line_number":2585,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAU3%2F%2F24w%3D","line":2582,"updated":"2014-02-24 13:51:04.000000000","message":"image here is a helper function - we might want to be explicit about that with the name otherwise it\u0027s kind of confusing. as one might think it is the image dict that is being passed, as this is the norm for other methods in the driver.","commit_id":"741b3e18d8b8869b9ff9cc8796008287a489d085"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f900440ae43dce8a2ece59f8fb19d150c2c53aca","unresolved":false,"context_lines":[{"line_number":2579,"context_line":"        if CONF.libvirt.virt_type \u003d\u003d \u0027uml\u0027:"},{"line_number":2580,"context_line":"            libvirt_utils.chown(image(\u0027disk\u0027).path, \u0027root\u0027)"},{"line_number":2581,"context_line":""},{"line_number":2582,"context_line":"    def _image_disk_cache(self, context, instance, disk_images, suffix, image):"},{"line_number":2583,"context_line":"        root_fname \u003d imagecache.get_cache_fname(disk_images, \u0027image_id\u0027)"},{"line_number":2584,"context_line":"        size \u003d instance[\u0027root_gb\u0027] * units.Gi"},{"line_number":2585,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAU3%2F%2F1Y0%3D","line":2582,"in_reply_to":"AAAAU3%2F%2F24w%3D","updated":"2014-02-24 15:38:03.000000000","message":"we can probably update the name.","commit_id":"741b3e18d8b8869b9ff9cc8796008287a489d085"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6b9023080c0f839737206bd9f28901428ce52b6d","unresolved":false,"context_lines":[{"line_number":2599,"context_line":"        return ((not bool(instance.get(\u0027image_ref\u0027)))"},{"line_number":2600,"context_line":"                or \u0027disk\u0027 not in disk_mapping)"},{"line_number":2601,"context_line":""},{"line_number":2602,"context_line":"    def _help_inject_files(self, instance, network_info,"},{"line_number":2603,"context_line":"                           image, admin_pass, files):"},{"line_number":2604,"context_line":"        target_partition \u003d None"},{"line_number":2605,"context_line":"        if not instance[\u0027kernel_id\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAU3%2F%2F26s%3D","line":2602,"updated":"2014-02-24 13:51:04.000000000","message":"I don\u0027t like the name of this method, why is it not just inject_files? And would it make more sense to make it a utility function instead?","commit_id":"741b3e18d8b8869b9ff9cc8796008287a489d085"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f900440ae43dce8a2ece59f8fb19d150c2c53aca","unresolved":false,"context_lines":[{"line_number":2599,"context_line":"        return ((not bool(instance.get(\u0027image_ref\u0027)))"},{"line_number":2600,"context_line":"                or \u0027disk\u0027 not in disk_mapping)"},{"line_number":2601,"context_line":""},{"line_number":2602,"context_line":"    def _help_inject_files(self, instance, network_info,"},{"line_number":2603,"context_line":"                           image, admin_pass, files):"},{"line_number":2604,"context_line":"        target_partition \u003d None"},{"line_number":2605,"context_line":"        if not instance[\u0027kernel_id\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAU3%2F%2F1XY%3D","line":2602,"in_reply_to":"AAAAU3%2F%2F26s%3D","updated":"2014-02-24 15:38:03.000000000","message":"I can rename the method, this patchset adds tests but does not change the logic of the code, I can move this method in an other patchset.","commit_id":"741b3e18d8b8869b9ff9cc8796008287a489d085"}]}