)]}'
{"id":"openstack%2Fnova~686066","triplet_id":"openstack%2Fnova~stable%2Ftrain~I9521f21a685edc44121d75bdf534c201fa87c2d7","project":"openstack/nova","branch":"stable/train","topic":"bug/1845243","hashtags":[],"change_id":"I9521f21a685edc44121d75bdf534c201fa87c2d7","subject":"Reduce scope of \u0027path\u0027 query parameter to noVNC consoles","status":"MERGED","created":"2019-10-01 22:16:57.000000000","updated":"2019-10-02 14:32:46.000000000","submitted":"2019-10-02 14:29:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"686066-1570026545395-b42f53c0","meta_rev_id":"a204cae8432fd22e03c90acdbe27cd0c32be2df4","_number":686066,"virtual_id_number":686066,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-02 14:29:05.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2019-10-02 06:10:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2019-10-01 22:28:21.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-02 13:16:02.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-10-01 22:33:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-02 13:16:02.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-01 22:28:21.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-10-01 22:33:51.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-10-02 06:10:48.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-02 13:16:02.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-10-02 14:29:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"79f439c56f3083fc1c2e16f38cdd99d351ff16f0","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-10-01 22:16:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0527114c1921814d46649aad88c955d77215e993","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-10-01 22:28:21.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/686066/1 : FAILURE in 10m 30s","accounts_in_message":[],"_revision_number":1},{"id":"d83d6759766f8b386a8b3177f66d0dea835efb75","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-01 22:33:51.000000000","message":"Patch Set 1: Code-Review+1\n\nClean cherry pick, needed for RC2","accounts_in_message":[],"_revision_number":1},{"id":"c67e5a654db29b2c8c7291251a9bbdc06635585c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 23:32:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8d9c866d4f4141968039ef126a31ee4f : SUCCESS in 16m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dbbe0e5a6e0049b69ea85fbb5b81e12a : SUCCESS in 15m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cd3d03be95004ad1a72268ab555f54da : SUCCESS in 9m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/10c41ca7d5d4426c80c5030ea6762b73 : SUCCESS in 14m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a0fd1bd3d69f468c8d6e76a379b3e6b7 : SUCCESS in 14m 54s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9e2621b25f7044bab5455ee01c0f6152 : SUCCESS in 13m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eae0a9ae27eb45f9ab78726b72185a77 : SUCCESS in 12m 37s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/e536c2645bd24b76918dc866db97508f : SUCCESS in 1h 03m 41s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/422d129f81e14b778334a5254cdf96c1 : SUCCESS in 1h 08m 41s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/fbb9133a631346daa5f2bdaf767eece2 : SUCCESS in 54m 16s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/e97bb3c3c0aa47998830335c206f16f6 : SUCCESS in 19m 18s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/7f22ff4c470749cfb07b3b58f3874be3 : SUCCESS in 21m 22s","accounts_in_message":[],"_revision_number":1},{"id":"9b72d6a02090068b344bf7be4d1c7966cbd5e0ad","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-10-02 06:10:48.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/66/686066/1/check/tempest-dsvm-full-xenial/8d76dcf/ : SUCCESS in 2h 31m 03s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/66/686066/1/check/tempest-dsvm-full-xenial-py3/f635d99/ : SUCCESS in 2h 28m 12s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/66/686066/1/check/grenade-dsvm-xenial/eba727d/ : SUCCESS in 2h 08m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9008ef2a79a0012665d4224b82a4b550e2746f79","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-02 13:16:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport, the fix on master is merged, we want this for Train RC2. Given Mel is a stable core I\u0027m going to consider her backport as an implied +2 and approve.","accounts_in_message":[],"_revision_number":1},{"id":"8f12a78149e9a221a9cf6a168047adacf926a98c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 13:16:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"df5fb290a879e412891b16ba85dde2f9034b69c6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 14:29:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ba2f427288c8a4069d206c8e1dc24d8d849c7902","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 14:29:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2f16d04b278f49df9f06d61cd43a2232 : SUCCESS in 16m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/17cbdc2d23c14758a8be6732de70b19f : SUCCESS in 12m 06s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8319f74d2b9448afb12bc9ec0334dbf4 : SUCCESS in 13m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e541a0b32fcb4e3b934ef5c1918771e0 : SUCCESS in 13m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a9c4c1000861400f957b729887139777 : SUCCESS in 14m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/94f8bf4b1b8845fda0504bfd5e9fb53a : SUCCESS in 9m 49s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f86ce64f3bd841e8845970e034ad4ff2 : SUCCESS in 1h 11m 31s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/dbec9506312544ffb15c6dbe69fb429b : SUCCESS in 51m 01s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/61a11a9e4e22401f84d233542d48ca5b : SUCCESS in 22m 16s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/9843c9540d6d444aa5800232f58507e2 : SUCCESS in 19m 46s","accounts_in_message":[],"_revision_number":1},{"id":"7cd54fceccb84496e8e1751594fd55b287d34ddc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 14:32:46.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0da5a6db90274849a22da01478a2ab4b : SUCCESS in 1m 13s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e736babdfea277720634ac00fd9dc119042837b9","revisions":{"e736babdfea277720634ac00fd9dc119042837b9":{"kind":"REWORK","_number":1,"created":"2019-10-01 22:16:57.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/66/686066/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/66/686066/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/66/686066/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/66/686066/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/66/686066/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/66/686066/1"}}},"commit":{"parents":[{"commit":"c00afece81c815af4c157994ac46eef87faca0be","subject":"Merge \"make virtual pmem feature compatible with python3\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c00afece81c815af4c157994ac46eef87faca0be"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-09-27 02:10:22.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2019-10-01 22:16:42.000000000","tz":0},"subject":"Reduce scope of \u0027path\u0027 query parameter to noVNC consoles","message":"Reduce scope of \u0027path\u0027 query parameter to noVNC consoles\n\nThis is a partial revert of commit\n9606c80402f6db20d62b689c58aa8f024183628a which added the \u0027path\u0027 query\nparameter to work with noVNC v1.1.0. This broke all other console types\nusing websockify server (serial, spice) because the websockify server\nitself doesn\u0027t know how to handle the \u0027path\u0027 query parameter. It is the\nnoVNC vnc_lite.html file which parses the \u0027path\u0027 variable and uses it\nas the url to the websockify server. So, all other console types should\n*not* be generating a console access url with a \u0027path\u0027 query parameter,\nonly noVNC.\n\nCloses-Bug: #1845243\n\nTODO(melwitt): Figure out how to test serial and/or spice console in\nthe gate\n\nChange-Id: I9521f21a685edc44121d75bdf534c201fa87c2d7\n(cherry picked from commit 54125a75fb056dbea115408610f90e7d6eee5139)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e736babdfea277720634ac00fd9dc119042837b9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e736babdfea277720634ac00fd9dc119042837b9"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}