)]}'
{"nova/compute/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bf21d47291848455b42048ca568f595bda07c804","unresolved":false,"context_lines":[{"line_number":5274,"context_line":"            # If we got a result (not a timeout or not found exception) we"},{"line_number":5275,"context_line":"            # found the node and can return it."},{"line_number":5276,"context_line":"            if not nova_context.is_cell_failure_sentinel(result):"},{"line_number":5277,"context_line":"                return result"},{"line_number":5278,"context_line":"        raise exception.ComputeHostNotFound(host\u003dcompute_id)"},{"line_number":5279,"context_line":""},{"line_number":5280,"context_line":"    def compute_node_get_all(self, context, limit\u003dNone, marker\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_45676826","line":5277,"updated":"2019-10-30 20:35:20.000000000","message":"This looks OK on the surface but I wonder about the behavior in a case where all results were cell failures. Before this patch, I think we\u0027d bubble that error up from here but with this, we would raise ComputeHostNotFound if all cells returned failures and at least one had an exception [other than ComputeHostNotFound] example: a DBError.\n\nSo I\u0027m wondering if we should have some logic after this that goes through the results if all were failures and raises the first encountered exception that is not ComputeHostNotFound else raise CellTimeout? Do we normally expose CellTimeout? (later) Looks like we do raise it out of get_minimum_version_all_cells in nova/objects/service.py but I\u0027m not sure whether we handle that at the API layer. It doesn\u0027t look like it from a quick look at nova/api/openstack/compute/server_groups.py where get_minimum_version_all_cells is called.\n\nI\u0027m thinking of a case where ComputeHostNotFound misleads someone when the actual problem was that all cells timed out.","commit_id":"74e9b6778fa60ec37598a93f88edf1c48f9a1fef"}]}