)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"bf18ca69d6825875baa30cbabef419f8c1c0ec9d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"when there is a down cell."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9653a46478c80b343a5a5f8d6b1607688538b1d5"},{"line_number":14,"context_line":"CLoses-Bug: #1846559"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_74066223","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"updated":"2019-10-04 06:52:41.000000000","message":"It\u0027s from https://review.opendev.org/#/c/685927, from this you can get more.","commit_id":"94f3294d06564cc95fcb9465d7599f4c7854187c"}],"api-guide/source/down_cells.rst":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ef8a3404ca3b613b0ce8dfdce70fc1622e7859c0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - tenant_id: The tenant_id to which the server belongs to."},{"line_number":69,"context_line":"  - created: The time of server creation."},{"line_number":70,"context_line":"  - links: Links to the servers in question."},{"line_number":71,"context_line":"  - security_groups: One or more security groups. (Optional)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  A sample response for a GET /servers/details request that includes"},{"line_number":74,"context_line":"  one result each from an unreachable and a healthy part of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_d42076b3","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":60},"updated":"2019-10-04 06:51:33.000000000","message":"yeah, it\u0027s optional, when create server with \u0027network!\u003dNone\u0027, it will be not return the \"security_groups\" in the response body. In contrast, it will be return \"security_groups\" in response body.\n\nSo I think we shuold add some details inline to make it clearly.","commit_id":"94f3294d06564cc95fcb9465d7599f4c7854187c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ae53f4d28e7bf7da77d6af40f924227808364d13","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - tenant_id: The tenant_id to which the server belongs to."},{"line_number":69,"context_line":"  - created: The time of server creation."},{"line_number":70,"context_line":"  - links: Links to the servers in question."},{"line_number":71,"context_line":"  - security_groups: One or more security groups. (Optional)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  A sample response for a GET /servers/details request that includes"},{"line_number":74,"context_line":"  one result each from an unreachable and a healthy part of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_8f1c0478","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":60},"in_reply_to":"3fa7e38b_3099cf1e","updated":"2019-10-07 20:14:32.000000000","message":"Is \"Optional\" the right word, though? That\u0027s used for inputs. You don\u0027t have an option as to whether it appears in the output or not; it\u0027s kind of based on factors not directly in your control.\n\nI don\u0027t have a better suggestion, though. \"Sometimes\"? \"Maybe\"?\n\nBut the wording in the lead-in paragraph just says \"A typical response\", so it\u0027s not really committing to anything either way.","commit_id":"94f3294d06564cc95fcb9465d7599f4c7854187c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ce96ebfeb45838199a4533f86326e4a53cbd035","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - tenant_id: The tenant_id to which the server belongs to."},{"line_number":69,"context_line":"  - created: The time of server creation."},{"line_number":70,"context_line":"  - links: Links to the servers in question."},{"line_number":71,"context_line":"  - security_groups: One or more security groups. (Optional)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  A sample response for a GET /servers/details request that includes"},{"line_number":74,"context_line":"  one result each from an unreachable and a healthy part of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_01d184fb","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":60},"in_reply_to":"3fa7e38b_8f1c0478","updated":"2019-10-10 22:04:02.000000000","message":"\u003e Is \"Optional\" the right word, though? That\u0027s used for inputs. You\n \u003e don\u0027t have an option as to whether it appears in the output or not;\n \u003e it\u0027s kind of based on factors not directly in your control.\n \u003e \n \u003e I don\u0027t have a better suggestion, though. \"Sometimes\"? \"Maybe\"?\n \u003e \n \u003e But the wording in the lead-in paragraph just says \"A typical\n \u003e response\", so it\u0027s not really committing to anything either way.\n\n(optional) is what shows up in the API reference for things that might not show up in the response so this is being consistent.","commit_id":"94f3294d06564cc95fcb9465d7599f4c7854187c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b5a4b821656f77385b41662cf23001f23e18c26e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - tenant_id: The tenant_id to which the server belongs to."},{"line_number":69,"context_line":"  - created: The time of server creation."},{"line_number":70,"context_line":"  - links: Links to the servers in question."},{"line_number":71,"context_line":"  - security_groups: One or more security groups. (Optional)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  A sample response for a GET /servers/details request that includes"},{"line_number":74,"context_line":"  one result each from an unreachable and a healthy part of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_39be7765","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":60},"in_reply_to":"3fa7e38b_8f1c0478","updated":"2019-10-08 01:15:34.000000000","message":"Agree Eric, the \"security_groups\" is not directly by the operator, if I stand in the tester\u0027s point of view, I would think this is a bug.\nBut as a simple user, maybe I don\u0027t care about this because it doesn\u0027t affect my use of the server.","commit_id":"94f3294d06564cc95fcb9465d7599f4c7854187c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ad723a75953952e6b815a5ed578425ee24fd74ae","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - tenant_id: The tenant_id to which the server belongs to."},{"line_number":69,"context_line":"  - created: The time of server creation."},{"line_number":70,"context_line":"  - links: Links to the servers in question."},{"line_number":71,"context_line":"  - security_groups: One or more security groups. (Optional)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  A sample response for a GET /servers/details request that includes"},{"line_number":74,"context_line":"  one result each from an unreachable and a healthy part of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_f5aec996","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":60},"in_reply_to":"3fa7e38b_d42076b3","updated":"2019-10-04 13:34:29.000000000","message":"I don\u0027t know how much detail we want to get into here because there are a few factors.\n\n1. neutron vs nova-net\n2. if neutron, does the server have ports attached\n3. if so, do those ports have security groups\n\nI believe the port security enabled extension in neutron is just that, an extension, which I think means it\u0027s technically optional, so even if you create a server with ports attached they technically might not have security groups applied.\n\nI don\u0027t think we want to get into those details here in the API guide.","commit_id":"94f3294d06564cc95fcb9465d7599f4c7854187c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b5a4b821656f77385b41662cf23001f23e18c26e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - tenant_id: The tenant_id to which the server belongs to."},{"line_number":69,"context_line":"  - created: The time of server creation."},{"line_number":70,"context_line":"  - links: Links to the servers in question."},{"line_number":71,"context_line":"  - security_groups: One or more security groups. (Optional)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  A sample response for a GET /servers/details request that includes"},{"line_number":74,"context_line":"  one result each from an unreachable and a healthy part of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_f9b77f85","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":60},"in_reply_to":"3fa7e38b_f5aec996","updated":"2019-10-08 01:15:34.000000000","message":"\u003e 1. neutron vs nova-net\n\u003e 2. if neutron, does the server have ports attached\n\u003e 3. if so, do those ports have security groups\n\n\u003e I believe the port security enabled extension in neutron is \u003e just that, an extension, which I think means it\u0027s \n\u003e technically optional, so even if you create a server with \n\u003e ports attached they technically might not have security \n\u003e groups applied.\n\n\u003e I don\u0027t think we want to get into those details here in the \n\u003e API guide.\n\nI am ok.","commit_id":"94f3294d06564cc95fcb9465d7599f4c7854187c"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"3229ab2d10985e691b2447c677258fefc4c20458","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  - tenant_id: The tenant_id to which the server belongs to."},{"line_number":69,"context_line":"  - created: The time of server creation."},{"line_number":70,"context_line":"  - links: Links to the servers in question."},{"line_number":71,"context_line":"  - security_groups: One or more security groups. (Optional)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  A sample response for a GET /servers/details request that includes"},{"line_number":74,"context_line":"  one result each from an unreachable and a healthy part of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_3099cf1e","line":71,"range":{"start_line":71,"start_character":50,"end_line":71,"end_character":60},"in_reply_to":"3fa7e38b_f5aec996","updated":"2019-10-04 14:22:51.000000000","message":"I agree with Matt here, we don\u0027t want too much info about the keys anyways. This part of the doc is to just give a heads-up to the expected list of keys so that the user is not surprised. The addition of the key lgtm.","commit_id":"94f3294d06564cc95fcb9465d7599f4c7854187c"}]}