)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd29b7799f53502ad30a03c3788a7f5c86bd5200","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Train code so they should be fairly reflective of what you\u0027d see in a"},{"line_number":12,"context_line":"real deployment."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that we also fix bugs seen with the mocks for \u0027create_port\u0027 and"},{"line_number":15,"context_line":"\u0027list_networks\u0027 neutron API functions. For the former, we weren\u0027t"},{"line_number":16,"context_line":"properly merging the request port details meaning we weren\u0027t setting"},{"line_number":17,"context_line":"some fields on the port, most significantly \u0027device_id\u0027. For the latter,"},{"line_number":18,"context_line":"it turns out it\u0027s possible to filter using a list of values and we"},{"line_number":19,"context_line":"weren\u0027t handling that. Both are resolved now."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also note that this effectively undoes a lot of the changes first"},{"line_number":22,"context_line":"introduced in Ibbee7fd11c1aa254e399d302adbae69126e98262, particularly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_dacb8ea2","line":19,"range":{"start_line":14,"start_character":0,"end_line":19,"end_character":45},"updated":"2019-10-08 09:57:40.000000000","message":"This is no longer true since I split these out into separate patches. Can edit assuming the rest of the patch makes sense","commit_id":"8428a7a096d3ed60ead35405aa3774990b2c8ee3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9cdcb5da5409fee1bce340a102985224c4f5ebf0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in Ibbee7fd11c1aa254e399d302adbae69126e98262, particularly around the"},{"line_number":16,"context_line":"responses for instances in a down cell, where we previously changed"},{"line_number":17,"context_line":"things so a \u0027security_groups\u0027 field was present in the response. This"},{"line_number":18,"context_line":"is okay since we\u0027re not creating interfaces and therefore don\u0027t expect"},{"line_number":19,"context_line":"to have security groups present."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I3c94b61fc323fefbd1c8790c4a2f60cada29e86f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_6937f6b1","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":43},"updated":"2019-10-11 14:39:51.000000000","message":"Do you mean that the test create servers without network interfaces?","commit_id":"ce84c7d01440bb1565a81d9780226e34e05e8edb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d2a8c663ee85439ad4e008b9048faf387f6d58d0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in Ibbee7fd11c1aa254e399d302adbae69126e98262, particularly around the"},{"line_number":16,"context_line":"responses for instances in a down cell, where we previously changed"},{"line_number":17,"context_line":"things so a \u0027security_groups\u0027 field was present in the response. This"},{"line_number":18,"context_line":"is okay since we\u0027re not creating interfaces and therefore don\u0027t expect"},{"line_number":19,"context_line":"to have security groups present."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I3c94b61fc323fefbd1c8790c4a2f60cada29e86f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_290b3ed5","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":43},"in_reply_to":"3fa7e38b_6937f6b1","updated":"2019-10-11 14:47:04.000000000","message":"Yup, exactly","commit_id":"ce84c7d01440bb1565a81d9780226e34e05e8edb"}],"nova/tests/fixtures.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9cdcb5da5409fee1bce340a102985224c4f5ebf0","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"        \u0027id\u0027: \u0027aec9df91-db1f-4e04-8ac6-e761d8461c53\u0027,"},{"line_number":1259,"context_line":"        \u0027name\u0027: \u0027default\u0027,"},{"line_number":1260,"context_line":"        \u0027description\u0027: \u0027Default security group\u0027,"},{"line_number":1261,"context_line":"        \u0027tenant_id\u0027: tenant_id,"},{"line_number":1262,"context_line":"        \u0027project_id\u0027: tenant_id,"},{"line_number":1263,"context_line":"        \u0027security_group_rules\u0027: [],  # setup later"},{"line_number":1264,"context_line":"    }"},{"line_number":1265,"context_line":"    security_group_rule_ip4_ingress \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_8e1fd86a","line":1262,"range":{"start_line":1261,"start_character":1,"end_line":1262,"end_character":32},"updated":"2019-10-11 14:39:51.000000000","message":"Feels strange but neutron does return both for me too.","commit_id":"ce84c7d01440bb1565a81d9780226e34e05e8edb"}]}