)]}'
{"nova/api/openstack/compute/quota_classes.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b9abf685460a6e741ef3fdf75f59bb0670cc363f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# NOTE(gmann): Network related quotas are filter out in"},{"line_number":36,"context_line":"# microversion 2.50. Bug#1701211."},{"line_number":37,"context_line":"FILTERED_QUOTAS_2_50 \u003d [\"fixed_ips\", \"floating_ips\","},{"line_number":38,"context_line":"                        \"security_group_rules\", \"security_groups\"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Microversion 2.57 removes personality (injected) files from the API."},{"line_number":41,"context_line":"FILTERED_QUOTAS_2_57 \u003d list(FILTERED_QUOTAS_2_50)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_29fa5e76","line":38,"updated":"2019-11-20 02:31:31.000000000","message":"Note that the rest of these can be removed too with the removal of nova-network. The relevant changes were:\n\nsecurity_group_rules https://review.opendev.org/477700\nfloating_ips https://review.opendev.org/457862\nfixed_ips https://review.opendev.org/457861\nsecurity_groups https://review.opendev.org/457860","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b1ac7c198efdd66d0361be69505760dbe70beeda","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# NOTE(gmann): Network related quotas are filter out in"},{"line_number":36,"context_line":"# microversion 2.50. Bug#1701211."},{"line_number":37,"context_line":"FILTERED_QUOTAS_2_50 \u003d [\"fixed_ips\", \"floating_ips\","},{"line_number":38,"context_line":"                        \"security_group_rules\", \"security_groups\"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Microversion 2.57 removes personality (injected) files from the API."},{"line_number":41,"context_line":"FILTERED_QUOTAS_2_57 \u003d list(FILTERED_QUOTAS_2_50)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_a20ec7e1","line":38,"in_reply_to":"3fa7e38b_29fa5e76","updated":"2019-12-02 18:11:37.000000000","message":"Will do","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"}],"nova/api/openstack/compute/quota_sets.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a9ff80cf602531fea731938ced9f86b8aac076f1","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        quota_set \u003d body[\u0027quota_set\u0027]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # NOTE(stephenfin): network quotas were only used by nova-network and"},{"line_number":198,"context_line":"        # therefore should be explicitly rejected"},{"line_number":199,"context_line":"        if \u0027networks\u0027 in quota_set:"},{"line_number":200,"context_line":"            raise webob.exc.HTTPBadRequest("},{"line_number":201,"context_line":"                explanation\u003d_(\u0027The networks quota has been removed\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_5f3f1a21","line":198,"updated":"2019-11-22 15:35:12.000000000","message":"I was thinking about updating the API reference for this:\n\nhttps://docs.openstack.org/api-ref/compute/?expanded\u003dupdate-quotas-detail#update-quotas\n\nbut networks is already optional and we don\u0027t want to require a microversion to not use it (remove it from the schema I mean). I\u0027m not sure if it would be useful to add a note in the API reference that this is rejected starting in 21.0.0 Ussuri since the API user doesn\u0027t necessarily know the version of nova on the cloud they are using, they only have microversions. So this will either work or it won\u0027t, but since quota updates are admin-only by default it\u0027s likely not a concern for non-admins anyway.","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0efaa9c7e64c848d63c971ae14ddd7d2e8eec8fd","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        quota_set \u003d body[\u0027quota_set\u0027]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # NOTE(stephenfin): network quotas were only used by nova-network and"},{"line_number":198,"context_line":"        # therefore should be explicitly rejected"},{"line_number":199,"context_line":"        if \u0027networks\u0027 in quota_set:"},{"line_number":200,"context_line":"            raise webob.exc.HTTPBadRequest("},{"line_number":201,"context_line":"                explanation\u003d_(\u0027The networks quota has been removed\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_60459614","line":198,"in_reply_to":"3fa7e38b_5f3f1a21","updated":"2019-11-22 16:47:19.000000000","message":"I think a note here would be good but stephenfin\u0027s already updated again :P Maybe a followup?","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"}],"nova/api/openstack/compute/schemas/quota_sets.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a9ff80cf602531fea731938ced9f86b8aac076f1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \u0027server_group_members\u0027: common_quota,"},{"line_number":44,"context_line":"    # NOTE(stephenfin): This will always be rejected since it was nova-network"},{"line_number":45,"context_line":"    # only, but we need to allow users to submit it at a minimum"},{"line_number":46,"context_line":"    \u0027networks\u0027: common_quota"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"update_quota_set \u003d copy.deepcopy(quota_resources)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_bf308e56","line":46,"updated":"2019-11-22 15:35:12.000000000","message":"This still shows up in the docs https://docs.openstack.org/nova/latest/admin/quotas.html - it\u0027s valid for pre-Ussuri but not after Ussuri. Should we update that doc to mention it\u0027s no longer valid starting in 21.0.0 (Ussuri)?","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0efaa9c7e64c848d63c971ae14ddd7d2e8eec8fd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \u0027server_group_members\u0027: common_quota,"},{"line_number":44,"context_line":"    # NOTE(stephenfin): This will always be rejected since it was nova-network"},{"line_number":45,"context_line":"    # only, but we need to allow users to submit it at a minimum"},{"line_number":46,"context_line":"    \u0027networks\u0027: common_quota"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"update_quota_set \u003d copy.deepcopy(quota_resources)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_80c77298","line":46,"in_reply_to":"3fa7e38b_bf308e56","updated":"2019-11-22 16:47:19.000000000","message":"I dunno, what about this sentence on the doc?\n\n\"The following quotas were previously available but were removed in microversion 2.36 as they proxied information available from the networking service.\"\n\nNetworks is under that, implying that it\u0027s been removed since 2.36 (it wasn\u0027t, but that\u0027s what it says already).\n\nMy point being, does that cover it?","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"}],"releasenotes/notes/remove-nova-network-c02953ba72a1795d.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"be58372c5ac99a89e73790d78b1be7030f5a66fd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    The ``networks`` quota, which was only enabled if the"},{"line_number":30,"context_line":"    ``enabled_network_quota`` config option was enabled and only useful with"},{"line_number":31,"context_line":"    *neutron-network*, is removed. It will not longer be present in the"},{"line_number":32,"context_line":"    responses for the APIs while attempts to update the quota will be rejected."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    * ``GET /os-quota-sets``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_b7b7b285","line":31,"range":{"start_line":31,"start_character":5,"end_line":31,"end_character":12},"updated":"2019-11-15 15:39:42.000000000","message":"nova","commit_id":"78b6581c315b65c03991f27f893ff157bed2c86f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a61b7c9963e3b9b7dcbdf8bcb873ebdf65a20000","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    The ``networks`` quota, which was only enabled if the"},{"line_number":30,"context_line":"    ``enabled_network_quota`` config option was enabled and only useful with"},{"line_number":31,"context_line":"    *neutron-network*, is removed. It will not longer be present in the"},{"line_number":32,"context_line":"    responses for the APIs while attempts to update the quota will be rejected."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    * ``GET /os-quota-sets``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_ffb7e6d6","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":21},"updated":"2019-11-22 15:27:03.000000000","message":"oops - nova-network silly pants","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46745e4522c88b3788438e8c25f1d3f3dfbb34ce","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    The ``networks`` quota, which was only enabled if the"},{"line_number":30,"context_line":"    ``enabled_network_quota`` config option was enabled and only useful with"},{"line_number":31,"context_line":"    *neutron-network*, is removed. It will not longer be present in the"},{"line_number":32,"context_line":"    responses for the APIs while attempts to update the quota will be rejected."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    * ``GET /os-quota-sets``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_3afeecae","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":21},"in_reply_to":"3fa7e38b_1ff3e274","updated":"2019-11-22 17:19:01.000000000","message":"Done","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bff2109b4455dae5d01b1d05fd6efea031e737f1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    The ``networks`` quota, which was only enabled if the"},{"line_number":30,"context_line":"    ``enabled_network_quota`` config option was enabled and only useful with"},{"line_number":31,"context_line":"    *neutron-network*, is removed. It will not longer be present in the"},{"line_number":32,"context_line":"    responses for the APIs while attempts to update the quota will be rejected."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    * ``GET /os-quota-sets``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_1ff3e274","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":21},"in_reply_to":"3fa7e38b_ffb7e6d6","updated":"2019-11-22 15:41:05.000000000","message":"Ah, dangit!! I missed this, I am ashamed.","commit_id":"c71f4958c8b6d113a1b73ebac1fbdc306dc09b95"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b706c07ef78fe33cd8f54ae5f8ae27b5cf7a7bcd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - |"},{"line_number":29,"context_line":"    The ``networks`` quota, which was only enabled if the"},{"line_number":30,"context_line":"    ``enabled_network_quota`` config option was enabled and only useful with"},{"line_number":31,"context_line":"    *nova-network*, which has been removed. It will not longer be present in"},{"line_number":32,"context_line":"    the responses for the APIs while attempts to update the quota will be"},{"line_number":33,"context_line":"    rejected."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_40697abb","line":31,"range":{"start_line":31,"start_character":20,"end_line":31,"end_character":34},"updated":"2019-11-22 16:40:45.000000000","message":"This should go back to \"is\" like in PS7. You changed this b/c you\u0027re saying nova-network has been removed (at the end of this series) but the context of this sentence is saying the \u0027networks\u0027 quota is removed.","commit_id":"65f77cb18b88476c40a12a55113674acc6e4854e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0efaa9c7e64c848d63c971ae14ddd7d2e8eec8fd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    The ``networks`` quota, which was only enabled if the"},{"line_number":30,"context_line":"    ``enabled_network_quota`` config option was enabled and only useful with"},{"line_number":31,"context_line":"    *nova-network*, which has been removed. It will not longer be present in"},{"line_number":32,"context_line":"    the responses for the APIs while attempts to update the quota will be"},{"line_number":33,"context_line":"    rejected."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * ``GET /os-quota-sets``"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_2088fe68","line":32,"range":{"start_line":32,"start_character":31,"end_line":32,"end_character":36},"updated":"2019-11-22 16:47:19.000000000","message":"What about this? I\u0027m having trouble parsing this for some reason. Does this mean \"and\" here?","commit_id":"65f77cb18b88476c40a12a55113674acc6e4854e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6cd6096e3472a56713a7b4a61acedca56561684","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    * ``GET /os-quota-sets/{project_id}``"},{"line_number":36,"context_line":"    * ``GET /os-quota-sets/{project_id}/defaults``"},{"line_number":37,"context_line":"    * ``GET /os-quota-sets/{project_id}/detail``"},{"line_number":38,"context_line":"    * ``PUT /os-quota-sets/{project_id}``"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The following related config options have been removed."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_4073ba80","line":38,"updated":"2019-11-22 16:48:10.000000000","message":"You\u0027re missing os-quota-class-sets:\n\nhttps://docs.openstack.org/api-ref/compute/#quota-class-sets-os-quota-class-sets\n\nGET /os-quota-class-sets/{id}\n\nPUT /os-quota-class-sets/{id}","commit_id":"ca4e33aed8dc09f337e31c5e74dee7eef7745ffd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46745e4522c88b3788438e8c25f1d3f3dfbb34ce","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    * ``GET /os-quota-sets/{project_id}``"},{"line_number":36,"context_line":"    * ``GET /os-quota-sets/{project_id}/defaults``"},{"line_number":37,"context_line":"    * ``GET /os-quota-sets/{project_id}/detail``"},{"line_number":38,"context_line":"    * ``PUT /os-quota-sets/{project_id}``"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The following related config options have been removed."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_20f9dec3","line":38,"in_reply_to":"3fa7e38b_4073ba80","updated":"2019-11-22 17:19:01.000000000","message":"Oh yeah. Also done.","commit_id":"ca4e33aed8dc09f337e31c5e74dee7eef7745ffd"}]}