)]}'
{"nova/tests/functional/libvirt/base.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5980c1d4c492f82718121616eaebe51021c4e97d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            hostname\u003dhostname)"},{"line_number":115,"context_line":"        return fake_connection"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _start_heterogeneous_computes(self, host_info_dict):"},{"line_number":118,"context_line":"        self.computes \u003d {}"},{"line_number":119,"context_line":"        for host, host_info in host_info_dict.items():"},{"line_number":120,"context_line":"            fake_connection \u003d self._get_connection(host_info\u003dhost_info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_30ec138e","line":117,"range":{"start_line":117,"start_character":44,"end_line":117,"end_character":58},"updated":"2019-10-10 14:35:04.000000000","message":"Could we default this to None and default to a two-node guest with the same host_info for both. If you look at \u0027test_numa_topology\u0027, you\u0027ll note that almost all of them contain the exact same \u0027host_info\u0027 definition, so it would be a shame not to be able to DRY those up here","commit_id":"72d4101ba390a29ebc989fd3775349c395b4c446"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5980c1d4c492f82718121616eaebe51021c4e97d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            hostname\u003dhostname)"},{"line_number":115,"context_line":"        return fake_connection"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _start_heterogeneous_computes(self, host_info_dict):"},{"line_number":118,"context_line":"        self.computes \u003d {}"},{"line_number":119,"context_line":"        for host, host_info in host_info_dict.items():"},{"line_number":120,"context_line":"            fake_connection \u003d self._get_connection(host_info\u003dhost_info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_b070030a","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":37},"updated":"2019-10-10 14:35:04.000000000","message":"I\u0027m not sold on the name. There\u0027s no reason these have to be heterogeneous. In fact, most of the tests that do something like this use the same \u0027host_info\u0027 for multiple instances. how about \u0027start_computes\u0027 (not private, since we\u0027re using way too many of those things here for no good reason)","commit_id":"72d4101ba390a29ebc989fd3775349c395b4c446"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"65b758e7a9b34345547a0338f58ebc8cfe0062bc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            hostname\u003dhostname)"},{"line_number":115,"context_line":"        return fake_connection"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _start_heterogeneous_computes(self, host_info_dict):"},{"line_number":118,"context_line":"        self.computes \u003d {}"},{"line_number":119,"context_line":"        for host, host_info in host_info_dict.items():"},{"line_number":120,"context_line":"            fake_connection \u003d self._get_connection(host_info\u003dhost_info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_b4be9762","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":37},"in_reply_to":"3fa7e38b_b070030a","updated":"2019-10-16 17:24:49.000000000","message":"Done and done.","commit_id":"72d4101ba390a29ebc989fd3775349c395b4c446"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"79ac4653b9e37761585653b203c9cf466f70f336","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            hostname\u003dhostname)"},{"line_number":115,"context_line":"        return fake_connection"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def start_computes(self, host_info_dict\u003dNone, save_rp_uuids\u003dFalse):"},{"line_number":118,"context_line":"        \"\"\"Start compute services. The started services will be saved in"},{"line_number":119,"context_line":"        self.computes, keyed by hostname."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_e86d5d03","line":117,"range":{"start_line":117,"start_character":27,"end_line":117,"end_character":69},"updated":"2019-11-14 17:42:27.000000000","message":"Taking this patch in isolation, it is not clear why these are necessary. Arguably they (and their respective logic) should be added in the subsequent patch where they are first used. But if not, the commit message ought to at least make mention that they\u0027re there for \"a subsequent patch\".","commit_id":"607307c1d8a5a7fbcae96ddbb4cf8e944f46f42b"}]}