)]}'
{"nova/tests/functional/libvirt/test_numa_live_migration.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d39df745be102d41e7bbdbcbc66fe431b02e2b29","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        \"\"\""},{"line_number":330,"context_line":"        self._assert_has_migration_context(self.server2[\u0027id\u0027])"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        # During the migration, the 2-vPCU instance and its migration are"},{"line_number":333,"context_line":"        # consuming pinned CPUs on both source and dest, so we expect all pCPUs"},{"line_number":334,"context_line":"        # to be consumed."},{"line_number":335,"context_line":"        host3_topo \u003d self._get_host_numa_topology(\u0027host3\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_96445f75","line":332,"range":{"start_line":332,"start_character":38,"end_line":332,"end_character":42},"updated":"2020-01-14 11:39:37.000000000","message":"vPCU? what is that ment to stand for? it confusing","commit_id":"db234728efd35a4a92244b6b5991dfbea2e07ee6"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4aae2d8baae4feb0d738fec4cc944d5304013fc2","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        \"\"\""},{"line_number":330,"context_line":"        self._assert_has_migration_context(self.server2[\u0027id\u0027])"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        # During the migration, the 2-vPCU instance and its migration are"},{"line_number":333,"context_line":"        # consuming pinned CPUs on both source and dest, so we expect all pCPUs"},{"line_number":334,"context_line":"        # to be consumed."},{"line_number":335,"context_line":"        host3_topo \u003d self._get_host_numa_topology(\u0027host3\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_55155de5","line":332,"range":{"start_line":332,"start_character":38,"end_line":332,"end_character":42},"in_reply_to":"3fa7e38b_96445f75","updated":"2020-01-15 18:02:26.000000000","message":"vCPU :) Fixed.","commit_id":"db234728efd35a4a92244b6b5991dfbea2e07ee6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b86f274ca3020af3bf723f5cd35635a8c5cb417","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    def test_numa_live_migration_dest_pinned(self):"},{"line_number":262,"context_line":"        self._test(pin_dest\u003dTrue)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_bug_1843639(self):"},{"line_number":265,"context_line":"        orig_live_migration \u003d \\"},{"line_number":266,"context_line":"            compute_manager.ComputeManager.live_migration"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1f493fa4_ae41de3b","line":264,"updated":"2020-04-28 14:18:49.000000000","message":"Could we get a docstring suggesting what this is testing? Basically, what you have in the commit message","commit_id":"32713a4fe885ee55ef0fefc8ce6c78877f2f03e7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7cb0e0e5e7bb917ffaaa0086e77ae899186846f7","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    def test_numa_live_migration_dest_pinned(self):"},{"line_number":262,"context_line":"        self._test(pin_dest\u003dTrue)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_bug_1843639(self):"},{"line_number":265,"context_line":"        orig_live_migration \u003d \\"},{"line_number":266,"context_line":"            compute_manager.ComputeManager.live_migration"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1f493fa4_967307e7","line":264,"in_reply_to":"1f493fa4_ae41de3b","updated":"2020-05-01 18:21:34.000000000","message":"Done","commit_id":"32713a4fe885ee55ef0fefc8ce6c78877f2f03e7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2b86f274ca3020af3bf723f5cd35635a8c5cb417","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        self._test(pin_dest\u003dTrue)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_bug_1843639(self):"},{"line_number":265,"context_line":"        orig_live_migration \u003d \\"},{"line_number":266,"context_line":"            compute_manager.ComputeManager.live_migration"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        def live_migration(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f493fa4_6e54f6fe","line":265,"range":{"start_line":265,"start_character":30,"end_line":265,"end_character":31},"updated":"2020-04-28 14:18:49.000000000","message":"nit: unnecessary","commit_id":"32713a4fe885ee55ef0fefc8ce6c78877f2f03e7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7cb0e0e5e7bb917ffaaa0086e77ae899186846f7","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        self._test(pin_dest\u003dTrue)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_bug_1843639(self):"},{"line_number":265,"context_line":"        orig_live_migration \u003d \\"},{"line_number":266,"context_line":"            compute_manager.ComputeManager.live_migration"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        def live_migration(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f493fa4_b66e032c","line":265,"range":{"start_line":265,"start_character":30,"end_line":265,"end_character":31},"in_reply_to":"1f493fa4_6e54f6fe","updated":"2020-05-01 18:21:34.000000000","message":"Done","commit_id":"32713a4fe885ee55ef0fefc8ce6c78877f2f03e7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"88825363eaac884c52bfcf4be45ca92d3b656304","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            # while all 4 of host_b\u0027s CPU are consumed by server_b and the"},{"line_number":272,"context_line":"            # incoming # migration."},{"line_number":273,"context_line":"            self._assert_host_consumed_cpus(\u0027host_a\u0027, [0, 1])"},{"line_number":274,"context_line":"            self._assert_host_consumed_cpus(\u0027host_b\u0027, [0, 1, 2, 3])"},{"line_number":275,"context_line":"            return orig_live_migration(*args, **kwargs)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.useFixture(fixtures.MonkeyPatch("}],"source_content_type":"text/x-python","patch_set":20,"id":"1f493fa4_6e102901","line":274,"updated":"2020-05-01 14:00:16.000000000","message":"I didn\u0027t mention this in the other patch, but assertions like this buried deep are easy to miss and not realize, so it\u0027s always nice to have some sort of assert-this-ran thing in addition to the assertions inside. I\u0027m guessing that _test() confirms enough to be sure that orig_live_migration() ran and did stuff, but if the monkeypatch didn\u0027t hit the right thing, it\u0027d be easy for these to not be run and not realize it.\n\nAlso, based on the commit message, it sounds like you should assert that the migration is in the state you expect it to be here, just in case the machinery outside this test changes?","commit_id":"32713a4fe885ee55ef0fefc8ce6c78877f2f03e7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7cb0e0e5e7bb917ffaaa0086e77ae899186846f7","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            # while all 4 of host_b\u0027s CPU are consumed by server_b and the"},{"line_number":272,"context_line":"            # incoming # migration."},{"line_number":273,"context_line":"            self._assert_host_consumed_cpus(\u0027host_a\u0027, [0, 1])"},{"line_number":274,"context_line":"            self._assert_host_consumed_cpus(\u0027host_b\u0027, [0, 1, 2, 3])"},{"line_number":275,"context_line":"            return orig_live_migration(*args, **kwargs)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.useFixture(fixtures.MonkeyPatch("}],"source_content_type":"text/x-python","patch_set":20,"id":"1f493fa4_36331316","line":274,"in_reply_to":"1f493fa4_6e102901","updated":"2020-05-01 18:21:34.000000000","message":"Done and done.","commit_id":"32713a4fe885ee55ef0fefc8ce6c78877f2f03e7"}]}