)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6961b6c22d71261b9736c084e965d82c841bf541","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If qemu guest agent is not reponsive when setting admin password,"},{"line_number":10,"context_line":"an InternalError will be thrown by nova,"},{"line_number":11,"context_line":"then the VM state will be set to ERROR."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Actually we did nothing to VMs as qga did not answer our request,"},{"line_number":14,"context_line":"such as qga is crashed/halt, etc."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_2513e503","line":11,"updated":"2019-12-17 17:29:27.000000000","message":"Where does this happen in the ComputeManager code in Pike?\n\n(later)\n\nOK this was true when the original change was made in queens:\n\nhttps://review.opendev.org/#/c/523828/3/nova/compute/manager.py@3465\n\nBut is no longer true in Pike (or queens for that matter):\n\nhttps://review.opendev.org/#/q/If1c901b974bc7295927b3f033a04eaa6ac36f603\n\nSo how much do we care about this fix anymore?","commit_id":"ea6e13537e2613bf545bd6b1b5f8dc0fffd63b58"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6961b6c22d71261b9736c084e965d82c841bf541","unresolved":false,"context_lines":[{"line_number":15,"context_line":"In this kind of senario, libvirt will throw VIR_ERR_AGENT_UNRESPONSIVE"},{"line_number":16,"context_line":"to us by an error code."},{"line_number":17,"context_line":"We should check the error code return by libvirt and"},{"line_number":18,"context_line":"throw a NotImplementedError, which we\u0027ve already expected"},{"line_number":19,"context_line":"in compute.manager."},{"line_number":20,"context_line":"Other cases like qga got our request"},{"line_number":21,"context_line":"but failed to do its work should follow what we used to."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_a5dcb545","line":19,"range":{"start_line":18,"start_character":29,"end_line":19,"end_character":19},"updated":"2019-12-17 17:29:27.000000000","message":"Confirmed:\n\nhttps://github.com/openstack/nova/blob/stable/pike/nova/compute/manager.py#L3434","commit_id":"ea6e13537e2613bf545bd6b1b5f8dc0fffd63b58"}]}