)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32faafb4bca799b1bacd31aef60bd5bade0bd64a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove \u0027nova-xvpvncproxy\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This legacy service is no longer used and was deprecated during the"},{"line_number":10,"context_line":"Train cycle. It\u0027s time to say adios and remove them in their entirety."},{"line_number":11,"context_line":"This is pretty straightforward, with the sole exception of schema for"},{"line_number":12,"context_line":"the \u0027remote-consoles\u0027 API, which has to continue supporting requests for"},{"line_number":13,"context_line":"type \u0027xvpvnc\u0027 even if we can\u0027t fulfil those requests now."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_0afc7b70","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"updated":"2019-12-20 21:22:57.000000000","message":"https://review.opendev.org/#/c/687909/11/doc/source/admin/remote-console-access.rst says Stein and https://review.opendev.org/#/c/610076/ confirms it.","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a6eef7fb36b7d25b04f9d20e3dec28a87e774955","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove \u0027nova-xvpvncproxy\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This legacy service is no longer used and was deprecated during the"},{"line_number":10,"context_line":"Train cycle. It\u0027s time to say adios and remove them in their entirety."},{"line_number":11,"context_line":"This is pretty straightforward, with the sole exception of schema for"},{"line_number":12,"context_line":"the \u0027remote-consoles\u0027 API, which has to continue supporting requests for"},{"line_number":13,"context_line":"type \u0027xvpvnc\u0027 even if we can\u0027t fulfil those requests now."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_0891d9f7","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"in_reply_to":"3fa7e38b_0afc7b70","updated":"2019-12-23 14:18:58.000000000","message":"Done","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"}],"api-guide/source/server_concepts.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32faafb4bca799b1bacd31aef60bd5bade0bd64a","unresolved":false,"context_lines":[{"line_number":787,"context_line":"user can use ``novnc``, ``rdp-html5``, ``spice-html5``, ``serial``, and"},{"line_number":788,"context_line":"``webmks`` (starting from microversion 2.8) through either the OpenStack"},{"line_number":789,"context_line":"dashboard or the command line. Refer to :nova-doc:`Configure remote console"},{"line_number":790,"context_line":"access \u003cadmin/remote-console-access.html\u003e`.  Specifically for Xenserver, it"},{"line_number":791,"context_line":"provides the ability to create, delete, detail, list specified server VNC"},{"line_number":792,"context_line":"consoles."},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"Server networks"},{"line_number":795,"context_line":"~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fa7e38b_ca9e6354","line":792,"range":{"start_line":790,"start_character":45,"end_line":792,"end_character":9},"updated":"2019-12-20 21:22:57.000000000","message":"Hmm, I wonder why the API guide is specifically mentioning xenserver here. There is not really any great reason that the end user of the compute service needs to know if they are getting a VM on a xenserver host or a kvm host. I\u0027d say we remove this in a follow up.","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a6eef7fb36b7d25b04f9d20e3dec28a87e774955","unresolved":false,"context_lines":[{"line_number":787,"context_line":"user can use ``novnc``, ``rdp-html5``, ``spice-html5``, ``serial``, and"},{"line_number":788,"context_line":"``webmks`` (starting from microversion 2.8) through either the OpenStack"},{"line_number":789,"context_line":"dashboard or the command line. Refer to :nova-doc:`Configure remote console"},{"line_number":790,"context_line":"access \u003cadmin/remote-console-access.html\u003e`.  Specifically for Xenserver, it"},{"line_number":791,"context_line":"provides the ability to create, delete, detail, list specified server VNC"},{"line_number":792,"context_line":"consoles."},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"Server networks"},{"line_number":795,"context_line":"~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fa7e38b_c89ae111","line":792,"range":{"start_line":790,"start_character":45,"end_line":792,"end_character":9},"in_reply_to":"3fa7e38b_ca9e6354","updated":"2019-12-23 14:18:58.000000000","message":"I just dropped this since its no longer really true anyway (there doesn\u0027t appear to be anything XenServer-specific about  this API now)","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"}],"api-ref/source/servers-action-remote-consoles.inc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32faafb4bca799b1bacd31aef60bd5bade0bd64a","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Specify the ``os-getVNCConsole`` action in the request body."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"The supported connection types are: ``novnc``. For example, to connect"},{"line_number":179,"context_line":"with ``novnc``, set ``type`` parameter to ``novnc``."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Normal response codes: 200"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3fa7e38b_8ad62bf2","line":179,"range":{"start_line":178,"start_character":0,"end_line":179,"end_character":52},"updated":"2019-12-20 21:22:57.000000000","message":"I\u0027d just remove this paragraph. The description of the type parameter explains that the only valid value is novnc so this is redundant and \"types\" being plural here is weird now.\n\nCould be done in a FUP though or if you need to respin.","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a6eef7fb36b7d25b04f9d20e3dec28a87e774955","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Specify the ``os-getVNCConsole`` action in the request body."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"The supported connection types are: ``novnc``. For example, to connect"},{"line_number":179,"context_line":"with ``novnc``, set ``type`` parameter to ``novnc``."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Normal response codes: 200"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"3fa7e38b_e89d5d09","line":179,"range":{"start_line":178,"start_character":0,"end_line":179,"end_character":52},"in_reply_to":"3fa7e38b_8ad62bf2","updated":"2019-12-23 14:18:58.000000000","message":"Done","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"}],"nova/console/xvp.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32faafb4bca799b1bacd31aef60bd5bade0bd64a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import signal"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import jinja2"},{"line_number":22,"context_line":"from oslo_concurrency import processutils"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_ea1ebfba","side":"PARENT","line":21,"updated":"2019-12-20 21:22:57.000000000","message":"Can we also remove our requirement on Jinja2 now?\n\nI guess not because of the nova-net network template stuff that\u0027s not yet removed:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/netutils.py\n\nMake a mental note to remove the requirement when that is gone.","commit_id":"56fc3f28e48bd9c6faf72d2a8bfdf520cc3e60d0"}],"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32faafb4bca799b1bacd31aef60bd5bade0bd64a","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    project_id \u003d Column(String(255))"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"# TODO(stephenfin): Remove in V or later"},{"line_number":989,"context_line":"class ConsolePool(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":990,"context_line":"    \"\"\"Represents pool of consoles on the same physical node.\"\"\""},{"line_number":991,"context_line":"    __tablename__ \u003d \u0027console_pools\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_ea4c7fca","line":988,"range":{"start_line":988,"start_character":31,"end_line":988,"end_character":40},"updated":"2019-12-20 21:22:57.000000000","message":"Yeah...gotta drop the table in N and then the model in N+1 I think per our discussion with dansmith a couple of weeks ago.","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32faafb4bca799b1bacd31aef60bd5bade0bd64a","unresolved":false,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"# TODO(stephenfin): Remove in V or later"},{"line_number":989,"context_line":"class ConsolePool(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":990,"context_line":"    \"\"\"Represents pool of consoles on the same physical node.\"\"\""},{"line_number":991,"context_line":"    __tablename__ \u003d \u0027console_pools\u0027"},{"line_number":992,"context_line":"    __table_args__ \u003d ("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_2a5b7786","line":989,"updated":"2019-12-20 21:22:57.000000000","message":"I was thinking this wasn\u0027t specific to xvp but apparently it is:\n\nhttps://review.opendev.org/#/c/687909/11/nova/console/xvp.py@a79","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"}],"releasenotes/notes/remove-nova-xvpvncproxy-1c189cdff4b133e8.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32faafb4bca799b1bacd31aef60bd5bade0bd64a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``nova-console`` and ``nova-xvpvncproxy`` services have been deprecated"},{"line_number":5,"context_line":"    since the 19.0.0 Stein release and have now been removed. The following"},{"line_number":6,"context_line":"    configuration options have also been removed:"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_ca3ae333","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":24},"updated":"2019-12-20 21:22:57.000000000","message":"I think you can remove this...","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32faafb4bca799b1bacd31aef60bd5bade0bd64a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * ``[xvp] console_xvp_multiplex_port``"},{"line_number":15,"context_line":"    * ``[xvp] console_xvp_pid``"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    In addition, the following APIs have been removed. Calling these APIs will"},{"line_number":18,"context_line":"    now result in a ``410 HTTPGone`` error response:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * ``POST /servers/{server_uuid}/consoles``"},{"line_number":21,"context_line":"    * ``GET /servers/{server_uuid}/consoles``"},{"line_number":22,"context_line":"    * ``GET /servers/{server_uuid}/consoles/{console_id}``"},{"line_number":23,"context_line":"    * ``DELETE /servers/{server_uuid}/consoles/{console_id}``"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_8a44ebb9","line":23,"range":{"start_line":17,"start_character":4,"end_line":23,"end_character":61},"updated":"2019-12-20 21:22:57.000000000","message":"...and these because you already documented those when removing nova-console:\n\nhttps://docs.openstack.org/releasenotes/nova/unreleased.html#upgrade-notes","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a6eef7fb36b7d25b04f9d20e3dec28a87e774955","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * ``[xvp] console_xvp_multiplex_port``"},{"line_number":15,"context_line":"    * ``[xvp] console_xvp_pid``"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    In addition, the following APIs have been removed. Calling these APIs will"},{"line_number":18,"context_line":"    now result in a ``410 HTTPGone`` error response:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * ``POST /servers/{server_uuid}/consoles``"},{"line_number":21,"context_line":"    * ``GET /servers/{server_uuid}/consoles``"},{"line_number":22,"context_line":"    * ``GET /servers/{server_uuid}/consoles/{console_id}``"},{"line_number":23,"context_line":"    * ``DELETE /servers/{server_uuid}/consoles/{console_id}``"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_a8a8c520","line":23,"range":{"start_line":17,"start_character":4,"end_line":23,"end_character":61},"in_reply_to":"3fa7e38b_8a44ebb9","updated":"2019-12-23 14:18:58.000000000","message":"Weird. Not sure why I had this here. Must be an artifact from an early rebase","commit_id":"c352b8660f925cf58a031d9d8f6cf7548304bc17"}]}