)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf1f0ea238b3244e3e6aabfd9201352971944d6d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Needed changes in test_init_host.py compared to Queens:"},{"line_number":20,"context_line":"* The restart_compute_service() method needed to be added to the"},{"line_number":21,"context_line":"  functional test class because change"},{"line_number":22,"context_line":"  I17f67a02b27a90658df48856963ea3fb327e81dc is not in Pike."},{"line_number":23,"context_line":"* The last assert, self.assertNotIn(server[\u0027id\u0027], source_allocations),"},{"line_number":24,"context_line":"  in the functional reproduce does not fails so it is removed."},{"line_number":25,"context_line":"  The rest of the test asserts still shows that at least part of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_be560205","line":22,"updated":"2019-12-17 19:54:47.000000000","message":"Rather than add restart_compute_service to test_init_host.py only, why not add it to the base test class like in this change?","commit_id":"36454ba1f785bc3c808a89a9ac46ec78551051ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7aac484ee807244a1e6d2485dbd5a17b8f770064","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Needed changes in test_init_host.py compared to Queens:"},{"line_number":20,"context_line":"* The restart_compute_service() method needed to be added to the"},{"line_number":21,"context_line":"  functional test class because change"},{"line_number":22,"context_line":"  I17f67a02b27a90658df48856963ea3fb327e81dc is not in Pike."},{"line_number":23,"context_line":"* The last assert, self.assertNotIn(server[\u0027id\u0027], source_allocations),"},{"line_number":24,"context_line":"  in the functional reproduce does not fails so it is removed."},{"line_number":25,"context_line":"  The rest of the test asserts still shows that at least part of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_de709eaa","line":22,"in_reply_to":"3fa7e38b_be560205","updated":"2019-12-17 19:56:32.000000000","message":"Actually we can just backport 63eb7fee1bf95a2e09b120358d79445893633270 since it\u0027s a clean cherry pick.","commit_id":"36454ba1f785bc3c808a89a9ac46ec78551051ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2f1f114e25ef302f3438eb077272325c4c17c444","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Needed changes in test_init_host.py compared to Queens:"},{"line_number":20,"context_line":"* The restart_compute_service() method needed to be added to the"},{"line_number":21,"context_line":"  functional test class because change"},{"line_number":22,"context_line":"  I17f67a02b27a90658df48856963ea3fb327e81dc is not in Pike."},{"line_number":23,"context_line":"* The last assert, self.assertNotIn(server[\u0027id\u0027], source_allocations),"},{"line_number":24,"context_line":"  in the functional reproduce does not fails so it is removed."},{"line_number":25,"context_line":"  The rest of the test asserts still shows that at least part of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_decc1ec0","line":22,"in_reply_to":"3fa7e38b_de709eaa","updated":"2019-12-17 20:06:59.000000000","message":"Done","commit_id":"36454ba1f785bc3c808a89a9ac46ec78551051ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3e9c9923050f94d8a50878f22b66b1caab13ac0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  functional test class because change"},{"line_number":22,"context_line":"  I17f67a02b27a90658df48856963ea3fb327e81dc is not in Pike."},{"line_number":23,"context_line":"* The last assert, self.assertNotIn(server[\u0027id\u0027], source_allocations),"},{"line_number":24,"context_line":"  in the functional reproduce does not fails so it is removed."},{"line_number":25,"context_line":"  The rest of the test asserts still shows that at least part of the"},{"line_number":26,"context_line":"  bug exists in pike."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_8375f135","line":24,"updated":"2019-12-17 19:32:40.000000000","message":"It would be nice to know *why* it doesn\u0027t fail but maybe not blocking or worth the effort in figuring it out. Lots of things changed with respect to resize/migrate and allocations between pike and queens because of the migration-based allocations work added in queens.","commit_id":"36454ba1f785bc3c808a89a9ac46ec78551051ea"}],"nova/tests/functional/compute/test_init_host.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3e9c9923050f94d8a50878f22b66b1caab13ac0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            \u0027/resource_providers/%s/allocations\u0027 % rp_uuid).body[\u0027allocations\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @staticmethod"},{"line_number":32,"context_line":"    def restart_compute_service(compute):"},{"line_number":33,"context_line":"        \"\"\"Restart a compute service in a realistic way."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param:compute: the nova-compute service to be restarted"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a356ed5d","line":32,"updated":"2019-12-17 19:32:40.000000000","message":"And this is:\n\nhttps://review.opendev.org/#/c/512551/1/nova/test.py","commit_id":"36454ba1f785bc3c808a89a9ac46ec78551051ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2f1f114e25ef302f3438eb077272325c4c17c444","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            \u0027/resource_providers/%s/allocations\u0027 % rp_uuid).body[\u0027allocations\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @staticmethod"},{"line_number":32,"context_line":"    def restart_compute_service(compute):"},{"line_number":33,"context_line":"        \"\"\"Restart a compute service in a realistic way."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param:compute: the nova-compute service to be restarted"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1ee1562c","line":32,"in_reply_to":"3fa7e38b_43513930","updated":"2019-12-17 20:06:59.000000000","message":"Done","commit_id":"36454ba1f785bc3c808a89a9ac46ec78551051ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"99717d44e8f6cf3b931414c87c23dfd3f04662c2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            \u0027/resource_providers/%s/allocations\u0027 % rp_uuid).body[\u0027allocations\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @staticmethod"},{"line_number":32,"context_line":"    def restart_compute_service(compute):"},{"line_number":33,"context_line":"        \"\"\"Restart a compute service in a realistic way."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param:compute: the nova-compute service to be restarted"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_43513930","line":32,"in_reply_to":"3fa7e38b_a356ed5d","updated":"2019-12-17 19:45:00.000000000","message":"Actually, given this is a staticmethod, can we just make it module-level? Then you don\u0027t need to define the same method in another class that does the same thing later in the series here:\n\nhttps://review.opendev.org/#/c/687917/2","commit_id":"36454ba1f785bc3c808a89a9ac46ec78551051ea"}]}