)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"664fd8b66fdf8b344434726f9888ba3d2f827650","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add regression test for bug 1824435"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a regression test in our post test hook. We are not able to"},{"line_number":10,"context_line":"do a similar test in the unit or functional tests because SQLite does"},{"line_number":11,"context_line":"not provide any isolation between transactions on the same database"},{"line_number":12,"context_line":"connection [1] and the bug can only be reproduced with the isolation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3fa7e38b_717cf41f","line":9,"updated":"2019-10-24 21:18:27.000000000","message":"be nice if this described what the test is/does (without having to go to the bug)","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"}],"gate/post_test_hook.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67c3e1b05d6ab0640e8417327d421003bc794b05","unresolved":false,"context_lines":[{"line_number":47,"context_line":"source ${BASE}/devstack/functions-common"},{"line_number":48,"context_line":"source ${BASE}/devstack/lib/nova"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# This needs to go before \u0027set -e\u0027 because otherwise the intermediate runs of"},{"line_number":51,"context_line":"# \u0027nova-manage db archive_deleted_rows\u0027 returning 1 (normal and expected) would"},{"line_number":52,"context_line":"# cause this script to exit and fail."},{"line_number":53,"context_line":"archive_deleted_rows"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_1306561e","line":52,"range":{"start_line":50,"start_character":0,"end_line":52,"end_character":37},"updated":"2019-10-17 16:51:17.000000000","message":"Oh I guess this is the reason for the set +e below.","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3c6196fca43860915d645eeeae4a26a6b615e654","unresolved":false,"context_lines":[{"line_number":47,"context_line":"source ${BASE}/devstack/functions-common"},{"line_number":48,"context_line":"source ${BASE}/devstack/lib/nova"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# This needs to go before \u0027set -e\u0027 because otherwise the intermediate runs of"},{"line_number":51,"context_line":"# \u0027nova-manage db archive_deleted_rows\u0027 returning 1 (normal and expected) would"},{"line_number":52,"context_line":"# cause this script to exit and fail."},{"line_number":53,"context_line":"archive_deleted_rows"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_539e0e6a","line":52,"range":{"start_line":50,"start_character":0,"end_line":52,"end_character":37},"in_reply_to":"3fa7e38b_1306561e","updated":"2019-10-17 17:22:00.000000000","message":"Correct. I considered duplicating the comment but then thought maybe that\u0027s a bit much. I don\u0027t mind adding a comment if you want.","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc3901c0a5a834928fded3d179428db688c296c8","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    exit 2"},{"line_number":255,"context_line":"fi"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"echo \"Verifying online_data_migrations idempotence\""},{"line_number":258,"context_line":"# We will re-use the server created earlier for this test. (A server needs to"},{"line_number":259,"context_line":"# be present during the run of online_data_migrations and archiving)."},{"line_number":260,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_78c0c9e1","line":257,"range":{"start_line":257,"start_character":39,"end_line":257,"end_character":50},"updated":"2019-10-17 16:50:04.000000000","message":"I read this as impotence at first... :/","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"65bc7f7e0b94b48132cf1ef2632d7d80c826d74e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    exit 2"},{"line_number":255,"context_line":"fi"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"echo \"Verifying online_data_migrations idempotence\""},{"line_number":258,"context_line":"# We will re-use the server created earlier for this test. (A server needs to"},{"line_number":259,"context_line":"# be present during the run of online_data_migrations and archiving)."},{"line_number":260,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_33d352d8","line":257,"range":{"start_line":257,"start_character":39,"end_line":257,"end_character":50},"in_reply_to":"3fa7e38b_13a8968a","updated":"2019-10-17 17:34:45.000000000","message":"Heh, don\u0027t worry about it.","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3c6196fca43860915d645eeeae4a26a6b615e654","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    exit 2"},{"line_number":255,"context_line":"fi"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"echo \"Verifying online_data_migrations idempotence\""},{"line_number":258,"context_line":"# We will re-use the server created earlier for this test. (A server needs to"},{"line_number":259,"context_line":"# be present during the run of online_data_migrations and archiving)."},{"line_number":260,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_13a8968a","line":257,"range":{"start_line":257,"start_character":39,"end_line":257,"end_character":50},"in_reply_to":"3fa7e38b_78c0c9e1","updated":"2019-10-17 17:22:00.000000000","message":"Maybe I should write idempotency instead. Or something else. I didn\u0027t spend too much time thinking about it.","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc3901c0a5a834928fded3d179428db688c296c8","unresolved":false,"context_lines":[{"line_number":264,"context_line":"# We need to archive the deleted marker instance used by the"},{"line_number":265,"context_line":"# fill_virtual_interface_list online data migration in order to trigger"},{"line_number":266,"context_line":"# creation of a new deleted marker instance."},{"line_number":267,"context_line":"set +e"},{"line_number":268,"context_line":"archive_deleted_rows"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"# Verify whether online data migrations run after archiving will succeed."}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_987d85b4","line":267,"updated":"2019-10-17 16:50:04.000000000","message":"This is here because of bug 1824435 right? Meaning archiving will fail and kill the script otherwise. But we can remove this once the bug is fixed right? So maybe should have a TODO here.","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3c6196fca43860915d645eeeae4a26a6b615e654","unresolved":false,"context_lines":[{"line_number":264,"context_line":"# We need to archive the deleted marker instance used by the"},{"line_number":265,"context_line":"# fill_virtual_interface_list online data migration in order to trigger"},{"line_number":266,"context_line":"# creation of a new deleted marker instance."},{"line_number":267,"context_line":"set +e"},{"line_number":268,"context_line":"archive_deleted_rows"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"# Verify whether online data migrations run after archiving will succeed."}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_3386f215","line":267,"in_reply_to":"3fa7e38b_987d85b4","updated":"2019-10-17 17:22:00.000000000","message":"This has to stay before archive_deleted_rows because intermediate runs will return 1 and even when nested in a function, they will make the script exit if not +e.\n\nAfter the bug is fixed, -e will need to move right under archive_deleted_rows. I forgot to add a TODO comment because I forgot that\u0027s what we normally do in regression func tests.\n\nThe patch on top of this one shows the change.","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"664fd8b66fdf8b344434726f9888ba3d2f827650","unresolved":false,"context_lines":[{"line_number":271,"context_line":"# See for more details: https://bugs.launchpad.net/nova/+bug/1824435"},{"line_number":272,"context_line":"$MANAGE db online_data_migrations"},{"line_number":273,"context_line":"rc\u003d$?"},{"line_number":274,"context_line":"set -e"},{"line_number":275,"context_line":"if [[ $rc -ne 2 ]]; then"},{"line_number":276,"context_line":"    echo \"Expected return code 2 from online_data_migrations until bug 1824435 is fixed\""},{"line_number":277,"context_line":"    exit 2"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_118ca033","line":274,"range":{"start_line":274,"start_character":0,"end_line":274,"end_character":6},"updated":"2019-10-24 21:18:27.000000000","message":"this is redundant, but shrug","commit_id":"7c41365f193fd5b08d0174b6cd8e349ac95b7907"}]}