)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2d4f5fba98dfd98692e249bfb954cee2632c9810","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set instance CPU policy to \u0027share\u0027 when \u0027hw_cpu_policy\u003d\u003dshare\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before the introduce of \u0027CPU resource\u0027_, a \u0027cpu_policy\u0027 of None"},{"line_number":10,"context_line":"is the same as a \u0027cpu_policy\u0027 of \u0027shared\u0027 effectively."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"But these two CPU policies (\u0027shared\u0027 and None) have some difference now,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_a311625f","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":39},"updated":"2019-10-15 10:41:01.000000000","message":"nit: This isn\u0027t rST so you probably shouldn\u0027t do this since it makes things harder to read.\n\n  Before the introduction of the \u0027cpu-resources\u0027 spec [1], ...","commit_id":"de896dc34fabf5221caeb1f5fc9d47d91acf87dd"}],"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ba7ace9f60df1be79f019895a9b2b032605f4da2","unresolved":false,"context_lines":[{"line_number":949,"context_line":"                },"},{"line_number":950,"context_line":"                \"expect\": exception.InvalidCPUAllocationPolicy"},{"line_number":951,"context_line":"            },"},{"line_number":952,"context_line":"        ]"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        for testitem in testdata:"},{"line_number":955,"context_line":"            image_meta \u003d objects.ImageMeta.from_dict(testitem[\"image\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5f041718","line":952,"updated":"2019-10-30 18:19:48.000000000","message":"This is a nice thorough test, but when it fails, it\u0027s very difficult to figure out which scenario it failed on. It should be possible to use ddt to clarify it.\n\n[Later] I can see this was just copied from the subsequent test, so I won\u0027t hold up on it.\n\n[Later later] ...but I made https://review.opendev.org/#/c/692205/ to demonstrate how the annotated ddt thing would work.","commit_id":"569ad1402e2447ef72672934947541c81b3d5ef7"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"70fed01fa3c266388ea67f7de0148bb1af702d10","unresolved":false,"context_lines":[{"line_number":949,"context_line":"                },"},{"line_number":950,"context_line":"                \"expect\": exception.InvalidCPUAllocationPolicy"},{"line_number":951,"context_line":"            },"},{"line_number":952,"context_line":"        ]"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        for testitem in testdata:"},{"line_number":955,"context_line":"            image_meta \u003d objects.ImageMeta.from_dict(testitem[\"image\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9f3cb2bf","line":952,"in_reply_to":"3fa7e38b_5f041718","updated":"2019-11-01 15:50:42.000000000","message":"Got.\nI think you also want to use \u0027ddt\u0027 to rewrite next test function \u0027test_topology_constraints\u0027, right?","commit_id":"569ad1402e2447ef72672934947541c81b3d5ef7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9f61ce63add47c6cb1b6e3d4a64730dd133ff220","unresolved":false,"context_lines":[{"line_number":949,"context_line":"                },"},{"line_number":950,"context_line":"                \"expect\": exception.InvalidCPUAllocationPolicy"},{"line_number":951,"context_line":"            },"},{"line_number":952,"context_line":"        ]"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        for testitem in testdata:"},{"line_number":955,"context_line":"            image_meta \u003d objects.ImageMeta.from_dict(testitem[\"image\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6037d6e4","line":952,"in_reply_to":"3fa7e38b_9f3cb2bf","updated":"2019-11-01 17:26:52.000000000","message":"Correct. That one has an even bigger data set.\n\nAs I hinted above, don\u0027t change it in this patch. The ddt solution has some quirks that should probably be ironed out before we get too committed to it.","commit_id":"569ad1402e2447ef72672934947541c81b3d5ef7"}],"nova/virt/hardware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85fbd9040b1f68bbe0c76881487595521112cf3c","unresolved":false,"context_lines":[{"line_number":1512,"context_line":"        if image_policy \u003d\u003d fields.CPUAllocationPolicy.DEDICATED:"},{"line_number":1513,"context_line":"            raise exception.ImageCPUPinningForbidden()"},{"line_number":1514,"context_line":"        cpu_policy \u003d flavor_policy"},{"line_number":1515,"context_line":"    elif image_policy in fields.CPUAllocationPolicy.ALL:"},{"line_number":1516,"context_line":"        cpu_policy \u003d image_policy"},{"line_number":1517,"context_line":"    else:"},{"line_number":1518,"context_line":"        cpu_policy \u003d None"},{"line_number":1519,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c143053f","line":1516,"range":{"start_line":1515,"start_character":0,"end_line":1516,"end_character":33},"updated":"2019-11-06 03:51:45.000000000","message":"I think this is wrong but I don\u0027t recall why at the moment and I\u0027m at the PTG so I won\u0027t have time for a bit. Can we hold off on this for a moment?\n\nLater: Actually, I said why it was necessary when I reviewed this previously.\n\n \u003e FWIW, the change that introduced this regression is commit 278ab01c320. It was necessary as called out at [1] but introduced this regression\n \u003e \n \u003e [1] https://review.opendev.org/#/c/671801/35/nova/virt/hardware.py@1463\n\nSo this is probably correct and can be merged, but I\u0027d like to double check (or at least draw attention to it for other people to double check)","commit_id":"569ad1402e2447ef72672934947541c81b3d5ef7"}]}