)]}'
{"id":"openstack%2Fnova~689179","triplet_id":"openstack%2Fnova~master~Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f","project":"openstack/nova","branch":"master","topic":"functional-test-cleanup","hashtags":[],"change_id":"Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f","subject":"functional: Rework \u0027_delete_server\u0027","status":"MERGED","created":"2019-10-17 14:36:08.000000000","updated":"2019-11-21 01:39:10.000000000","submitted":"2019-11-18 21:01:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"689179-1574110918295-7789a045","meta_rev_id":"ac9820e18e3ce15d8b96ab030e35a2079a95b44d","_number":689179,"virtual_id_number":689179,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-11-15 23:26:51.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-11-21 01:39:10.000000000","post_submit":true,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"date":"2019-11-15 23:33:19.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-11-15 18:01:32.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-11-15 19:40:39.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"date":"2019-11-15 17:15:47.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-18 21:01:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-11-15 17:35:07.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-11-18 17:55:09.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-11-18 17:55:09.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-17 18:13:55.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-25 18:10:29.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2019-11-15 17:15:47.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2019-11-15 17:35:07.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-11-15 18:01:32.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-11-15 19:40:39.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2019-11-15 23:26:51.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-11-15 23:33:19.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-11-18 17:55:09.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-11-18 21:01:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-11-21 01:39:10.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"07c2f7551217ef7e8073430a33938fd1f4499a18","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-10-17 14:36:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3dfc5e2a81e7aa65bd23cf20c1362de52b6f14fc","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-10-17 14:37:15.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2b3ae77f17cb4dbc626db1b5a28c14cee5b478a8","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-10-17 15:15:33.000000000","message":"Patch Set 1:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/79/689179/1/check/pmem-tempest-plugin-filtered/f663ee0/ : SUCCESS in 37m 22s","accounts_in_message":[],"_revision_number":1},{"id":"84272f0bae9501baca2ff707e2cef9db31fd3f61","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-17 15:33:30.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f165cf76e5194add801092b38900cf21 : FAILURE in 15m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1873fcb9dfcc42a982edb3e846c676b2 : SUCCESS in 18m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/293746665c8445f2a79105c2386cf3d0 : SUCCESS in 10m 26s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3ff2d3c491ab4e5486f093c9b5fa301e : SUCCESS in 19m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ebaf5548523e4f2983e5c10979858ffa : FAILURE in 12m 56s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/15d982e05801493b8ef294963e9e9f8b : FAILURE in 14m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/50d5f69fabba410da7bf9b8b59a27778 : SUCCESS in 9m 39s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/dd23ab0218794e28974114a93d83b996 : SUCCESS in 17m 47s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/678d4a488c844831b0987262a8eb44b1 : SUCCESS in 20m 57s","accounts_in_message":[],"_revision_number":1},{"id":"f1d1d47eb0333c4e4084c3d9c1d71516ceae19fc","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-10-17 16:17:04.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-38380 : FAILURE in 1h 36m 54s","accounts_in_message":[],"_revision_number":1},{"id":"d99818ca0b64ce7a8e2187c7bad6a08e90b23b77","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-10-17 16:24:42.000000000","message":"Patch Set 1:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/79/689179/1/check-vote/ext-nova-zuul/ada99c3 : SUCCESS in 53m 14s","accounts_in_message":[],"_revision_number":1},{"id":"f30c59229dd1d6ac3848ec997f1bb7cf4eb2c08c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-10-17 18:12:44.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"c5b8a55ba23b3884173861ea77cb65fd14751c23","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-10-17 18:13:55.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"09f60b635b9f9f6e5ca89ce3d643c7f7dfe57403","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-17 18:41:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a5b03a4d2e1045bc9ecad66d4001dc70 : SUCCESS in 14m 27s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cf4dc3aba81645ecbf8a443b649122b0 : SUCCESS in 14m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c5cc55c740974825a103d35a87233550 : SUCCESS in 11m 32s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a8dcbcfecbdd476ea41ca0de1f5278ba : SUCCESS in 13m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/844ca28fafb84a578542ade3ef014565 : SUCCESS in 11m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/30a7a3127890465dbc8f4920d1c5c5cb : SUCCESS in 14m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7f8f9d9c02b5433a9bb4f99801a32a2f : SUCCESS in 10m 37s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/6dc473bb14e045f3b64067770a62eee7 : SUCCESS in 16m 36s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/c709193208bd428ca9e83819ab8f3e1e : SUCCESS in 18m 18s","accounts_in_message":[],"_revision_number":2},{"id":"d4e2d0ba3a5d1671dff1ce250f6e16c73dc4337b","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-10-17 18:42:10.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/79/689179/2/check/EMC_VxFlexOS_NOVA/4f8f3a0/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":2},{"id":"286850349973c794938a715d80c19e58ba28e4f3","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-10-17 18:49:15.000000000","message":"Patch Set 2:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/79/689179/2/check/pmem-tempest-plugin-filtered/e7fce24/ : SUCCESS in 34m 15s","accounts_in_message":[],"_revision_number":2},{"id":"17b9413c16fd09e046781caa23a75e3581cc5eb0","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-10-17 18:52:39.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/689179/2 : FAILURE in 3m 58s","accounts_in_message":[],"_revision_number":2},{"id":"5e6fe9c32b370bbb4fe4b31357b6835749101f37","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-10-17 20:46:17.000000000","message":"Patch Set 2:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-38393 : SUCCESS in 2h 29m 22s","accounts_in_message":[],"_revision_number":2},{"id":"2a5ae1e0872931cf5e54d7ff4380653d9ad37bc9","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-10-17 20:59:03.000000000","message":"Patch Set 2:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-79-689179-2 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":2},{"id":"9520f1deb5bdcb22c8eabc329f52b938fc433d91","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-10-17 21:36:07.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/79/689179/2/check-vote/ext-nova-zuul/0f5b5b9 : SUCCESS in 50m 38s","accounts_in_message":[],"_revision_number":2},{"id":"9118bcbb4acbeddbfbf93db4be03ead2ca0d1010","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-10-25 18:10:29.000000000","message":"Patch Set 2: Code-Review+1\n\nFor some reason it took me some effort to wrap my head around this (could the commit message use some improving, perhaps?)\n\nTo rephrase what\u0027s going on:\n\nWe want ServerBase to inherit from InstanceHelperMixin. They both have implementations of a \"wait until server is deleted\" function - ServerBase\u0027s is called _wait_for_deletion and takes a server_id, InstanceHelperMixin\u0027s is called _wait_until_deleted and takes a full server JSON-y dict. [1] will rename the ServersTestBase\u0027s version to bring it inline with InstanceHelperMixin\u0027s version.\n\nThe thing is, ServerBase\u0027s _delete_server currently calls _wait_for_deletion and passes it a server_id. As such, _delete_server itself is only passed a server_id. After [1], this server_id will no longer be enough, as _delete_server will need to call the newly merged _wait_until_deleted that takes a full server JSON-y dict, so _delete_server itself needs to receive a full server JSON-y dict.\n\n*This* is what this patch does: makes _delete_server receive a full server JSON-y dict.\n\n[1] https://review.opendev.org/#/c/689181/3/nova/tests/functional/test_servers.py","accounts_in_message":[],"_revision_number":2},{"id":"c72019cf4f8a8e810744ab388587b72e72dadce4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-14 11:26:40.000000000","message":"Patch Set 2:\n\n\u003e For some reason it took me some effort to wrap my head around this\n \u003e (could the commit message use some improving, perhaps?)\n \u003e \n \u003e To rephrase what\u0027s going on:\n \u003e \n \u003e We want ServerBase to inherit from InstanceHelperMixin. They both\n \u003e have implementations of a \"wait until server is deleted\" function -\n \u003e ServerBase\u0027s is called _wait_for_deletion and takes a server_id,\n \u003e InstanceHelperMixin\u0027s is called _wait_until_deleted and takes a\n \u003e full server JSON-y dict. [1] will rename the ServersTestBase\u0027s\n \u003e version to bring it inline with InstanceHelperMixin\u0027s version.\n \u003e \n \u003e The thing is, ServerBase\u0027s _delete_server currently calls\n \u003e _wait_for_deletion and passes it a server_id. As such,\n \u003e _delete_server itself is only passed a server_id. After [1], this\n \u003e server_id will no longer be enough, as _delete_server will need to\n \u003e call the newly merged _wait_until_deleted that takes a full server\n \u003e JSON-y dict, so _delete_server itself needs to receive a full\n \u003e server JSON-y dict.\n \u003e \n \u003e *This* is what this patch does: makes _delete_server receive a full\n \u003e server JSON-y dict.\n \u003e \n \u003e [1] https://review.opendev.org/#/c/689181/3/nova/tests/functional/test_servers.py\n\nGood call. I\u0027ve used this almost verbatim.","accounts_in_message":[],"_revision_number":2},{"id":"6ac988ccbd6546205aac1f434b2d050654e24ef7","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-14 11:36:05.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"fcd3232773fe735391caabc3626e1c2628d30405","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-14 12:04:02.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fc92be5056624f3f9e0651e03f026265 : SUCCESS in 19m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/22c5ba73edc14f459e87a62498699632 : SUCCESS in 17m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f330e3da3b8e49eda9bf7baade583c21 : SUCCESS in 12m 02s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/40940bf0003d4927b2ef9b07ac5ff63a : SUCCESS in 13m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fe9a3f9ed7604adba2df11f7e9ef4ff5 : SUCCESS in 14m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7d773247dd4e4a34bd0853eea37119f1 : SUCCESS in 12m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/209b61a9aed4421e89daa0d15c06e722 : SUCCESS in 10m 52s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/dfe915eb21d542f783663c6330ecc18c : FAILURE in 21m 12s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6c87cd1ef36846b8a4f1836cb9bfb003 : FAILURE in 20m 03s","accounts_in_message":[],"_revision_number":3},{"id":"4f9e7bcc090668f694dfaaf027d61c0e5d88e6c7","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-11-14 12:13:55.000000000","message":"Patch Set 3:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/79/689179/3/check/pmem-tempest-plugin-filtered/5f816d2/ : SUCCESS in 35m 39s","accounts_in_message":[],"_revision_number":3},{"id":"67cee173cb5cb97d1f81d0d331ecd4b801dcec2c","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-11-14 13:09:49.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-39082 : FAILURE in 1h 29m 32s","accounts_in_message":[],"_revision_number":3},{"id":"e5a7c568be8b053bca2b51e71c29c7ff81d5ef81","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-11-14 17:04:12.000000000","message":"Patch Set 3:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/79/689179/3/check-vote/ext-nova-zuul/d2851df : FAILURE in 28m 14s","accounts_in_message":[],"_revision_number":3},{"id":"11e8188951f57a012fb9d811e4875f7ab7e63a2c","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-11-14 17:28:11.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/689179/3 : SUCCESS in 3h 09m 35s","accounts_in_message":[],"_revision_number":3},{"id":"c8753b0aa0a4977c1706278ff671e7d09d77e4a4","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-14 22:02:56.000000000","message":"Patch Set 3: Code-Review-1\n\nDoes what it says on the tin. Tests are failing due, I think, to [1] again, though I can\u0027t immediately see how. Other than that I\u0027m +1 pending review of the rest of the series.\n\n[1] Id9ed7a82d42be8ffe760f03e6610b9e6f5a4287b","accounts_in_message":[],"_revision_number":3},{"id":"99344b2c2c690ceec509497c4f593e089634318e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-11-15 16:33:02.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"23430a7e7f9e6d798b67dbefdcc3b33971c6bdd8","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-11-15 17:15:47.000000000","message":"Patch Set 4:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/79/689179/4/check/pmem-tempest-plugin-filtered/392d7ab/ : SUCCESS in 32m 32s","accounts_in_message":[],"_revision_number":4},{"id":"1acb3fd60f097fcc82202823b8dd1433d93ce52a","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-15 17:35:07.000000000","message":"Patch Set 4: Code-Review+2\n\nCool, if zuul is happy I\u0027m happy.","accounts_in_message":[],"_revision_number":4},{"id":"72a625d5186984e87bad30453bdd7338591ef9bb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-15 18:00:52.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/826d3a12a28d4589b77407f91e03ceb6 : SUCCESS in 27m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/519fe14e691348d79549ee797d840d67 : SUCCESS in 25m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8057ffe1d83e4880811cc692ac0a0712 : SUCCESS in 15m 02s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3e56f8e1a5ca4cc89fbb1f8e7340982c : SUCCESS in 17m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d7d7ad4e23184eb2bdb7ab41b2491bd2 : SUCCESS in 27m 01s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c0e4f0f366cb459093515170b8cb3feb : SUCCESS in 22m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7808e4bd95d1434093fc75fb49a871fd : SUCCESS in 18m 34s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/9b2b7a8f9e88452196ae43cfdb7e2915 : SUCCESS in 28m 28s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/d1ba333ec9da4bd0bd996df71dbd9844 : SUCCESS in 22m 50s","accounts_in_message":[],"_revision_number":4},{"id":"e8015b7bc37be0edf33a66c3d8cc9c18a8cb3d71","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-11-15 18:01:32.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/79/689179/4/check/EMC_VxFlexOS_NOVA/9ccc7b3/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":4},{"id":"dadadd3f313d740dcef9f04fce447de406687c90","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-11-15 19:40:39.000000000","message":"Patch Set 4:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-39171 : FAILURE in 1h 59m 22s","accounts_in_message":[],"_revision_number":4},{"id":"40103cb59d21736c633318ae226534e91fbc0b92","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-11-15 23:26:51.000000000","message":"Patch Set 4:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-79-689179-4 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":4},{"id":"9a9367fef700c7725701cea4a3b549154d5639d7","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-11-15 23:33:19.000000000","message":"Patch Set 4:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/689179/4 : SUCCESS in 2h 27m 52s","accounts_in_message":[],"_revision_number":4},{"id":"ab74d300f605ae6d277e526d7186bfad388e5f18","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-11-18 17:55:09.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nThis looks OK.","accounts_in_message":[],"_revision_number":4},{"id":"2ffc2eea3bf55d6f779891f93c4365b950f38312","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-18 17:55:34.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"587470a45fad2d99f276763636e47e7fc2b01c0e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-18 21:01:57.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/884a32cbc6764bc3b384ee2d849cb954 : SUCCESS in 15m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1dfd7d067c324b9db1366708f993febc : SUCCESS in 11m 07s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/aaaf9cdd9f1243f5a8f51d807189d119 : SUCCESS in 12m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/20c8ef84ea994dfcad8debf02e5f0e00 : SUCCESS in 14m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4962974a7fad4fe3bf6512f1dc6efd9e : SUCCESS in 14m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/63406d5b6fc24712a6cd39af5fb8bc1b : SUCCESS in 11m 21s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/cbe79510a0274b2a9b1329c0f4140cfe : SUCCESS in 20m 18s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/0ee426070c2048fdb5771541288935d7 : SUCCESS in 23m 29s","accounts_in_message":[],"_revision_number":4},{"id":"d95c61b5a3bf2b10253a33eb06259923b127e3fb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-18 21:01:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"40415ac6f74f4535cf9fb3a1b460082dcad222fc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-18 21:06:57.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ef8cfe350a4a4488b7fd2370816723ed : SUCCESS in 1m 13s","accounts_in_message":[],"_revision_number":4},{"id":"f0dcb06033119bf3d9ec10c11aaa102aa7f5a520","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-11-21 01:39:10.000000000","message":"Patch Set 4:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/79/689179/4/check-vote/ext-nova-zuul/41d3fe3 : FAILURE in 28m 48s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"57f335090b9e56d764c02705a42ce2d3690d8955","revisions":{"196ce934f6df9ea0cccab37d202c49894f156522":{"kind":"REWORK","_number":1,"created":"2019-10-17 14:36:08.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/79/689179/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/79/689179/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/79/689179/1"}}},"commit":{"parents":[{"commit":"f6efd198e4f86d76cda17e5ab84128e5b0c396b7","subject":"functional: Change order of two classes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f6efd198e4f86d76cda17e5ab84128e5b0c396b7"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-11 09:25:45.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-17 10:25:13.000000000","tz":60},"subject":"functional: Rework \u0027_delete_server\u0027","message":"functional: Rework \u0027_delete_server\u0027\n\nWe want to add the \u0027InstanceHelperMixin\u0027 mixin to \u0027ServerBase\u0027. That\nincludes a \u0027_wait_until_deleted\u0027 function that we should use in our\n\u0027_delete_server\u0027 helper function, but that expects a full server\nresponse rather than just an (UU)ID. As such, we need to rework the\n\u0027_delete_server\u0027 function as a prerequisite to the merge.\n\nChange-Id: Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/196ce934f6df9ea0cccab37d202c49894f156522"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/196ce934f6df9ea0cccab37d202c49894f156522"}]},"branch":"refs/heads/master"},"78155d5274a5ed928eaec69d7eac6c8601b8dabf":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-10-17 18:12:44.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/79/689179/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/79/689179/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/79/689179/2"}}},"commit":{"parents":[{"commit":"409229bf43678851933862bab21193b5557cf04a","subject":"functional: Change order of two classes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/409229bf43678851933862bab21193b5557cf04a"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-11 09:25:45.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-17 18:12:31.000000000","tz":60},"subject":"functional: Rework \u0027_delete_server\u0027","message":"functional: Rework \u0027_delete_server\u0027\n\nWe want to add the \u0027InstanceHelperMixin\u0027 mixin to \u0027ServerBase\u0027. That\nincludes a \u0027_wait_until_deleted\u0027 function that we should use in our\n\u0027_delete_server\u0027 helper function, but that expects a full server\nresponse rather than just an (UU)ID. As such, we need to rework the\n\u0027_delete_server\u0027 function as a prerequisite to the merge.\n\nChange-Id: Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/78155d5274a5ed928eaec69d7eac6c8601b8dabf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/78155d5274a5ed928eaec69d7eac6c8601b8dabf"}]},"branch":"refs/heads/master"},"a31e6a03c0b66b94ea62f7de05867c4ad7b23f19":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2019-11-14 11:36:05.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/79/689179/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/79/689179/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/79/689179/3"}}},"commit":{"parents":[{"commit":"bdfaa734d9c16d09c44955587f4bbc096e7d7b67","subject":"functional: Change order of two classes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bdfaa734d9c16d09c44955587f4bbc096e7d7b67"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-11 09:25:45.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-11 09:25:45.000000000","tz":60},"subject":"functional: Rework \u0027_delete_server\u0027","message":"functional: Rework \u0027_delete_server\u0027\n\nWe want \u0027ServerBase\u0027 to inherit from \u0027InstanceHelperMixin\u0027. They both\nhave implementations of a \"wait until server is deleted\" function.  The\n\u0027ServerBase\u0027 implementation is called \u0027_wait_for_deletion\u0027 and takes a\n\u0027server_id\u0027, while the \u0027InstanceHelperMixin\u0027 implementation is called\n\u0027_wait_until_deleted\u0027 and takes a full server JSON-y dict. A later\nchange, I0c56841d098d3e9d72db65be3143f3c893f0b6ba, will rework the\n\u0027ServersTestBase\u0027 version to bring it inline with \u0027InstanceHelperMixin\u0027\nversion. However, \u0027ServerBase._delete_server\u0027 currently calls a\n\u0027_wait_for_deletion\u0027 function and passes it a \u0027server_id\u0027. As such,\n\u0027_delete_server\u0027 itself is only passed a server_id. After the future\nchange, this \u0027server_id\u0027 will no longer be enough as \u0027_delete_server\u0027\nwill need to call the newly merged \u0027_wait_until_deleted\u0027 that takes a\nfull server JSON-y dict, so \u0027_delete_server\u0027 itself needs to receive a\nfull server JSON-y dict.\n\nDo this work now to simplify the future patch.\n\nChange-Id: Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a31e6a03c0b66b94ea62f7de05867c4ad7b23f19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a31e6a03c0b66b94ea62f7de05867c4ad7b23f19"}]},"branch":"refs/heads/master"},"57f335090b9e56d764c02705a42ce2d3690d8955":{"kind":"REWORK","_number":4,"created":"2019-11-15 16:33:02.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/79/689179/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/79/689179/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/689179/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/79/689179/4"}}},"commit":{"parents":[{"commit":"931ce9b9d2481b5eb50e0bc987f925b55b6ef13b","subject":"functional: Change order of two classes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/931ce9b9d2481b5eb50e0bc987f925b55b6ef13b"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-11 09:25:45.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-11-15 16:06:57.000000000","tz":0},"subject":"functional: Rework \u0027_delete_server\u0027","message":"functional: Rework \u0027_delete_server\u0027\n\nWe want \u0027ServerBase\u0027 to inherit from \u0027InstanceHelperMixin\u0027. They both\nhave implementations of a \"wait until server is deleted\" function.  The\n\u0027ServerBase\u0027 implementation is called \u0027_wait_for_deletion\u0027 and takes a\n\u0027server_id\u0027, while the \u0027InstanceHelperMixin\u0027 implementation is called\n\u0027_wait_until_deleted\u0027 and takes a full server JSON-y dict. A later\nchange, I0c56841d098d3e9d72db65be3143f3c893f0b6ba, will rework the\n\u0027ServersTestBase\u0027 version to bring it inline with \u0027InstanceHelperMixin\u0027\nversion. However, \u0027ServerBase._delete_server\u0027 currently calls a\n\u0027_wait_for_deletion\u0027 function and passes it a \u0027server_id\u0027. As such,\n\u0027_delete_server\u0027 itself is only passed a server_id. After the future\nchange, this \u0027server_id\u0027 will no longer be enough as \u0027_delete_server\u0027\nwill need to call the newly merged \u0027_wait_until_deleted\u0027 that takes a\nfull server JSON-y dict, so \u0027_delete_server\u0027 itself needs to receive a\nfull server JSON-y dict.\n\nDo this work now to simplify the future patch.\n\nChange-Id: Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/57f335090b9e56d764c02705a42ce2d3690d8955"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/57f335090b9e56d764c02705a42ce2d3690d8955"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}