)]}'
{"nova/tests/functional/libvirt/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3eb25ff147cfc7f0b400822abf618743c2157ec6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.addCleanup(fake_notifier.reset)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class IntegratedTestBase(integrated_helpers._IntegratedTestBase):"},{"line_number":81,"context_line":"    api_major_version \u003d \u0027v2\u0027"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_eacaa344","line":80,"range":{"start_line":80,"start_character":44,"end_line":80,"end_character":63},"updated":"2019-10-17 14:59:10.000000000","message":"This is old and crusty and new tests shouldn\u0027t be using it because of all the assumptions it makes and fixtures it uses like CastAsCall. I wouldn\u0027t build new stuff based on this but rather invest the time in removing dependencies on ServersTestBase and _IntegratedTestBase itself. See ProviderUsageBaseTestCase as a good model to follow (or just use that).","commit_id":"03cd2a68331b734dae1e6774ab0d5ff748ce5b1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d18a7c00e97529e64887c141174df56a2c522d0b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.addCleanup(fake_notifier.reset)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class IntegratedTestBase(integrated_helpers._IntegratedTestBase,"},{"line_number":82,"context_line":"                         integrated_helpers.InstanceHelperMixin):"},{"line_number":83,"context_line":"    api_major_version \u003d \u0027v2\u0027"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1e48765a","line":81,"range":{"start_line":81,"start_character":44,"end_line":81,"end_character":63},"updated":"2019-10-21 15:43:04.000000000","message":"As I said in PS1, can we just not use this? It\u0027s old and crusty and opinionated in ways that we don\u0027t really want to continue to build things on it. Why not just extend ProviderUsageBaseTestCase instead?","commit_id":"be63ace625aa96aba73de5e8d7f41dc19956c391"}]}