)]}'
{"nova/policies/extended_server_attributes.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32d69b02a38658a9a23194a5ce72b3cb4ff4a662","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"},{"line_number":49,"context_line":"                \u0027path\u0027: \u0027/servers/detail\u0027"},{"line_number":50,"context_line":"            },"},{"line_number":51,"context_line":"            {"},{"line_number":52,"context_line":"                \u0027method\u0027: \u0027PUT\u0027,"},{"line_number":53,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}\u0027"},{"line_number":54,"context_line":"            },"},{"line_number":55,"context_line":"            {"},{"line_number":56,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":57,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/action (rebuild)\u0027"},{"line_number":58,"context_line":"            }"},{"line_number":59,"context_line":"        ]"},{"line_number":60,"context_line":"    ),"},{"line_number":61,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_590b682a","line":58,"range":{"start_line":51,"start_character":12,"end_line":58,"end_character":13},"updated":"2019-10-21 17:18:22.000000000","message":"The tricky thing with this is it\u0027s not correct for these routes before 2.75 but there isn\u0027t a way to specify microversion in this list of dicts, is there? Which would mean if we mention the microversion we would have to do that in the body of the description. We could add an optional \u0027microversion\u0027 key to the DocumentedRuleDefault.operations stuff in oslo.policy but that\u0027s a bigger change.","commit_id":"7edf9d808e78933e99110148d28c62ef5b9ddfd2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7c97f4d61b73748debdbb145ee2b14f266a9ca1a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"},{"line_number":49,"context_line":"                \u0027path\u0027: \u0027/servers/detail\u0027"},{"line_number":50,"context_line":"            },"},{"line_number":51,"context_line":"            {"},{"line_number":52,"context_line":"                \u0027method\u0027: \u0027PUT\u0027,"},{"line_number":53,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}\u0027"},{"line_number":54,"context_line":"            },"},{"line_number":55,"context_line":"            {"},{"line_number":56,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":57,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/action (rebuild)\u0027"},{"line_number":58,"context_line":"            }"},{"line_number":59,"context_line":"        ]"},{"line_number":60,"context_line":"    ),"},{"line_number":61,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_fa0b237a","line":58,"range":{"start_line":51,"start_character":12,"end_line":58,"end_character":13},"in_reply_to":"3fa7e38b_590b682a","updated":"2019-10-21 19:38:30.000000000","message":"True but do we need to make policy doc documented per microverison? I am also thinking about the config option also which falls under the same category (when we add any new config option during new microverison). \n\nBoth (policy and config) are for the operator not for end-users and microversion is mainly for end-user/sdk/clients.\n\nIf the operator requires microvesion knowledge from policy doc also then we can add more clarity in the description of these policies saying that microvision 2.75 added \u003cnew\u003e attributes in PUT and Rebuild API response which can be controlled by this policy rule?\n\nInjecting microverison info in oslo.policy might be tricky as there are many type of changes happen in policy like rename, new methods addition, method removal, default change etc. description \u0026 operation parameter are shown as help text so we can document there about microversion things if needed.","commit_id":"7edf9d808e78933e99110148d28c62ef5b9ddfd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \"\"\"Return extended attributes for server."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This rule will control the visibility for a set of servers attributes:"},{"line_number":31,"context_line":"The microvision 2.75 added the below attributes in PUT /servers/{server_id} and"},{"line_number":32,"context_line":"POST \u0027/servers/{server_id}/action (rebuild)\u0027 API response also which is controlled by"},{"line_number":33,"context_line":"this policy rule like GET /servers* API."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ebb4acd3","line":31,"range":{"start_line":31,"start_character":51,"end_line":31,"end_character":75},"updated":"2019-10-22 13:55:05.000000000","message":"Enclose in `` ``","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \"\"\"Return extended attributes for server."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This rule will control the visibility for a set of servers attributes:"},{"line_number":31,"context_line":"The microvision 2.75 added the below attributes in PUT /servers/{server_id} and"},{"line_number":32,"context_line":"POST \u0027/servers/{server_id}/action (rebuild)\u0027 API response also which is controlled by"},{"line_number":33,"context_line":"this policy rule like GET /servers* API."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2bbba4c4","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"updated":"2019-10-22 13:55:05.000000000","message":"Just \"Microversion 2.75...\".","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This rule will control the visibility for a set of servers attributes:"},{"line_number":31,"context_line":"The microvision 2.75 added the below attributes in PUT /servers/{server_id} and"},{"line_number":32,"context_line":"POST \u0027/servers/{server_id}/action (rebuild)\u0027 API response also which is controlled by"},{"line_number":33,"context_line":"this policy rule like GET /servers* API."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- ``OS-EXT-SRV-ATTR:host``"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6bc0bc2b","line":32,"range":{"start_line":32,"start_character":5,"end_line":32,"end_character":6},"updated":"2019-10-22 13:55:05.000000000","message":"Remove these quotes and do:\n\n``POST /servers/{server_id}/action (rebuild)``","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":30,"context_line":"This rule will control the visibility for a set of servers attributes:"},{"line_number":31,"context_line":"The microvision 2.75 added the below attributes in PUT /servers/{server_id} and"},{"line_number":32,"context_line":"POST \u0027/servers/{server_id}/action (rebuild)\u0027 API response also which is controlled by"},{"line_number":33,"context_line":"this policy rule like GET /servers* API."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- ``OS-EXT-SRV-ATTR:host``"},{"line_number":36,"context_line":"- ``OS-EXT-SRV-ATTR:instance_name``"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cbe450e3","line":33,"range":{"start_line":33,"start_character":36,"end_line":33,"end_character":39},"updated":"2019-10-22 13:55:05.000000000","message":"APIs","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":30,"context_line":"This rule will control the visibility for a set of servers attributes:"},{"line_number":31,"context_line":"The microvision 2.75 added the below attributes in PUT /servers/{server_id} and"},{"line_number":32,"context_line":"POST \u0027/servers/{server_id}/action (rebuild)\u0027 API response also which is controlled by"},{"line_number":33,"context_line":"this policy rule like GET /servers* API."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- ``OS-EXT-SRV-ATTR:host``"},{"line_number":36,"context_line":"- ``OS-EXT-SRV-ATTR:instance_name``"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2be084cc","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":35},"updated":"2019-10-22 13:55:05.000000000","message":"``GET /servers*``","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5b7a646e3111689ea4d488cf0f627eea861647c7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":28,"context_line":"        \"\"\"Return extended attributes for server."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This rule will control the visibility for a set of servers attributes:"},{"line_number":31,"context_line":"Microvision 2.75 added the below attributes in the ``PUT /servers/{server_id}``"},{"line_number":32,"context_line":"and ``POST /servers/{server_id}/action (rebuild)`` API responses which are"},{"line_number":33,"context_line":"also controlled by this policy rule, like the ``GET /servers*`` APIs."}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_c8fbda44","line":30,"range":{"start_line":30,"start_character":69,"end_line":30,"end_character":70},"updated":"2019-10-23 18:16:53.000000000","message":"The new stuff should go before this sentence. I didn\u0027t notice that until I looked at the rendered docs:\n\nhttps://d4cf108cd74f5026e790-223b57c78bd886d84d4769be3c76a922.ssl.cf2.rackcdn.com/689833/5/check/openstack-tox-docs/69debdf/docs/configuration/policy.html","commit_id":"477f06d4edfe1ea3dbfb72559f9bc576e2364139"}],"nova/policies/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"Show a server with additional host status information."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The microvision 2.75 added the host_status attributes in PUT /servers/{server_id} and"},{"line_number":99,"context_line":"POST /servers/{server_id}/action (rebuild) API response also which is controlled by"},{"line_number":100,"context_line":"this policy rule like GET /servers* API."},{"line_number":101,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6bd51ce5","line":98,"range":{"start_line":98,"start_character":57,"end_line":98,"end_character":81},"updated":"2019-10-22 13:55:05.000000000","message":"Enclose in `` ``","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"Show a server with additional host status information."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The microvision 2.75 added the host_status attributes in PUT /servers/{server_id} and"},{"line_number":99,"context_line":"POST /servers/{server_id}/action (rebuild) API response also which is controlled by"},{"line_number":100,"context_line":"this policy rule like GET /servers* API."},{"line_number":101,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_abcb1448","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":15},"updated":"2019-10-22 13:55:05.000000000","message":"Microversion 2.75...","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"Show a server with additional host status information."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The microvision 2.75 added the host_status attributes in PUT /servers/{server_id} and"},{"line_number":99,"context_line":"POST /servers/{server_id}/action (rebuild) API response also which is controlled by"},{"line_number":100,"context_line":"this policy rule like GET /servers* API."},{"line_number":101,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4bd8601d","line":98,"range":{"start_line":98,"start_character":31,"end_line":98,"end_character":54},"updated":"2019-10-22 13:55:05.000000000","message":"``host_status`` attribute","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Show a server with additional host status information."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The microvision 2.75 added the host_status attributes in PUT /servers/{server_id} and"},{"line_number":99,"context_line":"POST /servers/{server_id}/action (rebuild) API response also which is controlled by"},{"line_number":100,"context_line":"this policy rule like GET /servers* API."},{"line_number":101,"context_line":"\"\"\","},{"line_number":102,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0b04a87d","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":42},"updated":"2019-10-22 13:55:05.000000000","message":"`` ``","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The microvision 2.75 added the host_status attributes in PUT /servers/{server_id} and"},{"line_number":99,"context_line":"POST /servers/{server_id}/action (rebuild) API response also which is controlled by"},{"line_number":100,"context_line":"this policy rule like GET /servers* API."},{"line_number":101,"context_line":"\"\"\","},{"line_number":102,"context_line":"        ["},{"line_number":103,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_eb026c6f","line":100,"range":{"start_line":100,"start_character":36,"end_line":100,"end_character":39},"updated":"2019-10-22 13:55:05.000000000","message":"APIs","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21232b80fa97c217018d1c62895efa1322387035","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The microvision 2.75 added the host_status attributes in PUT /servers/{server_id} and"},{"line_number":99,"context_line":"POST /servers/{server_id}/action (rebuild) API response also which is controlled by"},{"line_number":100,"context_line":"this policy rule like GET /servers* API."},{"line_number":101,"context_line":"\"\"\","},{"line_number":102,"context_line":"        ["},{"line_number":103,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cbfd306f","line":100,"range":{"start_line":100,"start_character":22,"end_line":100,"end_character":35},"updated":"2019-10-22 13:55:05.000000000","message":"`` ``","commit_id":"0e9da1194e91d278fc5be069248fceb964860c1a"}]}