)]}'
{"nova/tests/functional/regressions/test_bug_1849165.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42475cd691951c7ee3bbe5824adf4adb0460f989","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        server \u003d self._boot_and_check_allocations("},{"line_number":38,"context_line":"            self.flavor1, \u0027host1\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        orig_prep \u003d nova.compute.manager.ComputeManager._prep_resize"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def fake_prep(*args, **kwargs):"},{"line_number":43,"context_line":"            # Trigger update_available_resource on the destination (this runs"},{"line_number":44,"context_line":"            # it on the source as well, but that\u0027s okay)."},{"line_number":45,"context_line":"            self._run_periodics()"},{"line_number":46,"context_line":"            return orig_prep(*args, **kwargs)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        with mock.patch("},{"line_number":49,"context_line":"                \u0027nova.compute.manager.ComputeManager._prep_resize\u0027,"},{"line_number":50,"context_line":"                new\u003dfake_prep):"},{"line_number":51,"context_line":"            # Migrate the server."},{"line_number":52,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], {\u0027migrate\u0027: None})"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_bda04593","line":50,"range":{"start_line":40,"start_character":8,"end_line":50,"end_character":31},"updated":"2019-10-21 19:55:25.000000000","message":"This needs to change to ResourceTracker._claim_existing_migration and from within the stub, run the original method to update the Migration and set dest_compute on it, and then run the periodics before returning from the stub.\n\nI thought conductor\u0027s cold migration task would set Migration.dest_compute but it\u0027s just the live migration task in conductor that does that because before Train there was no move claim in the compute for a live migration.","commit_id":"06eb17dc61f8d26083998273485daa432b79db8b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"79b4d70fa7c6688b4b764c9c947ef805d02a302e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        server \u003d self._boot_and_check_allocations("},{"line_number":38,"context_line":"            self.flavor1, \u0027host1\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        orig_prep \u003d nova.compute.manager.ComputeManager._prep_resize"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def fake_prep(*args, **kwargs):"},{"line_number":43,"context_line":"            # Trigger update_available_resource on the destination (this runs"},{"line_number":44,"context_line":"            # it on the source as well, but that\u0027s okay)."},{"line_number":45,"context_line":"            self._run_periodics()"},{"line_number":46,"context_line":"            return orig_prep(*args, **kwargs)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        with mock.patch("},{"line_number":49,"context_line":"                \u0027nova.compute.manager.ComputeManager._prep_resize\u0027,"},{"line_number":50,"context_line":"                new\u003dfake_prep):"},{"line_number":51,"context_line":"            # Migrate the server."},{"line_number":52,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], {\u0027migrate\u0027: None})"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9ddf89d5","line":50,"range":{"start_line":40,"start_character":8,"end_line":50,"end_character":31},"in_reply_to":"3fa7e38b_5d17d1a4","updated":"2019-10-21 20:09:36.000000000","message":"Done","commit_id":"06eb17dc61f8d26083998273485daa432b79db8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"376b32677f8b9474c4d95b8bc15a88955a897318","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        server \u003d self._boot_and_check_allocations("},{"line_number":38,"context_line":"            self.flavor1, \u0027host1\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        orig_prep \u003d nova.compute.manager.ComputeManager._prep_resize"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def fake_prep(*args, **kwargs):"},{"line_number":43,"context_line":"            # Trigger update_available_resource on the destination (this runs"},{"line_number":44,"context_line":"            # it on the source as well, but that\u0027s okay)."},{"line_number":45,"context_line":"            self._run_periodics()"},{"line_number":46,"context_line":"            return orig_prep(*args, **kwargs)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        with mock.patch("},{"line_number":49,"context_line":"                \u0027nova.compute.manager.ComputeManager._prep_resize\u0027,"},{"line_number":50,"context_line":"                new\u003dfake_prep):"},{"line_number":51,"context_line":"            # Migrate the server."},{"line_number":52,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], {\u0027migrate\u0027: None})"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5d17d1a4","line":50,"range":{"start_line":40,"start_character":8,"end_line":50,"end_character":31},"in_reply_to":"3fa7e38b_bda04593","updated":"2019-10-21 20:03:39.000000000","message":"Scratch that, you\u0027ll hit the COMPUTE_RESOURCE_SEMAPHORE lock which likely means this isn\u0027t an issue during resize / cold migrate.\n\nYou\u0027ll want to change to a live migration test since conductor sets Migration.dest_compute for live migration and there is no migration context ever created for the instance during a live migration if it doesn\u0027t have a NUMA topology, so in that case you can stub out whatever on the dest compute to run the periodics, like pre_live_migration.","commit_id":"06eb17dc61f8d26083998273485daa432b79db8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d7650969824506312392c585e85d4779ce660221","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            self._wait_for_server_parameter("},{"line_number":56,"context_line":"                 self.api, server,"},{"line_number":57,"context_line":"                 {"},{"line_number":58,"context_line":"                     \u0027OS-EXT-STS:task_state\u0027: None,"},{"line_number":59,"context_line":"                     \u0027status\u0027: \u0027ACTIVE\u0027})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            # FIXME(efried): This is bug 1849165 where"},{"line_number":62,"context_line":"            #  _populate_assigned_resources raises a TypeError because it tries"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c01f5807","line":59,"range":{"start_line":57,"start_character":17,"end_line":59,"end_character":40},"updated":"2019-10-21 20:57:07.000000000","message":"This formatting leaves a bit to be desired.","commit_id":"761be5d0cb364333cde267b431b1ef87920f7400"}]}