)]}'
{"id":"openstack%2Fnova~690724","triplet_id":"openstack%2Fnova~stable%2Fqueens~I324193129acb6ac739133c7e76920762a8987a84","project":"openstack/nova","branch":"stable/queens","topic":"bug/1849409","hashtags":[],"change_id":"I324193129acb6ac739133c7e76920762a8987a84","subject":"Add functional regression test for bug 1849409","status":"MERGED","created":"2019-10-23 19:50:15.000000000","updated":"2019-12-12 23:42:33.000000000","submitted":"2019-12-12 23:42:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"690724-1576194153935-71032318","meta_rev_id":"b841c62c4a08ee34a98b5e7a7275578fa0edcfaa","_number":690724,"virtual_id_number":690724,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-12 23:42:33.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-11-25 21:48:32.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"date":"2019-11-25 23:14:16.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-12 18:34:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-12 18:34:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-25 21:48:32.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2019-11-25 23:14:16.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-12-12 18:34:47.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-12-12 23:42:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7e5da88a6347c92fa77c250125794b8cb1cf208d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-23 19:50:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"78556f90e9f4e72ca0932831886ef5fde3e392d4","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-10-23 19:58:15.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/24/690724/1/check/pmem-tempest-plugin-filtered/7b221a0/ : POST_FAILURE in 6m 38s","accounts_in_message":[],"_revision_number":1},{"id":"d031d5a8bf4adf22b565919a2cc5142cf565b04e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-23 21:34:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/32c9fe7f7d214c68a863d5cb9a1b0d6f : SUCCESS in 12m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/312f1ca531d34a2d8a25140cec8adeca : SUCCESS in 17m 14s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/6e609418c79142a39bb1e1a076b80284 : SUCCESS in 13m 46s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/8e8b99d846f740ceb0a38a821bcc014e : SUCCESS in 7m 48s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/7f98b1d2f154440c961be7e47e72286a : SUCCESS in 26m 11s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/81fbb028262e429b9f512463da59dce3 : SUCCESS in 20m 07s","accounts_in_message":[],"_revision_number":1},{"id":"d94ae5e4ef42403f26b7b181dcd4521361c5aa68","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-10-23 22:11:46.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/690724/1 : FAILURE in 1h 12m 57s","accounts_in_message":[],"_revision_number":1},{"id":"eb735c62b64edb0d7d0820c173070015ab109cf7","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-28 15:37:00.000000000","message":"Patch Set 1: Workflow-1\n\nThis will have to be redone since the Rocky backport changed.","accounts_in_message":[],"_revision_number":1},{"id":"deb27214e577cf7559df1485328d58e1f9d50d16","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-11-25 21:41:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"adfb8700fa2c13c5a63b598c717640a1644b0f39","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-11-25 21:48:32.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/24/690724/2/check/pmem-tempest-plugin-filtered/75483d3/ : POST_FAILURE in 6m 04s","accounts_in_message":[],"_revision_number":2},{"id":"d8dfdb7a13ab44964fc9bdb25e1e5fd69a6ce896","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-25 22:06:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/83efa56ce4cc45e68f7dbd174792373f : SUCCESS in 9m 42s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/60d47724424c47928726457eb2bf5f86 : SUCCESS in 12m 18s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/216c2973e99043198c989e29ccee052e : SUCCESS in 12m 56s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/6fa50d569c00407a9efe4941ab877c95 : SUCCESS in 6m 59s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/bdb582ba929d4b3a9e214c632514c906 : SUCCESS in 17m 19s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/16e6a44a706f48c8810d267c61fa4462 : SUCCESS in 18m 47s","accounts_in_message":[],"_revision_number":2},{"id":"9821e06c452b9e1d9a0809cab4d57c40ce44ab2a","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-11-25 23:14:16.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/690724/2 : FAILURE in 1h 14m 11s","accounts_in_message":[],"_revision_number":2},{"id":"629ca4969296666355407f7a437b04bbc3b8ebe6","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-12-12 18:34:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f5ec28e5acad9051f03467da559f3b76541e6f19","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-12 18:40:30.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0dcea2c3af1d936d934abd47516318cf13abaad0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-12 23:42:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"034ed93ab5e74285dc98d315289803f44bd78f44","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-12 23:42:33.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/76797e291ce341b3b759dac041eb284c : SUCCESS in 12m 46s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/bd120e99dccb4aab84798269a6e3b162 : SUCCESS in 17m 37s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/2648d9d0e7814e218a0a9c6fd53537ed : SUCCESS in 16m 25s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/c26c3c03224a425e95f604a4dda274d1 : SUCCESS in 10m 26s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/a72c1e66a61f48168e5e7056df2c6034 : SUCCESS in 21m 32s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/e3bbceaadcbe4d9083cb4b232665d097 : SUCCESS in 22m 58s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f03f5075e3751ccd03a60999eab1d7f4bf7c4f02","revisions":{"7f3ba78c27cc167c74b3ffd65e2ad2df9d736c36":{"kind":"REWORK","_number":1,"created":"2019-10-23 19:50:15.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/24/690724/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/24/690724/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/690724/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/690724/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/690724/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/24/690724/1"}}},"commit":{"parents":[{"commit":"c759de62534fad1a23400ff05811c9cfd8a02c67","subject":"Merge \"Explain nested guest support\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c759de62534fad1a23400ff05811c9cfd8a02c67"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-10-22 21:53:20.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-10-23 19:46:13.000000000","tz":-240},"subject":"Add functional regression test for bug 1849409","message":"Add functional regression test for bug 1849409\n\nChange I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab in Queens,\nwhich was backported through to Newton, introduced a regression\nwhen listing deleted servers with a marker because it assumes\nthat if BuildRequestList.get_by_filters does not raise\nMarkerNotFound that the marker was found among the build requests\nand does not account for that get_by_filters method short-circuiting\nif filtering servers with deleted/cleaned/limit\u003d0. The API code\nthen nulls out the marker which means you\u0027ll continue to get the\nmarker instance back in the results even though you shouldn\u0027t,\nand that can cause an infinite loop in some client-side tooling like\nnova\u0027s CLI:\n\n  nova list --deleted --limit -1\n\nThis adds a functional recreate test for the regression which will\nbe updated when the bug is fixed.\n\nNOTE(mriedem): In this backport the test is modified to create the\nserver with a specific network id to avoid a NetworkAmbiguous error\nwhich is probably due to some missing NeutronFixture sugar added\nin Rocky.\n\nChange-Id: I324193129acb6ac739133c7e76920762a8987a84\nRelated-Bug: #1849409\n(cherry picked from commit 45c2752f2ce08b314012eff044b01aa7d626b43d)\n(cherry picked from commit 727d942b2830fb6970d99507f2b5eb1a28df01b2)\n(cherry picked from commit 47caaccd4a03660d7df144f2eadd821d36baeaa8)\n(cherry picked from commit 56c5753747564c1a93958f3094785d2e8e4b6598)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7f3ba78c27cc167c74b3ffd65e2ad2df9d736c36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7f3ba78c27cc167c74b3ffd65e2ad2df9d736c36"}]},"branch":"refs/heads/stable/queens"},"f03f5075e3751ccd03a60999eab1d7f4bf7c4f02":{"kind":"REWORK","_number":2,"created":"2019-11-25 21:41:06.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/24/690724/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/24/690724/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/690724/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/690724/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/690724/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/24/690724/2"}}},"commit":{"parents":[{"commit":"4e9f85205697dfcc01e8cbccafa79eea45f34212","subject":"Don\u0027t delete compute node, when deleting service other than nova-compute","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4e9f85205697dfcc01e8cbccafa79eea45f34212"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-10-22 21:53:20.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-11-25 21:37:48.000000000","tz":-300},"subject":"Add functional regression test for bug 1849409","message":"Add functional regression test for bug 1849409\n\nChange I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab in Queens,\nwhich was backported through to Newton, introduced a regression\nwhen listing deleted servers with a marker because it assumes\nthat if BuildRequestList.get_by_filters does not raise\nMarkerNotFound that the marker was found among the build requests\nand does not account for that get_by_filters method short-circuiting\nif filtering servers with deleted/cleaned/limit\u003d0. The API code\nthen nulls out the marker which means you\u0027ll continue to get the\nmarker instance back in the results even though you shouldn\u0027t,\nand that can cause an infinite loop in some client-side tooling like\nnova\u0027s CLI:\n\n  nova list --deleted --limit -1\n\nThis adds a functional recreate test for the regression which will\nbe updated when the bug is fixed.\n\nNOTE(mriedem): In this backport the test is modified to create the\nserver without networking to avoid a NetworkAmbiguous error\nwhich is probably due to some missing NeutronFixture sugar added\nin Rocky.\n\nChange-Id: I324193129acb6ac739133c7e76920762a8987a84\nRelated-Bug: #1849409\n(cherry picked from commit 45c2752f2ce08b314012eff044b01aa7d626b43d)\n(cherry picked from commit 727d942b2830fb6970d99507f2b5eb1a28df01b2)\n(cherry picked from commit 47caaccd4a03660d7df144f2eadd821d36baeaa8)\n(cherry picked from commit 08337cccb060d0b3cad388004c1f802d5d053813)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f03f5075e3751ccd03a60999eab1d7f4bf7c4f02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f03f5075e3751ccd03a60999eab1d7f4bf7c4f02"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}