)]}'
{"id":"openstack%2Fnova~690746","triplet_id":"openstack%2Fnova~stable%2Focata~I324193129acb6ac739133c7e76920762a8987a84","project":"openstack/nova","branch":"stable/ocata","topic":"bug/1849409","hashtags":[],"change_id":"I324193129acb6ac739133c7e76920762a8987a84","subject":"Add functional regression test for bug 1849409","status":"MERGED","created":"2019-10-23 20:52:04.000000000","updated":"2020-03-19 21:09:28.000000000","submitted":"2020-03-19 21:09:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"690746-1584652168551-fcd7e5da","meta_rev_id":"6adcdff24693ebf255e704d07acdffd444298de2","_number":690746,"virtual_id_number":690746,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-19 21:09:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-12-06 01:03:30.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"date":"2019-12-06 02:21:33.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2020-01-17 15:34:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2020-03-19 16:23:53.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":1,"date":"2020-03-19 16:23:53.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-23 20:52:31.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-06 02:21:33.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-01-17 15:34:46.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-03-19 16:23:53.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-03-19 21:09:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c21fc6e31dd684566890263c788052815b89c9a6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-23 20:52:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"166dfbc3820443eeae536471ae6ce5821028690d","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-10-23 20:52:31.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0bbefbbff611460f6834a04f7682bb8180a2e7f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-24 00:01:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/83d5cffd6eb2403a92a6a9b10a874f76 : SUCCESS in 5m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e4f6c4d44eb84902be37f04c31afe5f7 : SUCCESS in 13m 08s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/022a9bc6cdfd478d8c9041ff90e20a7a : SUCCESS in 10m 36s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/76cd5dd96bac48d791c9c97edb17020e : SUCCESS in 5m 45s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/e3355850512546259fc4fbe5d570341a : SUCCESS in 1h 37m 47s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/3866929ca17d4d12ba24f38942a2761f : SUCCESS in 19m 05s","accounts_in_message":[],"_revision_number":1},{"id":"490e4917f1f02001a706e3143202257178f7ca95","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-10-24 00:22:11.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/690746/1 : FAILURE in 1h 10m 10s","accounts_in_message":[],"_revision_number":1},{"id":"eb53f4bcd076508fe7b1d55c5ca7e2f94a527454","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-28 15:37:48.000000000","message":"Patch Set 1: Workflow-1\n\nThis will have to be redone since the Rocky backport changed.","accounts_in_message":[],"_revision_number":1},{"id":"b72f29d30e4127a22d4fde719ce617f972add48c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-12-05 17:54:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"81a75b697b9f43f4df2a1c54c6bc5d00cba8a6fd","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-12-05 19:28:17.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/690746/2 : FAILURE in 25m 01s","accounts_in_message":[],"_revision_number":2},{"id":"fd71841aa39659d30cfc7cdc8f45760c5c3deb16","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-05 20:07:00.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8e7477d65e8840e992d52e0f130e49cb : SUCCESS in 7m 03s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/080c456079684915ab5dc29509b59b0b : SUCCESS in 15m 19s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/5076f13ec7964e30ac16312a092b9213 : SUCCESS in 16m 38s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/a944554cb6414e72b82ec6ef3ce6c793 : SUCCESS in 6m 16s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/6eb1aadb673247749dfffc4d7b720cb3 : FAILURE in 1h 30m 58s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/e418b1e496004147bc8a24535b27b285 : SUCCESS in 26m 14s","accounts_in_message":[],"_revision_number":2},{"id":"97850121fa624bc6c384f8f1494ae817156ee6ec","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-12-06 01:03:30.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"39d604b0d4cd96db4bff0f9678dcef70e0ca86f4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-06 02:16:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/037640beef8d4a09b1abe341f91ff7c3 : SUCCESS in 5m 01s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c09b24460c814c6c81b07a4f904a66c7 : SUCCESS in 11m 32s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/b413256ab0274a3f96658bb2f8e2f3a3 : SUCCESS in 11m 54s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/7afc9e791a58446aae1b3af8797da4e3 : SUCCESS in 5m 29s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/c740f2eed4c9437481718d1caed59241 : SUCCESS in 1h 11m 09s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/2886124e46f64f6ea6f2331548483cc2 : SUCCESS in 18m 40s","accounts_in_message":[],"_revision_number":2},{"id":"a9aad968259566b07cbc37478f42a615a301e176","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-12-06 02:21:33.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/690746/2 : FAILURE in 23m 22s","accounts_in_message":[],"_revision_number":2},{"id":"fd60642f76162df85c8145bf9e475b77d3dbfd2d","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-01-17 15:34:46.000000000","message":"Patch Set 2: Code-Review+2\n\nThe backport looks good to me:\n* changes noted in commit message\n* merged in Pike","accounts_in_message":[],"_revision_number":2},{"id":"7679493ef9350c93cd42e1b47771523332bf4c78","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-03-19 16:23:53.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM.","accounts_in_message":[],"_revision_number":2},{"id":"663b972e8e1047f06b26253addf3dbd63e7ea730","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-19 16:24:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a564dd33a2ebc64d1971be35ac3d5e41169e53af","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-19 21:09:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/60464e12b1594e4786fd62de329b2355 : SUCCESS in 6m 56s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2011a9fee60243739c81d1c0ce05aeeb : SUCCESS in 14m 16s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/11d315abb00744d9beebd765aa31d475 : SUCCESS in 18m 39s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/28835ad774614be196fb16fdc94dcf1d : SUCCESS in 6m 23s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/f3ef092371e04d8685d3c97f29cc1dd4 : SUCCESS in 1h 28m 34s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/9fad6fdc083e4fb7a45b9e9dd0f40129 : SUCCESS in 23m 15s","accounts_in_message":[],"_revision_number":2},{"id":"5f4ecaa896d7e809c6a43f4ff7eb104deb2a7076","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-19 21:09:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b6c7456face630086a0eb7fd1c8335d42ab0456a","revisions":{"8aa3aa809c3040882772e9d1dec55a559633044e":{"kind":"REWORK","_number":1,"created":"2019-10-23 20:52:04.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/46/690746/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/46/690746/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/690746/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/690746/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/690746/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/46/690746/1"}}},"commit":{"parents":[{"commit":"02ea2c25eddebdc220d66e4a01d8deded7c77a57","subject":"Replace non-nova server fault message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/02ea2c25eddebdc220d66e4a01d8deded7c77a57"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-10-22 21:53:20.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-10-23 20:48:31.000000000","tz":-240},"subject":"Add functional regression test for bug 1849409","message":"Add functional regression test for bug 1849409\n\nChange I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab in Queens,\nwhich was backported through to Newton, introduced a regression\nwhen listing deleted servers with a marker because it assumes\nthat if BuildRequestList.get_by_filters does not raise\nMarkerNotFound that the marker was found among the build requests\nand does not account for that get_by_filters method short-circuiting\nif filtering servers with deleted/cleaned/limit\u003d0. The API code\nthen nulls out the marker which means you\u0027ll continue to get the\nmarker instance back in the results even though you shouldn\u0027t,\nand that can cause an infinite loop in some client-side tooling like\nnova\u0027s CLI:\n\n  nova list --deleted --limit -1\n\nThis adds a functional recreate test for the regression which will\nbe updated when the bug is fixed.\n\nNOTE(mriedem): In this backport the test is modified to disable the\nDiskFilter since we\u0027re using Placement for filtering on DISK_GB.\nAlso, _wait_until_deleted is moved to InstanceHelperMixin since\nIf7b02bcd8d77e94c7fb42b721792c1391bc0e3b7 is not in Ocata.\n\nChange-Id: I324193129acb6ac739133c7e76920762a8987a84\nRelated-Bug: #1849409\n(cherry picked from commit 45c2752f2ce08b314012eff044b01aa7d626b43d)\n(cherry picked from commit 727d942b2830fb6970d99507f2b5eb1a28df01b2)\n(cherry picked from commit 47caaccd4a03660d7df144f2eadd821d36baeaa8)\n(cherry picked from commit 56c5753747564c1a93958f3094785d2e8e4b6598)\n(cherry picked from commit 7f3ba78c27cc167c74b3ffd65e2ad2df9d736c36)\n(cherry picked from commit d24cef6acb5d949e97e4c000adc59a146563d82e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8aa3aa809c3040882772e9d1dec55a559633044e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8aa3aa809c3040882772e9d1dec55a559633044e"}]},"branch":"refs/heads/stable/ocata"},"b6c7456face630086a0eb7fd1c8335d42ab0456a":{"kind":"REWORK","_number":2,"created":"2019-12-05 17:54:46.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/46/690746/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/46/690746/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/690746/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/690746/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/690746/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/46/690746/2"}}},"commit":{"parents":[{"commit":"ab3dd99fa58d100b619435a3a16d34d21fee379a","subject":"Merge \"Do not persist RequestSpec.ignore_hosts\" into stable/ocata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ab3dd99fa58d100b619435a3a16d34d21fee379a"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-10-22 21:53:20.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-12-05 17:53:42.000000000","tz":-300},"subject":"Add functional regression test for bug 1849409","message":"Add functional regression test for bug 1849409\n\nChange I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab in Queens,\nwhich was backported through to Newton, introduced a regression\nwhen listing deleted servers with a marker because it assumes\nthat if BuildRequestList.get_by_filters does not raise\nMarkerNotFound that the marker was found among the build requests\nand does not account for that get_by_filters method short-circuiting\nif filtering servers with deleted/cleaned/limit\u003d0. The API code\nthen nulls out the marker which means you\u0027ll continue to get the\nmarker instance back in the results even though you shouldn\u0027t,\nand that can cause an infinite loop in some client-side tooling like\nnova\u0027s CLI:\n\n  nova list --deleted --limit -1\n\nThis adds a functional recreate test for the regression which will\nbe updated when the bug is fixed.\n\nNOTE(mriedem): In this backport the test is modified to disable the\nDiskFilter since we\u0027re using Placement for filtering on DISK_GB.\nAlso, _wait_until_deleted is moved to InstanceHelperMixin since\nIf7b02bcd8d77e94c7fb42b721792c1391bc0e3b7 is not in Ocata.\n\nChange-Id: I324193129acb6ac739133c7e76920762a8987a84\nRelated-Bug: #1849409\n(cherry picked from commit 45c2752f2ce08b314012eff044b01aa7d626b43d)\n(cherry picked from commit 727d942b2830fb6970d99507f2b5eb1a28df01b2)\n(cherry picked from commit 47caaccd4a03660d7df144f2eadd821d36baeaa8)\n(cherry picked from commit 08337cccb060d0b3cad388004c1f802d5d053813)\n(cherry picked from commit f03f5075e3751ccd03a60999eab1d7f4bf7c4f02)\n(cherry picked from commit e2ba87cb7b1cfd4226cfd8028436ecf87ad8a2be)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b6c7456face630086a0eb7fd1c8335d42ab0456a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b6c7456face630086a0eb7fd1c8335d42ab0456a"}]},"branch":"refs/heads/stable/ocata"}},"requirements":[],"submit_records":[],"submit_requirements":[]}