)]}'
{"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5278c7ea688d3bea604c75099ce140958d07e4fb","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        self._vc_state \u003d self._resources.get(first_cluster).get(\u0027vcstate\u0027)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def list_instances(self):"},{"line_number":393,"context_line":"        \"\"\"List VM instances from all nodes.\"\"\""},{"line_number":394,"context_line":"        instances \u003d []"},{"line_number":395,"context_line":"        nodes \u003d self.get_available_nodes()"},{"line_number":396,"context_line":"        for node in nodes:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2Fg%2FY%3D","line":393,"updated":"2014-02-26 07:09:51.000000000","message":"Maybe just elaborate here a little that this will be only for the configured clusters on this node.","commit_id":"c394428869220031b70c277e03600372846a5802"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ae9b3e9e44b128b3c37a6fe5ab427faef55b047a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \"\"\"Lists the VM instances that are registered with the ESX host"},{"line_number":105,"context_line":"        or vCenter cluster."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        properties \u003d [\u0027name\u0027, \u0027runtime.connectionState\u0027]"},{"line_number":108,"context_line":"        if self._cluster:"},{"line_number":109,"context_line":"            LOG.debug(_(\"Getting list of instances from cluster %s\"),"},{"line_number":110,"context_line":"                      self._cluster)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FEaw%3D","line":107,"updated":"2014-03-10 08:09:59.000000000","message":"Maybe consider doing the following: have a helper function that will return the VM\u0027s for the ESX (in VMwareVMOps) and one that will return the VM\u0027s for the VC (in VMwareVCVMOps). \nIt will save the if on line 108 and make the code easier to test and follow.","commit_id":"6b63865aa73e4a70b4a3f997e1428c03c7f23d73"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"0bb62c88f8cf59a6a63628bd9ed5c0209287b7f5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \"\"\"Lists the VM instances that are registered with the ESX host"},{"line_number":105,"context_line":"        or vCenter cluster."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        properties \u003d [\u0027name\u0027, \u0027runtime.connectionState\u0027]"},{"line_number":108,"context_line":"        if self._cluster:"},{"line_number":109,"context_line":"            LOG.debug(_(\"Getting list of instances from cluster %s\"),"},{"line_number":110,"context_line":"                      self._cluster)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FUMI%3D","line":107,"in_reply_to":"AAAAVn%2F%2FBzk%3D","updated":"2014-03-18 17:12:55.000000000","message":"Done","commit_id":"6b63865aa73e4a70b4a3f997e1428c03c7f23d73"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"e949eb73739f33629474c0411246b92e75f5bf6d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \"\"\"Lists the VM instances that are registered with the ESX host"},{"line_number":105,"context_line":"        or vCenter cluster."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        properties \u003d [\u0027name\u0027, \u0027runtime.connectionState\u0027]"},{"line_number":108,"context_line":"        if self._cluster:"},{"line_number":109,"context_line":"            LOG.debug(_(\"Getting list of instances from cluster %s\"),"},{"line_number":110,"context_line":"                      self._cluster)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAVn%2F%2FBzk%3D","line":107,"in_reply_to":"AAAAVn%2F%2FEaw%3D","updated":"2014-03-10 15:44:58.000000000","message":"Hi Gary, thanks for the suggestion, I will do.","commit_id":"6b63865aa73e4a70b4a3f997e1428c03c7f23d73"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2f8da1fe4cadea56928cb64f816ad6d24ceac910","unresolved":false,"context_lines":[{"line_number":1744,"context_line":"                \u0027VirtualMachine\u0027, properties)"},{"line_number":1745,"context_line":"        lst_vm_names \u003d self._get_valid_vms_from_retrieve_result(vms)"},{"line_number":1746,"context_line":""},{"line_number":1747,"context_line":"        LOG.debug(_(\"Got total of %s instances\") % str(len(lst_vm_names)))"},{"line_number":1748,"context_line":"        return lst_vm_names"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2FNeM%3D","line":1747,"updated":"2014-03-19 12:38:36.000000000","message":"please use a , instead of the %","commit_id":"2fc4091a61d609d4a1a6d7fefab0cacb341034b2"}]}