)]}'
{"tools/xenserver/vdi-reaper.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"41b8cd5ce914824acc66f49b35b042a31b527ee5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                        print \"Skipping %s: belongs to instance %s (%s)\" % ("},{"line_number":134,"context_line":"                                vm_vdi_uuid, vm_rec[\"uuid\"],"},{"line_number":135,"context_line":"                                vm_rec[\"name_label\"])"},{"line_number":136,"context_line":"                        vdis.remove((vbd_rec[\"VDI\"], vm_vdi_uuid))"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    destroy_orphaned_vdis(options, session, vdis)"},{"line_number":139,"context_line":"    session.xenapi.session.logout()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F%2Ba8%3D","line":136,"updated":"2011-09-27 20:34:38.000000000","message":"Lots of nested stuff here.  Make easier to read?","commit_id":"fd05c9ecf08ac64e17a40fe318ddb29d590cd8cc"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"311e4bde562d8662a6d55112b5c29ebe6dfc1e29","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    parser.add_option(\"--url\", default\u003dNone, help\u003d\"XenAPI URL\")"},{"line_number":29,"context_line":"    parser.add_option(\"--username\", default\u003dNone, help\u003d\"XenAPI username\")"},{"line_number":30,"context_line":"    parser.add_option(\"--password\", default\u003dNone, help\u003d\"XenAPI password\")"},{"line_number":31,"context_line":"    parser.add_option(\"--seriously\", action\u003d\"store_true\","},{"line_number":32,"context_line":"            help\u003d\"Do it for real\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    return parser.parse_args()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F%2BZQ%3D","line":31,"updated":"2011-09-27 22:08:09.000000000","message":"`--seriously` might look a little out-of-place to an admin; might be better named -`-commit`.\n\nAnother way to handle this might be to use positional arguments; no arguments would just print the help text, \u0027list\u0027 would \u0027list\u0027 out the orphaned vdis, and \u0027reap\u0027 would actually perform the reaping.","commit_id":"bbad857d781989773da81ea155e7c4ffd7ebfda9"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"311e4bde562d8662a6d55112b5c29ebe6dfc1e29","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    vm_rec[\"uuid\"], vm_rec[\"name_label\"])"},{"line_number":123,"context_line":"            vdis.remove((vbd_rec[\"VDI\"], vm_vdi_uuid))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    return vdis"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F%2BZY%3D","line":125,"updated":"2011-09-27 22:08:09.000000000","message":"Since `remove_active_vdis` is mutating the `vdis` list, you technically shouldn\u0027t have to return the `vdi` list (the caller already has it.\n\nIt might be a little confusing to return it here because it implies like a new list is created.","commit_id":"bbad857d781989773da81ea155e7c4ffd7ebfda9"}]}