)]}'
{"nova/virt/libvirt/migration.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3043b79e4b144bbf0625731e1623dfd5b668ecce","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        for index, dest_interface_subelem in enumerate(dest_interface_elem):"},{"line_number":376,"context_line":"            # NOTE(artom) DNM: don\u0027t insert the MTU at all to break the live"},{"line_number":377,"context_line":"            # migration on purpose"},{"line_number":378,"context_line":"            if dest_interface_subelem.tag \u003d\u003d \u0027mtu\u0027::"},{"line_number":379,"context_line":"                continue"},{"line_number":380,"context_line":"            interface_dev.insert(index, dest_interface_subelem)"},{"line_number":381,"context_line":"        # And finally re-insert the hw address."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4a80974a","line":378,"range":{"start_line":378,"start_character":50,"end_line":378,"end_character":52},"updated":"2019-11-05 16:46:59.000000000","message":"Won\u0027t this just result in a syntax/parse error?","commit_id":"cd50985cd50304e9df4491a685b1f4d76bd4ba39"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2a7d69b8feef8878d77a5c637ed2c9762a04cd25","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        for index, dest_interface_subelem in enumerate(dest_interface_elem):"},{"line_number":376,"context_line":"            # NOTE(artom) DNM: don\u0027t insert the MTU at all to break the live"},{"line_number":377,"context_line":"            # migration on purpose"},{"line_number":378,"context_line":"            if dest_interface_subelem.tag \u003d\u003d \u0027mtu\u0027::"},{"line_number":379,"context_line":"                continue"},{"line_number":380,"context_line":"            interface_dev.insert(index, dest_interface_subelem)"},{"line_number":381,"context_line":"        # And finally re-insert the hw address."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_cae24703","line":378,"range":{"start_line":378,"start_character":50,"end_line":378,"end_character":52},"in_reply_to":"3fa7e38b_4a80974a","updated":"2019-11-05 16:58:41.000000000","message":"gdi","commit_id":"cd50985cd50304e9df4491a685b1f4d76bd4ba39"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"564bf90fdf8de1023a6cd9937bbb7bf31a709f6c","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        for index, dest_interface_subelem in enumerate(dest_interface_elem):"},{"line_number":376,"context_line":"            # NOTE(artom) DNM: don\u0027t insert the MTU at all to break the live"},{"line_number":377,"context_line":"            # migration on purpose"},{"line_number":378,"context_line":"            if dest_interface_subelem.tag \u003d\u003d \u0027mtu\u0027:"},{"line_number":379,"context_line":"                continue"},{"line_number":380,"context_line":"            interface_dev.insert(index, dest_interface_subelem)"},{"line_number":381,"context_line":"        # And finally re-insert the hw address."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_988ee5cf","line":378,"updated":"2019-11-05 19:37:48.000000000","message":"We likely don\u0027t have mtu stuff set in the gate runs. You probably need an if/else condition for whether or not mtu is specified because if it\u0027s not (in the gate) then you would write a bogus mtu element that will break since the dest isn\u0027t expecting it.","commit_id":"d81bd4e25ebc740ebcff77922ea65c59971ee8ba"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"fae8d529f8c716f363220f6faeff7ae2abb8a255","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        for index, dest_interface_subelem in enumerate(dest_interface_elem):"},{"line_number":376,"context_line":"            # NOTE(artom) DNM: don\u0027t insert the MTU at all to break the live"},{"line_number":377,"context_line":"            # migration on purpose"},{"line_number":378,"context_line":"            if dest_interface_subelem.tag \u003d\u003d \u0027mtu\u0027:"},{"line_number":379,"context_line":"                continue"},{"line_number":380,"context_line":"            interface_dev.insert(index, dest_interface_subelem)"},{"line_number":381,"context_line":"        # And finally re-insert the hw address."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f81d9977","line":378,"in_reply_to":"3fa7e38b_988ee5cf","updated":"2019-11-05 19:49:10.000000000","message":"We do - I made a point of checking before embarking on this. For example from [1] that merged recently, when we build the instance there\u0027s an MTU [2] and when we live migrate is there\u0027s an MTU as well [3].\n\nAnd even in this run - there\u0027s an MTU when we boot the instance [4], but it\u0027s still there when we live migrate it [5]. So I guess I\u0027m doing something wrong with how I remove it.\n\n[1] https://review.opendev.org/#/c/692206/\n[2] https://zuul.opendev.org/t/openstack/build/17894a8202d0452cb1a16c085ef916a8/log/logs/screen-n-cpu.txt.gz#2279\n[3] https://zuul.opendev.org/t/openstack/build/17894a8202d0452cb1a16c085ef916a8/log/logs/screen-n-cpu.txt.gz#2659\n\n[4] https://zuul.opendev.org/t/openstack/build/c65b192d635d468ba23629f64cfbd155/log/logs/screen-n-cpu.txt.gz#2254\n[5] https://zuul.opendev.org/t/openstack/build/c65b192d635d468ba23629f64cfbd155/log/logs/screen-n-cpu.txt.gz#2638","commit_id":"d81bd4e25ebc740ebcff77922ea65c59971ee8ba"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"79554455ba3deec69e1920f80889e8ee339408f6","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        for index, dest_interface_subelem in enumerate(dest_interface_elem):"},{"line_number":376,"context_line":"            # NOTE(artom) DNM: don\u0027t insert the MTU at all to break the live"},{"line_number":377,"context_line":"            # migration on purpose"},{"line_number":378,"context_line":"            if dest_interface_subelem.tag \u003d\u003d \u0027mtu\u0027:"},{"line_number":379,"context_line":"                continue"},{"line_number":380,"context_line":"            interface_dev.insert(index, dest_interface_subelem)"},{"line_number":381,"context_line":"        # And finally re-insert the hw address."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9346c650","line":378,"in_reply_to":"3fa7e38b_f81d9977","updated":"2019-11-05 19:58:49.000000000","message":"Wait, that \"Updating guest XML with vif config\" line is from before we do any updating. Either I\u0027m updating incorrectly, or the lack of MTU isn\u0027t causing the desired effect.","commit_id":"d81bd4e25ebc740ebcff77922ea65c59971ee8ba"}]}