)]}'
{"nova/api/openstack/compute/contrib/flavorextraspecs.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"bcefde74991a4e8946fa282bd02a70b2ebb023ff","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _handle_quota_error(self, error):"},{"line_number":111,"context_line":"        \"\"\"Reraise quota errors as api-specific http exceptions.\"\"\""},{"line_number":112,"context_line":"        if type(error) \u003d\u003d exception.MetadataLimitExceeded:"},{"line_number":113,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derror.message)"},{"line_number":114,"context_line":"        raise error"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAHH%2F%2F9cc%3D","line":112,"updated":"2012-05-02 15:17:37.000000000","message":"It\u0027s discouraged to compare types directly. Using isinstance() is preferred.\n\nBut I think this function is a mistake. The places that call _handle_quota_error should just catch the exception there instead of awkwardly handling matching exceptions in a function.","commit_id":"5921ff657bf378968578a3283f490716f96037e7"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"364ea5f0ee939a297958a4425a8e933d7d562a3b","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _handle_quota_error(self, error):"},{"line_number":111,"context_line":"        \"\"\"Reraise quota errors as api-specific http exceptions.\"\"\""},{"line_number":112,"context_line":"        if type(error) \u003d\u003d exception.MetadataLimitExceeded:"},{"line_number":113,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derror.message)"},{"line_number":114,"context_line":"        raise error"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAHH%2F%2F9cA%3D","line":112,"in_reply_to":"AAAAHH%2F%2F9cc%3D","updated":"2012-05-02 15:20:24.000000000","message":"agreed, on it","commit_id":"5921ff657bf378968578a3283f490716f96037e7"}],"nova/compute/api.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"b0cdc9b9f60c85cab915d7a9deac4551b65e39de","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                msg \u003d _(\"Metadata property key or value greater than 255 \""},{"line_number":232,"context_line":"                        \"characters\")"},{"line_number":233,"context_line":"                LOG.warn(msg)"},{"line_number":234,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def _check_requested_networks(self, context, requested_networks):"},{"line_number":237,"context_line":"        \"\"\" Check if the networks requested belongs to the project"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAHH%2F%2F9cI%3D","line":234,"updated":"2012-05-02 15:20:51.000000000","message":"Should we be throwing HTTP errors in compute.api? I don\u0027t think so. This should be intercepted and converted in nova.os.openstack.api (it will also likely affect the EC2 binding, yes?)","commit_id":"5921ff657bf378968578a3283f490716f96037e7"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"eed68a07969e38defa3588724e634168a35c1e3d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                msg \u003d _(\"Metadata property key or value greater than 255 \""},{"line_number":232,"context_line":"                        \"characters\")"},{"line_number":233,"context_line":"                LOG.warn(msg)"},{"line_number":234,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def _check_requested_networks(self, context, requested_networks):"},{"line_number":237,"context_line":"        \"\"\" Check if the networks requested belongs to the project"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAHH%2F%2F9a0%3D","line":234,"in_reply_to":"AAAAHH%2F%2F9cI%3D","updated":"2012-05-02 16:03:26.000000000","message":"agreed, ec2 doesn\u0027t pass in any metadata so I don\u0027t think that is a concern.","commit_id":"5921ff657bf378968578a3283f490716f96037e7"}]}