)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41198d720438ac7b5213fcfeb286e221c04c8551","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems that during refactoring the code related to rng device ended up"},{"line_number":10,"context_line":"in the wrong method. This change moves the code to the method that"},{"line_number":11,"context_line":"actually handles rng device. The behavior does not change, the change is"},{"line_number":12,"context_line":"only cosmetic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1473c8d55b0ecfa33d432b409e651d933f5947a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_1cf65b92","line":12,"range":{"start_line":11,"start_character":29,"end_line":12,"end_character":14},"updated":"2019-11-06 17:13:49.000000000","message":"this actully does change the behavior\ni think it will fix https://bugs.launchpad.net/nova/+bug/1851497","commit_id":"2cb6331aa80d4ed118f3dfeb1f85a3561827b809"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb770188ebddaedc4049094f473dc1116f2bd110","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems that during refactoring the code related to rng device ended up"},{"line_number":10,"context_line":"in the wrong method. This change moves the code to the method that"},{"line_number":11,"context_line":"actually handles rng device. The behavior does not change, the change is"},{"line_number":12,"context_line":"only cosmetic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1473c8d55b0ecfa33d432b409e651d933f5947a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_1e18761c","line":12,"range":{"start_line":11,"start_character":29,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_0ac84d54","updated":"2019-11-08 12:44:31.000000000","message":"oh you are right.\ni missed the lack of indentation.","commit_id":"2cb6331aa80d4ed118f3dfeb1f85a3561827b809"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"38a50febf9c3525f16c536176de63d9aabc25755","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems that during refactoring the code related to rng device ended up"},{"line_number":10,"context_line":"in the wrong method. This change moves the code to the method that"},{"line_number":11,"context_line":"actually handles rng device. The behavior does not change, the change is"},{"line_number":12,"context_line":"only cosmetic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1473c8d55b0ecfa33d432b409e651d933f5947a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_0ac84d54","line":12,"range":{"start_line":11,"start_character":29,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_1cf65b92","updated":"2019-11-06 19:23:14.000000000","message":"i think this is wrong. The rng-related code was never inside the `if image_meta.properties.get(\u0027hw_qemu_guest_agent\u0027, False):`, it was outside of that block, and was always ran. If you still disagree, maybe i could write a test to demo?","commit_id":"2cb6331aa80d4ed118f3dfeb1f85a3561827b809"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb4185cc79f1d3d221754949be43be2b64187741","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems that during refactoring the code related to rng device ended up"},{"line_number":10,"context_line":"in the wrong method. This change moves the code to the method that"},{"line_number":11,"context_line":"actually handles rng device. The behavior does not change, the change is"},{"line_number":12,"context_line":"only cosmetic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1473c8d55b0ecfa33d432b409e651d933f5947a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_9ea786bd","line":12,"range":{"start_line":11,"start_character":29,"end_line":12,"end_character":14},"in_reply_to":"3fa7e38b_1e18761c","updated":"2019-11-08 12:49:48.000000000","message":"given this change did not break any of the unit tests and you passed a new parmater to the function it might indicate a lack of test so it would not hurt to add one for the behavior of _add_rng_device. if you do that can you move the comment i noted on the other file too.\n\nbut in general ya i think this is fine","commit_id":"2cb6331aa80d4ed118f3dfeb1f85a3561827b809"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41198d720438ac7b5213fcfeb286e221c04c8551","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in the wrong method. This change moves the code to the method that"},{"line_number":11,"context_line":"actually handles rng device. The behavior does not change, the change is"},{"line_number":12,"context_line":"only cosmetic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1473c8d55b0ecfa33d432b409e651d933f5947a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_1c241b0e","line":13,"updated":"2019-11-06 17:13:49.000000000","message":"you need a closes bug line\n\nCloses-Bug: #1851497","commit_id":"2cb6331aa80d4ed118f3dfeb1f85a3561827b809"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb4185cc79f1d3d221754949be43be2b64187741","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in the wrong method. This change moves the code to the method that"},{"line_number":11,"context_line":"actually handles rng device. The behavior does not change, the change is"},{"line_number":12,"context_line":"only cosmetic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1473c8d55b0ecfa33d432b409e651d933f5947a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7e8e4a33","line":13,"in_reply_to":"3fa7e38b_1c241b0e","updated":"2019-11-08 12:49:48.000000000","message":"im going to clode this bug since it actully was doint the right thing before it was just confusinly grouped","commit_id":"2cb6331aa80d4ed118f3dfeb1f85a3561827b809"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41198d720438ac7b5213fcfeb286e221c04c8551","unresolved":false,"context_lines":[{"line_number":5721,"context_line":"            if caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":5722,"context_line":"                self._guest_add_usb_host_keyboard(guest)"},{"line_number":5723,"context_line":""},{"line_number":5724,"context_line":"        # Qemu guest agent only support \u0027qemu\u0027 and \u0027kvm\u0027 hypervisor"},{"line_number":5725,"context_line":"        if virt_type in (\u0027qemu\u0027, \u0027kvm\u0027):"},{"line_number":5726,"context_line":"            self._set_qemu_guest_agent(guest, flavor, instance, image_meta)"},{"line_number":5727,"context_line":"            self._add_rng_device(guest, flavor, image_meta)"},{"line_number":5728,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9c100bae","line":5725,"range":{"start_line":5724,"start_character":7,"end_line":5725,"end_character":40},"updated":"2019-11-06 17:13:49.000000000","message":"so this comment is still wrong. \nit should be on the self._set_qemu_guest_agent(guest, flavor, instance, image_meta)\nline below.\n\nyou un did the incorrect change form \n\nhttps://github.com/openstack/nova/commit/be548a3396ee5f3a78b2b8b59321eb4c4530f7fb\n\nby moving the random number generator code our of the\n_set_qemu_guest_agent code back to where it should be in the\n\nqemu/kvm if independent of if the qemu geust agent is used.\n\nwe should add unit tests at a minium to assert that you can enable and disable the rng independently of the qemu guest agent.","commit_id":"2cb6331aa80d4ed118f3dfeb1f85a3561827b809"}]}