)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"dce74b8196d1fd34ba8e8ba0e7c4780cf926cebf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use openstack server create --boot-from-volume in test_evacuate.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The openstack server create command now has a --boot-from-volume"},{"line_number":10,"context_line":"option so we can use that in the test_evacuate.sh script instead"},{"line_number":11,"context_line":"of using the nova boot command."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0b70b19d74007041fc2da55a4edb1c636af691d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_8e59a35c","line":10,"range":{"start_line":9,"start_character":36,"end_line":10,"end_character":6},"updated":"2019-11-07 18:47:55.000000000","message":"Commit b9d63105566c84db11a976846844ad7b3a0b331e for the record, which got release in 4.0.0/Train [1]\n\n[1] https://docs.openstack.org/releasenotes/python-openstackclient/train.html#relnotes-4-0-0-stable-train","commit_id":"6cf5bc8bf7dc05552357d65b7108ff32645bfe53"}],"gate/test_evacuate.sh":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"dce74b8196d1fd34ba8e8ba0e7c4780cf926cebf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"--nic net-id\u003d${network_id} --availability-zone nova:${subnode} --wait evacuate-test"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"echo \"Creating BFV test server on subnode\""},{"line_number":53,"context_line":"openstack server create --flavor ${flavor_id} --wait --boot-from-volume 1 \\"},{"line_number":54,"context_line":"--nic net-id\u003d${network_id} --availability-zone nova:${subnode} evacuate-bfv-test"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_ce155b4b","line":53,"updated":"2019-11-07 18:47:55.000000000","message":"Do we not also need --image here?","commit_id":"6cf5bc8bf7dc05552357d65b7108ff32645bfe53"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ce28966483a0cb98c2b4aadbd85ea0b7bd79e00","unresolved":false,"context_lines":[{"line_number":50,"context_line":"--nic net-id\u003d${network_id} --availability-zone nova:${subnode} --wait evacuate-test"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"echo \"Creating BFV test server on subnode\""},{"line_number":53,"context_line":"openstack server create --flavor ${flavor_id} --wait --boot-from-volume 1 \\"},{"line_number":54,"context_line":"--nic net-id\u003d${network_id} --availability-zone nova:${subnode} evacuate-bfv-test"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_910c623a","line":53,"in_reply_to":"3fa7e38b_ce155b4b","updated":"2019-11-07 18:48:50.000000000","message":"gdi yes","commit_id":"6cf5bc8bf7dc05552357d65b7108ff32645bfe53"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bdbf141f9a74fcf566746b0f56cce2cab8ce6b40","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# TODO(mriedem): Use OSC when it supports boot from volume where nova creates"},{"line_number":54,"context_line":"# the root volume from an image."},{"line_number":55,"context_line":"nova boot --flavor ${flavor_id} --poll \\"},{"line_number":56,"context_line":"--block-device id\u003d${image_id},source\u003dimage,dest\u003dvolume,size\u003d1,bootindex\u003d0,shutdown\u003dremove \\"},{"line_number":57,"context_line":"--nic net-id\u003d${network_id} --availability-zone nova:${subnode} evacuate-bfv-test"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_918ea230","side":"PARENT","line":56,"range":{"start_line":56,"start_character":74,"end_line":56,"end_character":89},"updated":"2019-11-07 19:17:23.000000000","message":"...but I\u0027m not sure about this. Do we need to add extra flaggage here, or a separate cleanup step, to get the volume removed?","commit_id":"f28839b523186121b6481e607321ddbff370cfc5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bdbf141f9a74fcf566746b0f56cce2cab8ce6b40","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# TODO(mriedem): Use OSC when it supports boot from volume where nova creates"},{"line_number":54,"context_line":"# the root volume from an image."},{"line_number":55,"context_line":"nova boot --flavor ${flavor_id} --poll \\"},{"line_number":56,"context_line":"--block-device id\u003d${image_id},source\u003dimage,dest\u003dvolume,size\u003d1,bootindex\u003d0,shutdown\u003dremove \\"},{"line_number":57,"context_line":"--nic net-id\u003d${network_id} --availability-zone nova:${subnode} evacuate-bfv-test"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_b1a71ebd","side":"PARENT","line":56,"range":{"start_line":56,"start_character":30,"end_line":56,"end_character":73},"updated":"2019-11-07 19:17:23.000000000","message":"per [1] this all appears to be accounted for by --boot-from-volume...\n\n[1] https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#cmdoption-openstack-server-create-boot-from-volume","commit_id":"f28839b523186121b6481e607321ddbff370cfc5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0638af6d9a801e7a1254a5fcbadd4e112c979f00","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# TODO(mriedem): Use OSC when it supports boot from volume where nova creates"},{"line_number":54,"context_line":"# the root volume from an image."},{"line_number":55,"context_line":"nova boot --flavor ${flavor_id} --poll \\"},{"line_number":56,"context_line":"--block-device id\u003d${image_id},source\u003dimage,dest\u003dvolume,size\u003d1,bootindex\u003d0,shutdown\u003dremove \\"},{"line_number":57,"context_line":"--nic net-id\u003d${network_id} --availability-zone nova:${subnode} evacuate-bfv-test"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_d185fa08","side":"PARENT","line":56,"range":{"start_line":56,"start_character":30,"end_line":56,"end_character":73},"in_reply_to":"3fa7e38b_b1a71ebd","updated":"2019-11-07 19:18:20.000000000","message":"It\u0027s built in as the default when using this option.","commit_id":"f28839b523186121b6481e607321ddbff370cfc5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ad25a9a6d5bdce421dda9a2fb44ec21b59b8fd9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"# TODO(mriedem): Use OSC when it supports boot from volume where nova creates"},{"line_number":54,"context_line":"# the root volume from an image."},{"line_number":55,"context_line":"nova boot --flavor ${flavor_id} --poll \\"},{"line_number":56,"context_line":"--block-device id\u003d${image_id},source\u003dimage,dest\u003dvolume,size\u003d1,bootindex\u003d0,shutdown\u003dremove \\"},{"line_number":57,"context_line":"--nic net-id\u003d${network_id} --availability-zone nova:${subnode} evacuate-bfv-test"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_b1ae3e7f","side":"PARENT","line":56,"range":{"start_line":56,"start_character":30,"end_line":56,"end_character":73},"in_reply_to":"3fa7e38b_d185fa08","updated":"2019-11-07 19:21:32.000000000","message":"Gah, \"The root volume will not be deleted when the server is deleted.\" I missed that.","commit_id":"f28839b523186121b6481e607321ddbff370cfc5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ad25a9a6d5bdce421dda9a2fb44ec21b59b8fd9","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# Cleanup test servers"},{"line_number":146,"context_line":"openstack server delete --wait evacuate-test"},{"line_number":147,"context_line":"openstack server delete --wait evacuate-bfv-test"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_11bab2bf","side":"PARENT","line":147,"updated":"2019-11-07 19:21:32.000000000","message":"This is where we\u0027d remove the volume created by the --boot-from-volume option. Which makes it less useful to change to using that command.","commit_id":"f28839b523186121b6481e607321ddbff370cfc5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5e3d505b15aff339ba421eb623ca195c1bd61426","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"echo \"Creating BFV test server on subnode\""},{"line_number":53,"context_line":"openstack server create --image ${image_id} --flavor ${flavor_id} \\"},{"line_number":54,"context_line":"--wait --boot-from-volume 1 --nic net-id\u003d${network_id} \\"},{"line_number":55,"context_line":"--availability-zone nova:${subnode} evacuate-bfv-test"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"echo \"Forcing down the subnode so we can evacuate from it\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_9191c29d","line":54,"range":{"start_line":54,"start_character":26,"end_line":54,"end_character":27},"updated":"2019-11-07 18:59:48.000000000","message":"Some concern with respect to [1] - but the size was 1 before, it can remain 1. And [1] isn\u0027t going anywhere soon.\n\n[1] https://review.opendev.org/#/c/690991/","commit_id":"e0c986ea1aec795d7a93f059b8283a747d0fcfef"}]}