)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bc9c78f7baa8fae614249524874f720aad983da3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haiwei Xu \u003cxu-haiwei@mxw.nes.nec.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-02-01 04:54:48 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch HostBinaryNotFound exception when update a service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HostBinaryNotFound exception hasn\u0027t been catch when updating"},{"line_number":10,"context_line":"a service status which may cause the server to fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUX%2F%2FxsU%3D","line":7,"updated":"2014-02-10 21:26:56.000000000","message":"s/update/updating/ (femtonit)","commit_id":"86d27909622b28a43a4f1b9e0a734780ae9e610a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bc9c78f7baa8fae614249524874f720aad983da3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch HostBinaryNotFound exception when update a service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HostBinaryNotFound exception hasn\u0027t been catch when updating"},{"line_number":10,"context_line":"a service status which may cause the server to fail."},{"line_number":11,"context_line":"This patch fixes this bug."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUX%2F%2Fxsc%3D","line":9,"updated":"2014-02-10 21:26:56.000000000","message":"s/hasn\u0027t been catch/isn\u0027t caught/ (femtonit)","commit_id":"86d27909622b28a43a4f1b9e0a734780ae9e610a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"845dc4f1eeabb8f9cbbb3bf40380e0c96ddcf4ca","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When updating a service with a wrong host or binary name,"},{"line_number":10,"context_line":"HostBinaryNotFound exception is raised. However this exception"},{"line_number":11,"context_line":"isn\u0027t caught and the ServiceNotFound exception which won\u0027t happen"},{"line_number":12,"context_line":"here is caught instead."},{"line_number":13,"context_line":"This patch fixes this bug."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I64b138bad74c39d087addcd766b890c4076a2ce8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAVX%2F%2F%2Bu0%3D","line":12,"updated":"2014-02-27 01:52:14.000000000","message":"nit: the wording is a bit awkward here.","commit_id":"a6d28e811ad916d686e350ce2dd8f6b8b0e128d6"}],"nova/api/openstack/compute/plugins/v3/services.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9435da439c799ea23e2329a10546702ed8e28818","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            self.host_api.service_update(context, host, binary, status_detail)"},{"line_number":173,"context_line":"        except exception.HostBinaryNotFound as e:"},{"line_number":174,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return ret_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BJe4%3D","line":173,"updated":"2014-01-29 17:50:03.000000000","message":"Does it possible to handle ServiceNotfound and BinaryNotFound here?","commit_id":"485091d6cbce9392f9d85409451279cebd33dc72"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"e9d0ea2c6af4c0b6cca8a61bff4ab0c44ad5b8da","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            self.host_api.service_update(context, host, binary, status_detail)"},{"line_number":173,"context_line":"        except exception.HostBinaryNotFound as e:"},{"line_number":174,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return ret_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BHlU%3D","line":173,"in_reply_to":"AAAAUH%2F%2BJe4%3D","updated":"2014-01-30 00:05:09.000000000","message":"In fact, the ServiceNotFound will not happen during the service_update, so there is no need to handle it.","commit_id":"485091d6cbce9392f9d85409451279cebd33dc72"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9435da439c799ea23e2329a10546702ed8e28818","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            self.host_api.service_update(context, host, binary, status_detail)"},{"line_number":173,"context_line":"        except exception.HostBinaryNotFound as e:"},{"line_number":174,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return ret_value"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BJec%3D","line":174,"updated":"2014-01-29 17:50:03.000000000","message":"Why did you change the type of the http response error?","commit_id":"485091d6cbce9392f9d85409451279cebd33dc72"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8c1f37dc23bda49d134a35d5ad4c6d10edafda91","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            self.host_api.service_update(context, host, binary, status_detail)"},{"line_number":173,"context_line":"        except exception.HostBinaryNotFound as e:"},{"line_number":174,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return ret_value"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9%2FNA%3D","line":174,"in_reply_to":"AAAAUH%2F%2BHc8%3D","updated":"2014-01-31 10:05:55.000000000","message":"I feel HTTPNotFound is right, the wiki page just mentions invalid characters as some parameters and it does not cover this case.\n\nI88cfbe69e0bc0351e81a831345f2a36bf63f5f4f shows it.","commit_id":"485091d6cbce9392f9d85409451279cebd33dc72"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"e9d0ea2c6af4c0b6cca8a61bff4ab0c44ad5b8da","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            self.host_api.service_update(context, host, binary, status_detail)"},{"line_number":173,"context_line":"        except exception.HostBinaryNotFound as e:"},{"line_number":174,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return ret_value"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BHc8%3D","line":174,"in_reply_to":"AAAAUH%2F%2BJec%3D","updated":"2014-01-30 00:05:09.000000000","message":"You can refer to this page https://wiki.openstack.org/wiki/NovaAPIv2tov3\n\nos-services\u0027 update error code is 400 not 404.","commit_id":"485091d6cbce9392f9d85409451279cebd33dc72"}]}