)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ac6b5723c090ca5ddea9c5bee1e9f6eee49bbba2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Only nil az during shelve offload"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I25a4f36027390def83cfe25f4f3b4af9660da502 introduced a change to nil out"},{"line_number":10,"context_line":"the instance availability zone during shelve offload and when build or"},{"line_number":11,"context_line":"unshelve fails. This fix works from queens as in queens"},{"line_number":12,"context_line":"Iae904afb6cb4fcea8bb27741d774ffbe986a5fb4 added the feature to use the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_a1c48c0f","line":9,"updated":"2019-11-12 13:46:45.000000000","message":"Why not just revert this instead?","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"842bfbeb2b58d6d48f1251c8e8c5fe33e1b735db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Only nil az during shelve offload"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I25a4f36027390def83cfe25f4f3b4af9660da502 introduced a change to nil out"},{"line_number":10,"context_line":"the instance availability zone during shelve offload and when build or"},{"line_number":11,"context_line":"unshelve fails. This fix works from queens as in queens"},{"line_number":12,"context_line":"Iae904afb6cb4fcea8bb27741d774ffbe986a5fb4 added the feature to use the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_3283fecd","line":9,"in_reply_to":"3fa7e38b_a1c48c0f","updated":"2019-11-13 08:54:57.000000000","message":"Do you mean revert I25a4f36027390def83cfe25f4f3b4af9660da502 and then propose something that fixes bug 1790221 without breaking re-schedule? something like the combination of https://review.opendev.org/#/c/693817 and https://review.opendev.org/#/c/693839","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4bb683a92d889f389889e8f2b65b42c295580243","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the instance availability zone during shelve offload and when build or"},{"line_number":11,"context_line":"unshelve fails. This fix works from queens as in queens"},{"line_number":12,"context_line":"Iae904afb6cb4fcea8bb27741d774ffbe986a5fb4 added the feature to use the"},{"line_number":13,"context_line":"original alternate hosts during re-schedule."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"As in pike we don\u0027t have such feature during reschedule nova does a full"},{"line_number":16,"context_line":"new scheduler run. However I25a4f36027390def83cfe25f4f3b4af9660da502"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_adb0b041","line":13,"updated":"2019-11-18 18:50:08.000000000","message":"Ie5233bd481013413f12e55201588d37a9688ae78 also - if compute would pass the RequestSpec to conductor during rescheduling then conductor wouldn\u0027t have to build a RequestSpec from the instance fields.","commit_id":"297f4b0ef2b62cb284687db6cb59bbe4777c35a9"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ac6b5723c090ca5ddea9c5bee1e9f6eee49bbba2","unresolved":false,"context_lines":[{"line_number":1895,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":1896,"context_line":"                        instance, e, sys.exc_info(),"},{"line_number":1897,"context_line":"                        fault_message\u003de.kwargs[\u0027reason\u0027])"},{"line_number":1898,"context_line":"                self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":1899,"context_line":"                self._set_instance_obj_error_state(context, instance,"},{"line_number":1900,"context_line":"                                                   clean_task_state\u003dTrue)"},{"line_number":1901,"context_line":"                return build_results.FAILED"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a1ed6c8f","line":1898,"updated":"2019-11-12 13:46:45.000000000","message":"We\u0027re not going to reschedule here either.","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d1b54cf54473cc52607c48f4208373df4f827a7f","unresolved":false,"context_lines":[{"line_number":1895,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":1896,"context_line":"                        instance, e, sys.exc_info(),"},{"line_number":1897,"context_line":"                        fault_message\u003de.kwargs[\u0027reason\u0027])"},{"line_number":1898,"context_line":"                self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":1899,"context_line":"                self._set_instance_obj_error_state(context, instance,"},{"line_number":1900,"context_line":"                                                   clean_task_state\u003dTrue)"},{"line_number":1901,"context_line":"                return build_results.FAILED"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2dde2e10","line":1898,"in_reply_to":"3fa7e38b_a1ed6c8f","updated":"2019-11-14 10:28:52.000000000","message":"Done","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ac6b5723c090ca5ddea9c5bee1e9f6eee49bbba2","unresolved":false,"context_lines":[{"line_number":1932,"context_line":"                self.network_api.cleanup_instance_network_on_host("},{"line_number":1933,"context_line":"                    context, instance, self.host)"},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"            self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":1936,"context_line":"            instance.task_state \u003d task_states.SCHEDULING"},{"line_number":1937,"context_line":"            instance.save()"},{"line_number":1938,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_81eab071","line":1935,"updated":"2019-11-12 13:46:45.000000000","message":"This is the only case we don\u0027t null out the instance AZ. Maybe the default on the kwarg should be True and here we just pass False since we\u0027re going to reschedule. Then the default on the method makes the most sense in the most cases.","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d1b54cf54473cc52607c48f4208373df4f827a7f","unresolved":false,"context_lines":[{"line_number":1932,"context_line":"                self.network_api.cleanup_instance_network_on_host("},{"line_number":1933,"context_line":"                    context, instance, self.host)"},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"            self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":1936,"context_line":"            instance.task_state \u003d task_states.SCHEDULING"},{"line_number":1937,"context_line":"            instance.save()"},{"line_number":1938,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ede7b6e2","line":1935,"in_reply_to":"3fa7e38b_81eab071","updated":"2019-11-14 10:28:52.000000000","message":"Done","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a89d4dbf17a94594f0a8c7807ff35510637d50fa","unresolved":false,"context_lines":[{"line_number":1932,"context_line":"                self.network_api.cleanup_instance_network_on_host("},{"line_number":1933,"context_line":"                    context, instance, self.host)"},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"            self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":1936,"context_line":"            instance.task_state \u003d task_states.SCHEDULING"},{"line_number":1937,"context_line":"            instance.save()"},{"line_number":1938,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_941417a1","line":1935,"in_reply_to":"3fa7e38b_81eab071","updated":"2019-11-13 16:54:20.000000000","message":"also IIUC this means that if no az was requested initially this would mean that we will be trying to schedule only on the hosts in the same AZ as the first failed compute, but it was the case prior to change to nil out the AZ anyway","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ac6b5723c090ca5ddea9c5bee1e9f6eee49bbba2","unresolved":false,"context_lines":[{"line_number":4638,"context_line":"                self._terminate_volume_connections(context, instance, bdms)"},{"line_number":4639,"context_line":"                # The reverts_task_state decorator on unshelve_instance will"},{"line_number":4640,"context_line":"                # eventually save these updates."},{"line_number":4641,"context_line":"                self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":4642,"context_line":""},{"line_number":4643,"context_line":"        if image:"},{"line_number":4644,"context_line":"            instance.image_ref \u003d shelved_image_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_41fcb83e","line":4641,"updated":"2019-11-12 13:46:45.000000000","message":"There is no reschedule during unshelve so this is another case where the instance AZ can be nulled out.","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d1b54cf54473cc52607c48f4208373df4f827a7f","unresolved":false,"context_lines":[{"line_number":4638,"context_line":"                self._terminate_volume_connections(context, instance, bdms)"},{"line_number":4639,"context_line":"                # The reverts_task_state decorator on unshelve_instance will"},{"line_number":4640,"context_line":"                # eventually save these updates."},{"line_number":4641,"context_line":"                self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":4642,"context_line":""},{"line_number":4643,"context_line":"        if image:"},{"line_number":4644,"context_line":"            instance.image_ref \u003d shelved_image_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8dce4259","line":4641,"in_reply_to":"3fa7e38b_41fcb83e","updated":"2019-11-14 10:28:52.000000000","message":"Done","commit_id":"9ba6e53399d1c20e7d0df517c69620548fe14b6b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d95fd113630103b62e782b9deea322a01e31d233","unresolved":false,"context_lines":[{"line_number":1883,"context_line":"            LOG.info(\u0027Took %0.2f seconds to build instance.\u0027,"},{"line_number":1884,"context_line":"                     timer.elapsed(), instance\u003dinstance)"},{"line_number":1885,"context_line":"            return build_results.ACTIVE"},{"line_number":1886,"context_line":"        except exception.RescheduledException as e:"},{"line_number":1887,"context_line":"            retry \u003d filter_properties.get(\u0027retry\u0027)"},{"line_number":1888,"context_line":"            if not retry:"},{"line_number":1889,"context_line":"                # no retry information, do not reschedule."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_61eddf23","line":1886,"updated":"2019-11-18 23:52:43.000000000","message":"Note to self: handling is under RescheduledException.","commit_id":"297f4b0ef2b62cb284687db6cb59bbe4777c35a9"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4bb683a92d889f389889e8f2b65b42c295580243","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        self.assertIsNone(instance.node)"},{"line_number":560,"context_line":"        self.assertIsNotNone(instance.availability_zone)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_nil_out_inst_obj_host_and_node_nils_az(self):"},{"line_number":563,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context,"},{"line_number":564,"context_line":"                                                   uuid\u003duuids.instance,"},{"line_number":565,"context_line":"                                                   host\u003d\u0027foo-host\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8d8cd480","line":562,"updated":"2019-11-18 18:50:08.000000000","message":"I don\u0027t think we really need this given the functional test covers it but it\u0027s a nit.","commit_id":"297f4b0ef2b62cb284687db6cb59bbe4777c35a9"}]}