)]}'
{"nova/compute/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"48cb21dc214d3564ffba31c485fbfdbfeacb0d0b","unresolved":false,"context_lines":[{"line_number":3847,"context_line":"            flavor\u003dnew_instance_type,"},{"line_number":3848,"context_line":"            clean_shutdown\u003dclean_shutdown,"},{"line_number":3849,"context_line":"            request_spec\u003drequest_spec,"},{"line_number":3850,"context_line":"            do_cast\u003dTrue)"},{"line_number":3851,"context_line":""},{"line_number":3852,"context_line":"    @check_instance_lock"},{"line_number":3853,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_580b4221","line":3850,"range":{"start_line":3850,"start_character":12,"end_line":3850,"end_character":24},"updated":"2019-11-12 21:53:49.000000000","message":"Why keep this instead of just removing it and making this always cast? Unless I\u0027m mistaken this is the only place we call this...","commit_id":"97e8a1340600f0f9def1db1ffcea604cca0b5366"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12c1b96e5220a6fd9b20bf6c50b1a39569887daa","unresolved":false,"context_lines":[{"line_number":3847,"context_line":"            flavor\u003dnew_instance_type,"},{"line_number":3848,"context_line":"            clean_shutdown\u003dclean_shutdown,"},{"line_number":3849,"context_line":"            request_spec\u003drequest_spec,"},{"line_number":3850,"context_line":"            do_cast\u003dTrue)"},{"line_number":3851,"context_line":""},{"line_number":3852,"context_line":"    @check_instance_lock"},{"line_number":3853,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_88bba273","line":3850,"range":{"start_line":3850,"start_character":12,"end_line":3850,"end_character":24},"in_reply_to":"3fa7e38b_580b4221","updated":"2019-11-13 14:19:33.000000000","message":"Compute calls this if we\u0027re rescheduling during a same-cell resize:\n\nhttps://github.com/openstack/nova/blob/7aa88029bbf6311033457c32801963da01e88ecb/nova/compute/manager.py#L4788\n\nI left that as a call since there is logic in the compute to handle if the reschedule blows up.","commit_id":"97e8a1340600f0f9def1db1ffcea604cca0b5366"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2fcdf2ff50454b0a7c4a6338df118613ce4838dc","unresolved":false,"context_lines":[{"line_number":3847,"context_line":"            flavor\u003dnew_instance_type,"},{"line_number":3848,"context_line":"            clean_shutdown\u003dclean_shutdown,"},{"line_number":3849,"context_line":"            request_spec\u003drequest_spec,"},{"line_number":3850,"context_line":"            do_cast\u003dTrue)"},{"line_number":3851,"context_line":""},{"line_number":3852,"context_line":"    @check_instance_lock"},{"line_number":3853,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_be6a547e","line":3850,"range":{"start_line":3850,"start_character":12,"end_line":3850,"end_character":24},"in_reply_to":"3fa7e38b_88bba273","updated":"2019-11-13 15:21:30.000000000","message":"I updated the commit message with a note about this.","commit_id":"97e8a1340600f0f9def1db1ffcea604cca0b5366"}],"nova/objects/instance_action.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0437827a63da6a96d61428dbb92b6d6423df658","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            values[\u0027result\u0027] \u003d \u0027Success\u0027"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            values[\u0027result\u0027] \u003d \u0027Error\u0027"},{"line_number":187,"context_line":"            # FIXME(mriedem): message is not used. The instance_actions_events"},{"line_number":188,"context_line":"            # table has a \"details\" column but not a \"message\" column which"},{"line_number":189,"context_line":"            # means the exc_val is never stored in the record. So far it does"},{"line_number":190,"context_line":"            # not matter because the exc_val is not exposed out of the API,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9462d73c","line":187,"updated":"2019-11-13 16:56:00.000000000","message":"http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010775.html","commit_id":"a05ef30fb9eb2f5250748e5a87f8b61e77464be9"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c49f096d3da31d832e51117ebabbbe9e6d9478cc","unresolved":false,"context_lines":[{"line_number":4705,"context_line":"                                            {\u0027OS-EXT-STS:task_state\u0027: None})"},{"line_number":4706,"context_line":""},{"line_number":4707,"context_line":"        # The instance action should have failed with details."},{"line_number":4708,"context_line":"        self._assert_resize_migrate_action_fail("},{"line_number":4709,"context_line":"            server, instance_actions.MIGRATE, \u0027claim_resources\u0027)"},{"line_number":4710,"context_line":""},{"line_number":4711,"context_line":"        # The migration is aborted so the instance is ACTIVE on the source"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_52c47a0e","line":4708,"updated":"2019-11-13 09:00:56.000000000","message":"Functional test fails here.","commit_id":"97e8a1340600f0f9def1db1ffcea604cca0b5366"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12c1b96e5220a6fd9b20bf6c50b1a39569887daa","unresolved":false,"context_lines":[{"line_number":4705,"context_line":"                                            {\u0027OS-EXT-STS:task_state\u0027: None})"},{"line_number":4706,"context_line":""},{"line_number":4707,"context_line":"        # The instance action should have failed with details."},{"line_number":4708,"context_line":"        self._assert_resize_migrate_action_fail("},{"line_number":4709,"context_line":"            server, instance_actions.MIGRATE, \u0027claim_resources\u0027)"},{"line_number":4710,"context_line":""},{"line_number":4711,"context_line":"        # The migration is aborted so the instance is ACTIVE on the source"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_683bc6e9","line":4708,"in_reply_to":"3fa7e38b_52c47a0e","updated":"2019-11-13 14:19:33.000000000","message":"Guh, yeah. I ran all of the functional tests again before pushing this so this might be some race failure. I\u0027ll try again locally.\n\nThis is why I left the FIXME in the instance action event code because it would be a lot more straightforward if I could just check the instance action event API for the specific type of expected failure, AllocationUpdateFailed in this case.","commit_id":"97e8a1340600f0f9def1db1ffcea604cca0b5366"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9a1b4f68732e852f75a0eb3ed59e5f7140eebc1f","unresolved":false,"context_lines":[{"line_number":4705,"context_line":"                                            {\u0027OS-EXT-STS:task_state\u0027: None})"},{"line_number":4706,"context_line":""},{"line_number":4707,"context_line":"        # The instance action should have failed with details."},{"line_number":4708,"context_line":"        self._assert_resize_migrate_action_fail("},{"line_number":4709,"context_line":"            server, instance_actions.MIGRATE, \u0027claim_resources\u0027)"},{"line_number":4710,"context_line":""},{"line_number":4711,"context_line":"        # The migration is aborted so the instance is ACTIVE on the source"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_88172255","line":4708,"in_reply_to":"3fa7e38b_683bc6e9","updated":"2019-11-13 14:20:29.000000000","message":"\u003e Guh, yeah. I ran all of the functional tests again before pushing\n \u003e this so this might be some race failure. I\u0027ll try again locally.\n \u003e \n\nI guess I ran functional-py36, not functional (py27) so maybe that\u0027s the difference in behavior.","commit_id":"97e8a1340600f0f9def1db1ffcea604cca0b5366"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2fcdf2ff50454b0a7c4a6338df118613ce4838dc","unresolved":false,"context_lines":[{"line_number":4705,"context_line":"                                            {\u0027OS-EXT-STS:task_state\u0027: None})"},{"line_number":4706,"context_line":""},{"line_number":4707,"context_line":"        # The instance action should have failed with details."},{"line_number":4708,"context_line":"        self._assert_resize_migrate_action_fail("},{"line_number":4709,"context_line":"            server, instance_actions.MIGRATE, \u0027claim_resources\u0027)"},{"line_number":4710,"context_line":""},{"line_number":4711,"context_line":"        # The migration is aborted so the instance is ACTIVE on the source"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_fec20c86","line":4708,"in_reply_to":"3fa7e38b_88172255","updated":"2019-11-13 15:21:30.000000000","message":"Done","commit_id":"97e8a1340600f0f9def1db1ffcea604cca0b5366"}]}